messaging-app

Merge lp:~tiagosh/messaging-app/fix-1227351 into lp:messaging-app

fix-1227351
Merge into trunk

Proposed by Tiago Salem Herrmann on 2013-09-20

Status:	Merged
Approved by:	Gustavo Pichorim Boiko on 2013-09-23
Approved revision:	35
Merged at revision:	36
Proposed branch:	lp:~tiagosh/messaging-app/fix-1227351
Merge into:	lp:messaging-app
Diff against target:	38 lines (+17/-0) 2 files modified src/qml/MainPage.qml (+9/-0) src/qml/Messages.qml (+8/-0)
To merge this branch:	bzr merge lp:~tiagosh/messaging-app/fix-1227351
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2013-09-23
Gustavo Pichorim Boiko (community)		2013-09-20	Approve on 2013-09-23
Review via email: mp+186864@code.launchpad.net

Commit message

Add a visual feedback for selected messages/conversations.

Description of the change

Add a visual feedback for selected messages/conversations.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-20:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/messaging-app-ci/54/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2013-09-23:

Maybe you should use the color orange as the one used in the address-book-app:
color: UbuntuColors.orange

Also, can you add a FIXME comment saying that this should be done automatically in UITK instead of doing on each and every app?

review: Needs Fixing

lp:~tiagosh/messaging-app/fix-1227351 updated on 2013-09-23

34. By Tiago Salem Herrmann on 2013-09-23: use UbuntuColors.orange for the background
35. By Tiago Salem Herrmann on 2013-09-23: add comment

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2013-09-23:

Looks good now.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-23:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/messaging-app-ci/55/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Sam Short

Tiago Salem Herrmann

Ubuntu Phablet Team

 === modified file 'src/qml/MainPage.qml'
 --- src/qml/MainPage.qml	2013-09-17 03:22:44 +0000
 +++ src/qml/MainPage.qml	2013-09-23 21:47:21 +0000
@@ -86,6 +86,15 @@
              selectionMode: threadList.isInSelectionMode
              selected: threadList.isSelected(threadDelegate)
              removable: !selectionMode
++            // FIXME: the selected state should be handled by the UITK
++            Rectangle {
++                visible: selected
++                color: UbuntuColors.orange
++                opacity: 0.5
++                anchors.fill: parent
++                z: -1
++            }
++
              onClicked: {
                  if (threadList.isInSelectionMode) {
                      if (!threadList.selectItem(threadDelegate)) {
 === modified file 'src/qml/Messages.qml'
 --- src/qml/Messages.qml	2013-09-19 21:41:46 +0000
 +++ src/qml/Messages.qml	2013-09-23 21:47:21 +0000
@@ -332,6 +332,14 @@
              incoming: senderId != "self"
              selected: messageList.isSelected(messageDelegate)
              removable: !selectionMode
++            // FIXME: the selected state should be handled by the UITK
++            Rectangle {
++                visible: selected
++                color: UbuntuColors.orange
++                opacity: 0.5
++                anchors.fill: parent
++                z: -1
++            }
              onClicked: {
                  if (messageList.isInSelectionMode) {
                      if (!messageList.selectItem(messageDelegate)) {