Merge lp:~tiagosh/history-service/fix-1510655 into lp:history-service

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 224
Merged at revision: 224
Proposed branch: lp:~tiagosh/history-service/fix-1510655
Merge into: lp:history-service
Diff against target: 22 lines (+11/-1)
1 file modified
src/participant.cpp (+11/-1)
To merge this branch: bzr merge lp:~tiagosh/history-service/fix-1510655
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+281537@code.launchpad.net

Commit message

Do proper dbus demarshalling of detailProperties.

Description of the change

Do proper dbus demarshalling of detailProperties.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/participant.cpp'
2--- src/participant.cpp 2015-10-13 19:13:41 +0000
3+++ src/participant.cpp 2016-01-04 18:30:43 +0000
4@@ -157,7 +157,17 @@
5 QString contactId = properties[FieldContactId].toString();
6 QString alias = properties[FieldAlias].toString();
7 QString avatar = properties[FieldAvatar].toString();
8- QVariantMap detailProperties = properties[FieldDetailProperties].toMap();
9+ QVariantMap detailProperties;
10+ QVariant detailPropertiesVariant = properties[FieldDetailProperties];
11+ if (detailPropertiesVariant.canConvert<QVariantMap>()) {
12+ detailProperties = detailPropertiesVariant.toMap();
13+ } else if (detailPropertiesVariant.canConvert<QDBusArgument>()) {
14+ detailProperties = qdbus_cast<QVariantMap>(detailPropertiesVariant);
15+ Q_FOREACH(const QString &key, detailProperties.keys()) {
16+ QList<QVariant> list = qdbus_cast<QList<QVariant> >(detailProperties[key]);
17+ detailProperties[key] = QVariant::fromValue(list);
18+ }
19+ }
20
21 return Participant(accountId, identifier, contactId, alias, avatar, detailProperties);
22 }

Subscribers

People subscribed via source and target branches