Merge lp:~tiagosh/gsettings-ubuntu-touch-schemas/enable-group-chat into lp:gsettings-ubuntu-touch-schemas

Proposed by Tiago Salem Herrmann on 2015-05-20
Status: Merged
Approved by: Sebastien Bacher on 2015-05-21
Approved revision: 55
Merged at revision: 55
Proposed branch: lp:~tiagosh/gsettings-ubuntu-touch-schemas/enable-group-chat
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 12 lines (+1/-1)
1 file modified
schemas/com.ubuntu.phone.gschema.xml.in.in (+1/-1)
To merge this branch: bzr merge lp:~tiagosh/gsettings-ubuntu-touch-schemas/enable-group-chat
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) 2015-05-20 Approve on 2015-05-21
Review via email: mp+259682@code.launchpad.net

Commit Message

Enable mms group chat by default

Description of the Change

Enable mms group chat by default

To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

Thanks, that seems fine to me but I've some questions...
- why that not enabled by default before? What is the cost/side effect of enabling it?
- do we still have a reason we want to turn that off?

if it's enabled by default and always makes sense/has no user configuration UI maybe it doesn't need to be an option anymore?

review: Needs Information
Tiago Salem Herrmann (tiagosh) wrote :

thanks for the review,

- the option was disabled by default because the mms group chat feature wasn't fully implemented.
- users that don't have mms support might want to disable it, so they can send multi-recipient sms messages instead of mms group chats.

The settings screen is implemented in messaging-app:
https://code.launchpad.net/~tiagosh/messaging-app/messaging-settings-page/+merge/257832

Sebastien Bacher (seb128) wrote :

thanks for the reply!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'schemas/com.ubuntu.phone.gschema.xml.in.in'
2--- schemas/com.ubuntu.phone.gschema.xml.in.in 2015-01-28 13:08:08 +0000
3+++ schemas/com.ubuntu.phone.gschema.xml.in.in 2015-05-20 20:42:39 +0000
4@@ -14,7 +14,7 @@
5 <_description>Default sim card to use for messages, defined by a modem path or "ask".</_description>
6 </key>
7 <key name="mms-group-chat-enabled" type="b">
8- <default>false</default>
9+ <default>true</default>
10 <_description>Enable sending group chat messages over MMS.</_description>
11 </key>
12 </schema>

Subscribers

People subscribed via source and target branches