Merge lp:~tiagosh/dialer-app/use-empty-filter into lp:dialer-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 192
Merged at revision: 194
Proposed branch: lp:~tiagosh/dialer-app/use-empty-filter
Merge into: lp:dialer-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/qml/HistoryPage/HistoryPage.qml (+1/-0)
To merge this branch: bzr merge lp:~tiagosh/dialer-app/use-empty-filter
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+228344@code.launchpad.net

Commit message

Use an empty filter to return all the entries

Description of the change

Use an empty filter to return all the entries

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~tiagosh/history-service/mms-send-fixes/+merge/228341

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/HistoryPage/HistoryPage.qml'
2--- src/qml/HistoryPage/HistoryPage.qml 2014-07-17 20:40:47 +0000
3+++ src/qml/HistoryPage/HistoryPage.qml 2014-07-25 16:29:36 +0000
4@@ -121,6 +121,7 @@
5 sortField: "timestamp"
6 sortOrder: HistorySort.DescendingOrder
7 }
8+ filter: HistoryFilter {}
9 }
10
11 SortProxyModel {

Subscribers

People subscribed via source and target branches