Merge lp:~tiagosh/dialer-app/sim-presence into lp:dialer-app
Status: | Merged | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Ćukasz Zemczak | ||||||||||||||||||||
Approved revision: | 231 | ||||||||||||||||||||
Merged at revision: | 230 | ||||||||||||||||||||
Proposed branch: | lp:~tiagosh/dialer-app/sim-presence | ||||||||||||||||||||
Merge into: | lp:dialer-app | ||||||||||||||||||||
Diff against target: |
570 lines (+202/-110) 5 files modified
po/dialer-app.pot (+162/-87) src/qml/DialerPage/DialerPage.qml (+19/-19) src/qml/Dialogs/NoDefaultSIMCardDialog.qml (+1/-1) src/qml/LiveCallPage/LiveCall.qml (+1/-0) src/qml/dialer-app.qml (+19/-3) |
||||||||||||||||||||
To merge this branch: | bzr merge lp:~tiagosh/dialer-app/sim-presence | ||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Pichorim Boiko (community) | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+231042@code.launchpad.net |
Commit message
- Display operator name in the header when available
- Do not display slots without sim cards.
Description of the change
- Display operator name in the header when available
- Do not display slots without sim cards.
--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
https:/
https:/
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed UI labels, did you update the pot file?
Yes
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
FAILED: Continuous integration, rev:228 jenkins. qa.ubuntu. com/job/ dialer- app-ci/ 395/ jenkins. qa.ubuntu. com/job/ dialer- app-utopic- amd64-ci/ 166 jenkins. qa.ubuntu. com/job/ dialer- app-utopic- armhf-ci/ 165 jenkins. qa.ubuntu. com/job/ dialer- app-utopic- armhf-ci/ 165/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ dialer- app-utopic- i386-ci/ 166 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/3630 jenkins. qa.ubuntu. com/job/ generic- mediumtests- utopic/ 2839 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/3520 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/4877 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/4877/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 11590 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-utopic/ 2303 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/3123 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/3123/ artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/dialer- app-ci/ 395/rebuild
http://