Merge lp:~tiagosh/dialer-app/rtm-14.09-fix-1410961 into lp:dialer-app/rtm-14.09

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 253
Merged at revision: 254
Proposed branch: lp:~tiagosh/dialer-app/rtm-14.09-fix-1410961
Merge into: lp:dialer-app/rtm-14.09
Prerequisite: lp:~boiko/dialer-app/rtm-greeter_refactor
Diff against target: 45 lines (+14/-3)
1 file modified
src/qml/LiveCallPage/LiveCall.qml (+14/-3)
To merge this branch: bzr merge lp:~tiagosh/dialer-app/rtm-14.09-fix-1410961
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+246803@code.launchpad.net

This proposal supersedes a proposal from 2015-01-17.

Commit message

Give some time to finish the greeter animation before removing the LiveCall view.

Description of the change

Give some time to finish the greeter animation before removing the LiveCall view.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
2--- src/qml/LiveCallPage/LiveCall.qml 2015-01-17 02:41:56 +0000
3+++ src/qml/LiveCallPage/LiveCall.qml 2015-01-17 02:41:56 +0000
4@@ -192,7 +192,7 @@
5
6 State {
7 name: "closing"
8- when: closeTimer.running
9+ when: closeTimer.running || greeterAnimationTimer.running
10
11 PropertyChanges {
12 target: buttonsArea
13@@ -255,19 +255,30 @@
14 }
15
16 Timer {
17+ id: greeterAnimationTimer
18+ interval: 1000
19+ repeat: false
20+ running: false
21+ onTriggered: mainView.removeLiveCallView()
22+ }
23+
24+ Timer {
25 id: closeTimer
26- interval: 3000
27+ interval: mainView.greeterMode ? 2000 : 3000
28 repeat: false
29 running: false
30 onTriggered: {
31 if (!callManager.hasCalls) {
32- mainView.removeLiveCallView();
33+ if (!mainView.greeterMode) {
34+ mainView.removeLiveCallView();
35+ }
36 // TODO: we can't be sure that the currentPage is a DialerPage instance
37 if (pageStackNormalMode.currentPage.dialNumber) {
38 pageStackNormalMode.currentPage.dialNumber = pendingNumberToDial;
39 }
40 if (mainView.greeterMode) {
41 greeter.showGreeter();
42+ greeterAnimationTimer.running = true
43 }
44 }
45 }

Subscribers

People subscribed via source and target branches