Merge lp:~tiagosh/dialer-app/rtm-14.09-fix-1398525 into lp:dialer-app/rtm-14.09

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 243
Merged at revision: 243
Proposed branch: lp:~tiagosh/dialer-app/rtm-14.09-fix-1398525
Merge into: lp:dialer-app/rtm-14.09
Diff against target: 34 lines (+8/-2)
1 file modified
src/qml/LiveCallPage/LiveCall.qml (+8/-2)
To merge this branch: bzr merge lp:~tiagosh/dialer-app/rtm-14.09-fix-1398525
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+244625@code.launchpad.net

Commit message

Consider "wired_headset" and "earpiece" as default audio outputs.

Description of the change

Consider "wired_headset" and "earpiece" as default audio outputs.

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

tested, approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
2--- src/qml/LiveCallPage/LiveCall.qml 2014-12-04 13:15:18 +0000
3+++ src/qml/LiveCallPage/LiveCall.qml 2014-12-12 16:24:44 +0000
4@@ -96,6 +96,12 @@
5 closeTimer.running = true;
6 }
7
8+ function isDefaultAudioOutput(id) {
9+ return (id == "default" ||
10+ id == "wired_headset" ||
11+ id == "earpiece")
12+ }
13+
14 Connections {
15 target: callManager
16 onHasCallsChanged: {
17@@ -566,7 +572,7 @@
18 }
19 }
20 }
21- selected: activeAudioOutput != "default"
22+ selected: !isDefaultAudioOutput(activeAudioOutput)
23 iconWidth: units.gu(3)
24 iconHeight: units.gu(3)
25 onClicked: {
26@@ -579,7 +585,7 @@
27 PopupUtils.open(audioOutputsPopover, speakerButton)
28 return
29 }
30- if (call.activeAudioOutput == "default") {
31+ if (isDefaultAudioOutput(call.activeAudioOutput)) {
32 call.activeAudioOutput = "speaker"
33 } else {
34 call.activeAudioOutput = "default"

Subscribers

People subscribed via source and target branches