Merge lp:~tiagosh/address-book-service/close-view-asynchronously into lp:address-book-service

[Tiago Salem Herrmann]

Close views asynchronously.

Close views asynchronously.

[lp:~tiagosh/address-book-service/close-view-asynchronously]

161. By Tiago Salem Herrmann on 2015-09-09

use deleteLater() instead of delete

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:160
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/375/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4088
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3339
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4085
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4085/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23179

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/375/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:161
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/377/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/61
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/61/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/61
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4090
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3341
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4087
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4087/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23181

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/377/rebuild

review: Approve (continuous-integration)

=== modified file 'contacts/qcontactfetchrequest-data.cpp'
--- contacts/qcontactfetchrequest-data.cpp	2014-07-11 13:11:19 +0000
+++ contacts/qcontactfetchrequest-data.cpp	2015-09-09 17:45:29 +0000
@@ -41,7 +41,7 @@
 
 QContactFetchRequestData::~QContactFetchRequestData()
 {
-    delete m_runningParser;
+    m_runningParser->deleteLater();
 }
 
 int QContactFetchRequestData::offset() const
@@ -134,7 +134,7 @@
 void QContactFetchRequestData::deleteView(QDBusInterface *view)
 {
     if (view) {
-        view->call("close");
+        view->asyncCall("close");
         view->deleteLater();
     }
 }

=== modified file 'lib/view.cpp'
--- lib/view.cpp	2014-10-15 18:53:34 +0000
+++ lib/view.cpp	2015-09-09 17:45:29 +0000
@@ -196,7 +196,7 @@
             m_filterThread->stop();
             m_filterThread->wait();
         }
-        delete m_filterThread;
+        m_filterThread->deleteLater();
         m_filterThread = 0;
     }
 }