Merge lp:~tiagosh/address-book-app/fix-1234234 into lp:address-book-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 95
Merged at revision: 97
Proposed branch: lp:~tiagosh/address-book-app/fix-1234234
Merge into: lp:address-book-app
Diff against target: 18 lines (+3/-3)
1 file modified
src/app/addressbookapp.cpp (+3/-3)
To merge this branch: bzr merge lp:~tiagosh/address-book-app/fix-1234234
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+189972@code.launchpad.net

Commit message

Use url decoding before using values.

Description of the change

Use url decoding before using values.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good and works as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/addressbookapp.cpp'
2--- src/app/addressbookapp.cpp 2013-10-04 00:13:49 +0000
3+++ src/app/addressbookapp.cpp 2013-10-08 20:55:15 +0000
4@@ -324,11 +324,11 @@
5 method.invoke(mainView);
6 break;
7 case 1:
8- method.invoke(mainView, Q_ARG(QVariant, QVariant(args[0])));
9+ method.invoke(mainView, Q_ARG(QVariant, QVariant(QUrl::fromPercentEncoding(args[0].toUtf8()))));
10 break;
11 case 2:
12- method.invoke(mainView, Q_ARG(QVariant, QVariant(args[0])),
13- Q_ARG(QVariant, QVariant(args[1])));
14+ method.invoke(mainView, Q_ARG(QVariant, QVariant(QUrl::fromPercentEncoding(args[0].toUtf8()))),
15+ Q_ARG(QVariant, QVariant(QUrl::fromPercentEncoding(args[1].toUtf8()))));
16 break;
17 default:
18 qWarning() << "Invalid arguments";

Subscribers

People subscribed via source and target branches