Merge lp:~thumper/unity/non-modifier-hud into lp:unity
Status: | Merged |
---|---|
Approved by: | Tim Penhey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2223 |
Proposed branch: | lp:~thumper/unity/non-modifier-hud |
Merge into: | lp:unity |
Diff against target: |
166 lines (+75/-26) 4 files modified
plugins/unityshell/src/unityshell.cpp (+47/-25) plugins/unityshell/src/unityshell.h (+1/-0) tests/autopilot/autopilot/tests/__init__.py (+2/-0) tests/autopilot/autopilot/tests/test_hud.py (+25/-1) |
To merge this branch: | bzr merge lp:~thumper/unity/non-modifier-hud |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Thomi Richards (community) | Approve | ||
Review via email: mp+100906@code.launchpad.net |
Commit message
Allow Unity to correctly respond to a non-modifier key-binding for "show hud".
Description of the change
= Problem =
Due to the way the HUD was initially designed to work, there was assumed behaviour in the handlers for the key-bindings that caused non-modifier key-bindings for the HUD reveal to not work very well.
= Solution =
When there is an initiate event from compiz, if the key-binding is modifier only, then the keycode is unset (or zero in the future). If we have a key-code, then the show_hud key-binding has been remapped, and we should show the hud on the initiate (key down), rather than waiting for a key-release to determine a tap.
= Tests =
Autopilot tests included working with <Super>h and <Ctrl><Alt>h.
No commit message specified.