Merge lp:~thumper/unity/fix-launcher-multimonitor-resaturate into lp:unity
Proposed by
Tim Penhey
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 2164 | ||||||||
Proposed branch: | lp:~thumper/unity/fix-launcher-multimonitor-resaturate | ||||||||
Merge into: | lp:unity | ||||||||
Diff against target: |
261 lines (+81/-23) 5 files modified
manual-tests/Launcher.txt (+16/-0) manual-tests/Panel.txt (+14/-0) plugins/unityshell/src/Launcher.cpp (+19/-4) plugins/unityshell/src/PanelView.cpp (+30/-18) plugins/unityshell/src/PanelView.h (+2/-1) |
||||||||
To merge this branch: | bzr merge lp:~thumper/unity/fix-launcher-multimonitor-resaturate | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards (community) | Approve | ||
Review via email: mp+98957@code.launchpad.net |
Commit message
Make the panel more aware of open overlays, and make sure that all launchers resaturate the icons when overlays (the dash or hud) are closed.
Description of the change
== The problem ==
1. With multiple monitors, closing the hud or dash on one monitor would cause the launcher on one monitor to stay with desaturated icons.
2. The panel would go solid if switching from the hud to the dash (or vice versa) without closing the open overlay first.
== The solution ==
1. A little brutal, but request a redraw when an overlay closes.
2. Remember which overlay last opened, and only go solid if the close matches the last open.
== Tests ==
Manual I'm afraid.
UNBLOCK
To post a comment you must log in.
Pity about the manual tests, but looks good otherwise.