Nux

Merge lp:~thumper/nux/move-geometry-typedef-to-rect into lp:nux

Proposed by Tim Penhey
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 735
Merged at revision: 735
Proposed branch: lp:~thumper/nux/move-geometry-typedef-to-rect
Merge into: lp:nux
Diff against target: 25 lines (+1/-3)
2 files modified
Nux/Utils.h (+0/-2)
NuxCore/Rect.h (+1/-1)
To merge this branch: bzr merge lp:~thumper/nux/move-geometry-typedef-to-rect
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Brandon Schaefer (community) Approve
Review via email: mp+139126@code.launchpad.net

Commit message

Move the typedef for Geometry from Nux/Utils.h into the NuxCore/Rect.h header file.

Description of the change

Move the typedef for Geometry from Nux/Utils.h into the NuxCore/Rect.h header file.

Removes some of the "magic".

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Awesome!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Nux/Utils.h'
2--- Nux/Utils.h 2011-10-10 01:52:00 +0000
3+++ Nux/Utils.h 2012-12-11 01:15:25 +0000
4@@ -96,8 +96,6 @@
5 eHARight,
6 };
7
8- typedef Rect Geometry;
9-
10 typedef struct
11 {
12 int x;
13
14=== modified file 'NuxCore/Rect.h'
15--- NuxCore/Rect.h 2012-11-23 08:40:36 +0000
16+++ NuxCore/Rect.h 2012-12-11 01:15:25 +0000
17@@ -122,7 +122,7 @@
18 Rect operator-(Rect const& lhs, Rect const& rhs);
19 Rect operator*(Rect const& lhs, float scalar);
20
21-
22+ typedef Rect Geometry;
23 }
24
25 #endif // RECT_H

Subscribers

People subscribed via source and target branches