Merge lp:~thumper/launchpad/show-recipe-upload-issue into lp:launchpad
Proposed by
Tim Penhey
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12186 |
Proposed branch: | lp:~thumper/launchpad/show-recipe-upload-issue |
Merge into: | lp:launchpad |
Diff against target: |
129 lines (+69/-0) 3 files modified
lib/lp/app/browser/tales.py (+6/-0) lib/lp/code/browser/sourcepackagerecipe.py (+23/-0) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+40/-0) |
To merge this branch: | bzr merge lp:~thumper/launchpad/show-recipe-upload-issue |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | ui | Approve | |
Graham Binns (community) | code | Approve | |
Review via email: mp+45804@code.launchpad.net |
Commit message
[r=gmb][ui=sinzui][bug=700864] Show a warning to the user if the daily build won't happen due to PPA upload permission problems.
Description of the change
This issue was discovered while debugging a problem with the awn-testing recipe.
If the recipe owner does not have upload rights to the daily build PPA the daily recipe jobs are not created.
Here is an example of the error shown:
http://
This is not something we can always check on creation or editing as the person may be removed from a team that has a PPA that was having the builds working.
To post a comment you must log in.
I'm happy with the code here but it should probably get a review for the UI, too. I'll request a UI review for it whilst I'm here.