Merge lp:~thumper/launchpad/recipe-builds into lp:launchpad

[Tim Penhey]

Change build records heading and add build images.

Very simple branch that adds an adapter for build status images, and changes the title of "Build records" to "Latest builds".

[Robert Collins (lifeless)]

review: Approve

=== modified file 'lib/lp/app/browser/configure.zcml'
--- lib/lp/app/browser/configure.zcml	2010-10-22 03:35:41 +0000
+++ lib/lp/app/browser/configure.zcml	2010-11-10 20:56:50 +0000
@@ -203,6 +203,12 @@
       factory="lp.app.browser.tales.BuildImageDisplayAPI"
       name="image"
       />
+  <adapter
+      for="lp.code.interfaces.sourcepackagerecipebuild.ISourcePackageRecipeBuild"
+      provides="zope.traversing.interfaces.IPathAdapter"
+      factory="lp.app.browser.tales.BuildImageDisplayAPI"
+      name="image"
+      />
 
   <adapter
       for="lp.soyuz.interfaces.archive.IArchive"

=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipe.py'
--- lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2010-11-05 18:30:21 +0000
+++ lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2010-11-10 20:56:50 +0000
@@ -664,7 +664,7 @@
             Daily build archive: Secret PPA
             Distribution series: Secret Squirrel
 
-            Build records
+            Latest builds
             Status Time Distribution series Archive
             Successful build on 2010-03-16 Secret Squirrel Secret PPA
             Request build\(s\)
@@ -677,7 +677,7 @@
         """A message should be shown when there are no builds."""
         recipe = self.makeRecipe()
         self.assertTextMatchesExpressionIgnoreWhitespace("""\
-            Build records
+            Latest builds
             Status Time Distribution series Archive
             This recipe has not been built yet.""", self.getMainText(recipe))
 
@@ -686,7 +686,7 @@
         removeSecurityProxy(self.factory.makeSourcePackageRecipeBuild(
             recipe=recipe, distroseries=self.squirrel, archive=self.ppa))
         self.assertTextMatchesExpressionIgnoreWhitespace("""
-            Build records
+            Latest builds
             Status Time Distribution series Archive
             No suitable builders Secret Squirrel Secret PPA
             Request build\(s\)""", self.getMainText(recipe))
@@ -704,7 +704,7 @@
         self.makeBuildJob(recipe)
         self.factory.makeBuilder()
         pattern = """\
-            Build records
+            Latest builds
             Status Time Distribution series Archive
             Pending build in .* \(estimated\) Secret Squirrel Secret PPA
             Request build\(s\)

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-08-05 18:20:28 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-11-10 20:56:50 +0000
@@ -81,7 +81,7 @@
   </div>
   <div class="yui-g">
     <div class="portlet">
-      <h2>Build records</h2>
+      <h2>Latest builds</h2>
         <table class="listing" style='margin-bottom: 1em;'>
           <thead>
             <tr>
@@ -93,13 +93,15 @@
           </thead>
           <tbody>
             <tr tal:repeat="build view/builds">
+              <tal:build-view define="buildview nocall:build/@@+index">
               <td>
-                <a tal:content="build/@@+index/status"
+                <span tal:replace="structure build/image:icon" />
+                <a tal:content="buildview/status"
                    tal:attributes="href build/fmt:url"></a>
               </td>
               <td>
-                <tal:date replace="build/@@+index/date/fmt:displaydate" />
-                <tal:estimate condition="build/@@+index/estimate">
+                <tal:date replace="buildview/date/fmt:displaydate" />
+                <tal:estimate condition="buildview/estimate">
                 (estimated)
                 </tal:estimate>
               </td>
@@ -110,6 +112,7 @@
               <td>
                 <tal:archive replace="structure build/archive/fmt:link"/>
               </td>
+              </tal:build-view>
             </tr>
           </tbody>
         </table>