Merge lp:~thumper/launchpad/lp-app-javascript into lp:launchpad

[Tim Penhey]

Move javascript files from canonical.launchpad.javascript.lp to lp.app.javascript

Move code from canonical.launchpad.javascript.lp into lp.app.javascript.

Also changed (most) of the files to follow the proper namespace rules and be in lp.app.*

[Paul Hummer (rockstar)]

Yay.

review: Approve (code)

=== modified file 'lib/canonical/launchpad/doc/lazr-js-widgets.txt'
--- lib/canonical/launchpad/doc/lazr-js-widgets.txt	2009-07-14 13:16:50 +0000
+++ lib/canonical/launchpad/doc/lazr-js-widgets.txt	2010-07-16 10:55:11 +0000
@@ -99,7 +99,7 @@
     ...         null_display_value='Nobody')
 
 An unauthenticated user cannot see the activator's edit button, which
-is revealed by Y.lp.picker.addPickerPatcher.
+is revealed by Y.lp.app.picker.addPickerPatcher.
 
     >>> login(ANONYMOUS)
     >>> widget = create_inline_edit_picker_widget()
@@ -120,7 +120,7 @@
     <span id="inline-picker-activator-id-...">
     ...<div class="yui-activator-message-box yui-activator-hidden" />
     </span>
-    ...Y.lp.picker.addPickerPatcher(...
+    ...Y.lp.app.picker.addPickerPatcher(...
 
 The resource_uri is the canonical_url for the object in
 WebServiceClientRequests.

=== modified file 'lib/canonical/launchpad/doc/location-widget.txt'
--- lib/canonical/launchpad/doc/location-widget.txt	2009-05-06 16:12:19 +0000
+++ lib/canonical/launchpad/doc/location-widget.txt	2010-07-16 10:55:11 +0000
@@ -177,9 +177,9 @@
     >>> print widget.map_javascript
     <BLANKLINE>
     <script type="text/javascript">
-        YUI().use('node', 'lp.mapping', function(Y) {
+        YUI().use('node', 'lp.app.mapping', function(Y) {
             function renderMap() {
-                Y.lp.mapping.renderPersonMap(
+                Y.lp.app.mapping.renderPersonMap(
                     52.2, 0.3, "Colin Watson",
                     'kamion', '<img ... />', 'totoro',
                     'field.location.latitude', 'field.location.longitude',

=== modified file 'lib/canonical/launchpad/templates/launchpad-widget-macros.pt'
--- lib/canonical/launchpad/templates/launchpad-widget-macros.pt	2009-07-17 17:59:07 +0000
+++ lib/canonical/launchpad/templates/launchpad-widget-macros.pt	2010-07-16 10:55:11 +0000
@@ -101,7 +101,7 @@
         <script type="text/javascript"
                 tal:attributes="src string:${yui2}/calendar/calendar.js"></script>
         <script type="text/javascript"
-                tal:attributes="src string:${lp_js}/lp/calendar.js"></script>
+                tal:attributes="src string:${lp_js}/app/calendar.js"></script>
         </tal:devmode>
         <tal:nondevmode condition="not: devmode">
         <script type="text/javascript"
@@ -116,8 +116,8 @@
     </tal:yui2resources>
 
     <script type="text/javascript">
-        YUI().use('node', 'lp.calendar', function(Y) {
-            Y.lp.setup_calendar_widgets();
+        YUI().use('node', 'lp.app.calendar', function(Y) {
+            Y.lp.app.calendar.setup_calendar_widgets();
         });
     </script>
 </metal:yui2calendar-dependencies>

=== modified file 'lib/canonical/widgets/location.py'
--- lib/canonical/widgets/location.py	2009-11-22 19:05:39 +0000
+++ lib/canonical/widgets/location.py	2010-07-16 10:55:11 +0000
@@ -126,9 +126,9 @@
             show_marker=self.show_marker)
         return """
             <script type="text/javascript">
-                YUI().use('node', 'lp.mapping', function(Y) {
+                YUI().use('node', 'lp.app.mapping', function(Y) {
                     function renderMap() {
-                        Y.lp.mapping.renderPersonMap(
+                        Y.lp.app.mapping.renderPersonMap(
                             %(center_lat)s, %(center_lng)s, %(displayname)s,
                             '%(name)s', '%(logo_html)s', '%(geoname)s',
                             '%(lat_name)s', '%(lng_name)s', '%(tz_name)s',

=== modified file 'lib/canonical/widgets/templates/inline-picker.pt'
--- lib/canonical/widgets/templates/inline-picker.pt	2009-07-17 17:59:07 +0000
+++ lib/canonical/widgets/templates/inline-picker.pt	2010-07-16 10:55:11 +0000
@@ -9,12 +9,12 @@
 </span>
 <script tal:condition="view/can_write"
         tal:content="structure string:
-YUI().use('lp.picker', function(Y) {
+YUI().use('lp.app.picker', function(Y) {
     if (Y.UA.ie) {
         return;
     }
 
-    Y.lp.picker.addPickerPatcher(
+    Y.lp.app.picker.addPickerPatcher(
         ${view/vocabulary_name},
         ${view/resource_uri},
         ${view/json_attribute},

=== modified file 'lib/canonical/widgets/templates/vocabulary-picker.js.template'
--- lib/canonical/widgets/templates/vocabulary-picker.js.template	2010-01-29 10:52:58 +0000
+++ lib/canonical/widgets/templates/vocabulary-picker.js.template	2010-07-16 10:55:11 +0000
@@ -1,4 +1,4 @@
-YUI().use('node', 'lp.picker', 'plugin', function(Y) {
+YUI().use('node', 'lp.app.picker', 'plugin', function(Y) {
     if (Y.UA.ie) {
         return;
     }
@@ -14,7 +14,7 @@
             step_title: args.step_title,
             extra_no_results_message: args.extra_no_results_message
         };
-        var picker = Y.lp.picker.create(args.vocabulary, config);
+        var picker = Y.lp.app.picker.create(args.vocabulary, config);
         if (config.extra_no_results_message !== null) {
             picker.before('resultsChange', function (e) {
                 var new_results = e.details[0].newVal;

=== renamed directory 'lib/canonical/launchpad/javascript/lp' => 'lib/lp/app/javascript'
=== modified file 'lib/lp/app/javascript/calendar.js'
--- lib/canonical/launchpad/javascript/lp/calendar.js	2009-11-24 09:30:01 +0000
+++ lib/lp/app/javascript/calendar.js	2010-07-16 10:55:11 +0000
@@ -5,13 +5,13 @@
  * If the input also has the class 'withtime', it will include time
  * fields and behave slightly differently.
 
- * @module Y.lp.calendar
+ * @module Y.lp.app.calendar
  * @requires node
  */
 
-YUI.add('lp.calendar', function(Y) {
+YUI.add('lp.app.calendar', function(Y) {
 
-var lp = Y.namespace('lp');
+var namespace = Y.namespace('lp.app.calendar');
 
 /**
  * Convert a number to a string padding single-digit numbers with a zero.
@@ -179,7 +179,7 @@
  *
  * @method setup_calendar_widgets.
  */
-lp.add_calendar_widgets = function() {
+namespace.add_calendar_widgets = function() {
     var date_inputs = Y.all('input.yui2-calendar');
 
     if (date_inputs === null) {
@@ -241,8 +241,8 @@
  *
  * @method setup_calendar_widgets.
  */
-lp.setup_calendar_widgets = function() {
-    Y.on("domready", lp.add_calendar_widgets);
+namespace.setup_calendar_widgets = function() {
+    Y.on("domready", namespace.add_calendar_widgets);
 };
 
 }, "0.1", {"requires": ["node"]});

=== modified file 'lib/lp/app/javascript/comment.js'
--- lib/canonical/launchpad/javascript/lp/comment.js	2010-02-16 16:29:36 +0000
+++ lib/lp/app/javascript/comment.js	2010-07-16 10:55:11 +0000
@@ -1,6 +1,6 @@
-YUI.add('lp.comment', function(Y) {
+YUI.add('lp.app.comment', function(Y) {
 
-Y.lp = Y.namespace('lp');
+var namespace = Y.namespace('lp.app.comment');
 
 var Comment = function () {
         Comment.superclass.constructor.apply(this, arguments);
@@ -25,7 +25,7 @@
         this.error_handler = new LP.client.ErrorHandler();
         this.error_handler.clearProgressUI = bind(this.clearProgressUI, this);
         this.error_handler.showError = bind(function (error_msg) {
-            Y.lp.display_error(this.submit_button, error_msg);
+            Y.lp.app.errors.display_error(this.submit_button, error_msg);
         }, this);
         this.progress_message = Y.Node.create(
             '<span class="update-in-progress-message">Saving...</span>');
@@ -199,7 +199,7 @@
     }
 });
 
-Y.lp.Comment = Comment;
+namespace.Comment = Comment;
 
 var CodeReviewComment = function(){
         CodeReviewComment.superclass.constructor.apply(this, arguments);
@@ -420,6 +420,6 @@
         });
     }
 });
-Y.lp.CodeReviewComment = CodeReviewComment;
+namespace.CodeReviewComment = CodeReviewComment;
 
-}, "0.1" ,{"requires":["oop", "io", "widget", "node", "lp.client.plugins", "lp.errors"]});
+}, "0.1" ,{"requires":["oop", "io", "widget", "node", "lp.client.plugins", "lp.app.errors"]});

=== modified file 'lib/lp/app/javascript/dragscroll.js'
--- lib/canonical/launchpad/javascript/lp/dragscroll.js	2010-02-12 16:29:55 +0000
+++ lib/lp/app/javascript/dragscroll.js	2010-07-16 10:55:11 +0000
@@ -3,7 +3,7 @@
  *
  * A milestone form overlay that can create a milestone within any page.
  *
- * @module Y.lp.dragscroll
+ * @module Y.lp.app.dragscroll
  *
  * Based on dragscroll script by Nicolas Mendoza <[e-mail]>.
  * http://people.opera.com/nicolasm/userjs/dragscroll
@@ -15,16 +15,16 @@
  * @class DragScrollEventHandler
  * @constructor
  */
-YUI.add('lp.dragscroll', function(Y) {
-    var module = Y.namespace('lp.dragscroll');
+YUI.add('lp.app.dragscroll', function(Y) {
+    var namespace = Y.namespace('lp.app.dragscroll');
 
-    module.DragScrollEventHandler = function() {
+    namespace.DragScrollEventHandler = function() {
         this.dragging = false;
         this.last_position = null;
         this.event_listeners = [];
     };
 
-    module.DragScrollEventHandler.prototype = {
+    namespace.DragScrollEventHandler.prototype = {
         /**
         * Add the event handlers and change the cursor to indicate
         * that drag scrolling is active.

=== modified file 'lib/lp/app/javascript/errors.js'
--- lib/canonical/launchpad/javascript/lp/errors.js	2009-12-22 20:30:39 +0000
+++ lib/lp/app/javascript/errors.js	2010-07-16 10:55:11 +0000
@@ -1,6 +1,6 @@
-YUI.add('lp.errors', function(Y) {
+YUI.add('lp.app.errors', function(Y) {
 
-Y.lp = Y.namespace('lp');
+var namespace = Y.namespace('lp.app.errors');
 
 /*
  * Create a form button for canceling an error form
@@ -69,7 +69,7 @@
  * @param flash_node {Node} The node to red flash.
  * @param msg {String} The message to display.
 */
-Y.lp.display_error = function(flash_node, msg) {
+namespace.display_error = function(flash_node, msg) {
     create_error_overlay();
     maybe_red_flash(flash_node, function(){
         error_overlay.showError(msg);
@@ -85,7 +85,7 @@
  * @method display_info
  * @param msg {String} The message to display.
 */
-Y.lp.display_info = function(msg) {
+namespace.display_info = function(msg) {
     if (info_overlay === undefined) {
         info_overlay = new Y.lazr.PrettyOverlay({
             centered: true,

=== modified file 'lib/lp/app/javascript/mapping.js'
--- lib/canonical/launchpad/javascript/lp/mapping.js	2010-02-09 05:13:05 +0000
+++ lib/lp/app/javascript/mapping.js	2010-07-16 10:55:11 +0000
@@ -3,12 +3,12 @@
  *
  * Map rendering and marker creation depends on the Google GMap2 library.
  *
- * @module lp.mapping
- * @namespace lp.mapping
+ * @module lp.app.mapping
+ * @namespace lp.app.mapping
  * @required Google GMap2
  */
-YUI.add('lp.mapping', function(Y) {
-    var module = Y.namespace('lp.mapping');
+YUI.add('lp.app.mapping', function(Y) {
+    var module = Y.namespace('lp.app.mapping');
 
     module.RETURN_FALSE = function() {return false;};
     module.RETURN_NULL = function() {return null;};

=== modified file 'lib/lp/app/javascript/picker.js'
--- lib/canonical/launchpad/javascript/lp/picker.js	2010-02-09 05:13:05 +0000
+++ lib/lp/app/javascript/picker.js	2010-07-16 10:55:11 +0000
@@ -1,8 +1,6 @@
-YUI.add('lp.picker', function(Y) {
-
-Y.log('loading lp.picker');
-
-var module = Y.namespace('lp.picker');
+YUI.add('lp.app.picker', function(Y) {
+
+var namespace = Y.namespace('lp.app.picker');
 
 var BATCH_SIZE = 6;
 var MAX_BATCHES = 20;
@@ -24,7 +22,7 @@
  *                        config.step_title overrides the subtitle.
  *                        description strings.
  */
-module.addPickerPatcher = function (
+namespace.addPickerPatcher = function (
     vocabulary, resource_uri, attribute_name,
     content_box_id, show_remove_button, show_assign_me_button, config) {
 
@@ -151,7 +149,7 @@
     };
 
     config.save = save;
-    var picker = module.create(vocabulary, config);
+    var picker = namespace.create(vocabulary, config);
     picker._resource_uri = resource_uri;
     var extra_buttons = Y.Node.create(
         '<div style="text-align: center; height: 3em; ' +
@@ -200,7 +198,7 @@
   *                        config.save is a Function (optional) which takes
   *                        a single string argument.
   */
-module.create = function (vocabulary, config) {
+namespace.create = function (vocabulary, config) {
     if (Y.UA.ie) {
         return;
     }

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2010-06-29 15:42:35 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2010-07-16 10:55:11 +0000
@@ -171,15 +171,15 @@
             tal:attributes="src string:${lazr_js}/effects/effects.js"></script>
 
     <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/lp.js"></script>
-    <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/lp-mochi.js"></script>
-    <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/dragscroll.js"></script>
-    <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/picker.js"></script>
-    <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/mapping.js"></script>
+            tal:attributes="src string:${lp_js}/app/lp.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${lp_js}/app/lp-mochi.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${lp_js}/app/dragscroll.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${lp_js}/app/picker.js"></script>
+    <script type="text/javascript"
+            tal:attributes="src string:${lp_js}/app/mapping.js"></script>
     <script type="text/javascript"
             tal:attributes="src string:${lp_js}/bugs/bugtracker_overlay.js"></script>
     <script type="text/javascript"
@@ -217,9 +217,9 @@
             tal:attributes="src string:${lp_js}/code/productseries-setbranch.js">
     </script>
     <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/comment.js"></script>
+            tal:attributes="src string:${lp_js}/app/comment.js"></script>
     <script type="text/javascript"
-            tal:attributes="src string:${lp_js}/lp/errors.js"></script>
+            tal:attributes="src string:${lp_js}/app/errors.js"></script>
     <script type="text/javascript"
             tal:attributes="src string:${lp_js}/registry/team.js"></script>
 

=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js	2010-07-11 00:32:53 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js	2010-07-16 10:55:11 +0000
@@ -110,7 +110,7 @@
         }
     };
     error_handler.showError = function(error_msg) {
-        Y.lp.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     var config = {
@@ -255,7 +255,7 @@
     config.save = function(result) {
         subscribe_someone_else(result, subscription);
     };
-    var picker = Y.lp.picker.create('ValidPersonOrTeam', config);
+    var picker = Y.lp.app.picker.create('ValidPersonOrTeam', config);
 }
 
 /*
@@ -581,7 +581,7 @@
         link_branch_link.toggleClass('update-in-progress-message');
     };
     error_handler.showError = function(error_msg) {
-        display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     function get_branch_and_link_to_bug(data) {
@@ -608,7 +608,7 @@
         };
 
         config.save = get_branch_and_link_to_bug;
-        var picker = Y.lp.picker.create('Branch', config);
+        var picker = Y.lp.app.picker.create('Branch', config);
     }
 }
 
@@ -623,7 +623,7 @@
         link_branch_link.toggleClass('update-in-progress-message');
     };
     error_handler.showError = function(error_msg) {
-        display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     // Call linkBranch() on the bug.
@@ -1086,7 +1086,7 @@
     };
     error_handler.showError = function (error_msg) {
         var flash_node = Y.one('.' + person.get('css_name'));
-        Y.lp.display_error(flash_node, error_msg);
+        Y.lp.app.errors.display_error(flash_node, error_msg);
 
     };
 
@@ -1161,7 +1161,7 @@
         subscription.disable_spinner();
     };
     error_handler.showError = function (error_msg) {
-        Y.lp.display_error(subscription_link, error_msg);
+        Y.lp.app.errors.display_error(subscription_link, error_msg);
     };
 
     var config = {
@@ -1218,7 +1218,7 @@
         subscription.disable_spinner();
     };
     error_handler.showError = function (error_msg) {
-        Y.lp.display_error(subscription_link, error_msg);
+        Y.lp.app.errors.display_error(subscription_link, error_msg);
     };
 
     var config = {
@@ -1313,7 +1313,7 @@
                             '   class="sprite edit yui-activator-act" />'),
                         bugtarget_content.one('.yui-activator-act'));
                 } else {
-                    var bugtarget_picker = Y.lp.picker.addPickerPatcher(
+                    var bugtarget_picker = Y.lp.app.picker.addPickerPatcher(
                         'Product',
                         conf.bugtask_path,
                         "target_link",
@@ -1336,7 +1336,7 @@
                 backgroundColor: tr.hasClass('highlight') ? '#FFFF99' : '#FFFFFF'
             });
             status_choice_edit.showError = function(err) {
-              Y.lp.display_error(null, err);
+              Y.lp.app.errors.display_error(null, err);
             };
             status_choice_edit.on('save', function(e) {
                 var cb = status_choice_edit.get('contentBox');
@@ -1368,7 +1368,7 @@
                 backgroundColor: tr.hasClass('highlight') ? '#FFFF99' : '#FFFFFF'
             });
             importance_choice_edit.showError = function(err) {
-              Y.lp.display_error(null, err);
+              Y.lp.app.errors.display_error(null, err);
             };
             importance_choice_edit.on('save', function(e) {
                 var cb = importance_choice_edit.get('contentBox');
@@ -1403,7 +1403,7 @@
             clickable_content: false
         });
         milestone_choice_edit.showError = function(err) {
-            Y.lp.display_error(null, err);
+            Y.lp.app.errors.display_error(null, err);
         };
         milestone_choice_edit.plug({
             fn: Y.lp.client.plugins.PATCHPlugin, cfg: {
@@ -1450,7 +1450,7 @@
             (conf.assignee_vocabulary == 'ValidAssignee') ?
             "Search for people or teams" :
             "Select a team of which you are a member";
-        var assignee_picker = Y.lp.picker.addPickerPatcher(
+        var assignee_picker = Y.lp.app.picker.addPickerPatcher(
             conf.assignee_vocabulary,
             conf.bugtask_path,
             "assignee_link",
@@ -1611,7 +1611,7 @@
     },
 
     showError: function(err) {
-        Y.lp.display_error(null, err);
+        Y.lp.app.errors.display_error(null, err);
     },
 
     render: function() {
@@ -1664,7 +1664,7 @@
 function check_can_be_unsubscribed(subscription) {
     var error_handler = new LP.client.ErrorHandler();
     error_handler.showError = function (error_msg) {
-        Y.lp.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     var config = {
@@ -1733,7 +1733,7 @@
 
     var error_handler = new LP.client.ErrorHandler();
     error_handler.showError = function(error_msg) {
-        Y.lp.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
     };
 
     if (subscription.is_already_subscribed()) {
@@ -1873,5 +1873,5 @@
 }, "0.1", {"requires": ["base", "oop", "node", "event", "io-base", "json-parse",
                       "substitute", "widget-position-ext", "lazr.formoverlay",
                       "lazr.anim", "lazr.base", "lazr.overlay",
-                      "lazr.choiceedit", "lp.picker", "lp.client.plugins",
-                      "lp.bugs.subscriber", "lp.errors"]});
+                      "lazr.choiceedit", "lp.app.picker", "lp.client.plugins",
+                      "lp.bugs.subscriber", "lp.app.errors"]});

=== modified file 'lib/lp/bugs/javascript/bugtracker_overlay.js'
--- lib/lp/bugs/javascript/bugtracker_overlay.js	2010-06-21 04:08:54 +0000
+++ lib/lp/bugs/javascript/bugtracker_overlay.js	2010-07-16 10:55:11 +0000
@@ -127,5 +127,5 @@
     };
 
 }, "0.1", {"requires": [
-    "dom", "node", "io-base", "lazr.anim", "lazr.formoverlay", "lp.calendar"
+    "dom", "node", "io-base", "lazr.anim", "lazr.formoverlay", "lp.app.calendar"
     ]});

=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt	2010-07-13 14:08:24 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt	2010-07-16 10:55:11 +0000
@@ -287,8 +287,8 @@
                 button.style.display = 'none';
               </script>
               <script type="text/javascript">
-                LPS.use('lp.comment', function(Y) {
-                    var comment = new Y.lp.Comment();
+                LPS.use('lp.app.comment', function(Y) {
+                    var comment = new Y.lp.app.comment.Comment();
                     comment.render();
                 });
               </script>

=== modified file 'lib/lp/code/javascript/branch.status.js'
--- lib/lp/code/javascript/branch.status.js	2010-03-01 19:22:51 +0000
+++ lib/lp/code/javascript/branch.status.js	2010-07-16 10:55:11 +0000
@@ -25,7 +25,7 @@
             title: 'Change status to',
             items: conf.status_widget_items});
         status_choice_edit.showError = function(err) {
-            display_error(null, err);
+            Y.lp.app.errors.display_error(null, err);
         };
         status_choice_edit.on('save', function(e) {
             var cb = status_choice_edit.get('contentBox');

=== modified file 'lib/lp/code/javascript/branchmergeproposal.reviewcomment.js'
--- lib/lp/code/javascript/branchmergeproposal.reviewcomment.js	2010-03-11 17:07:57 +0000
+++ lib/lp/code/javascript/branchmergeproposal.reviewcomment.js	2010-07-16 10:55:11 +0000
@@ -160,7 +160,7 @@
         var review_type = Y.one("[id=field.review_type]").get('value');
         request_reviewer(result, review_type);
     };
-    reviewer_picker = Y.lp.picker.create('ValidPersonOrTeam', config);
+    reviewer_picker = Y.lp.app.picker.create('ValidPersonOrTeam', config);
     reviewer_picker.set('footer_slot', Y.Node.create([
         '<div>',
         '<div style="float: left; padding-right: 9px;">',
@@ -280,4 +280,5 @@
 
 namespace.NumberToggle = NumberToggle;
 
-}, "0.1", {"requires": ["base", "widget", "lazr.anim", "lazr.formoverlay", "lp.picker"]});
+}, "0.1", {"requires": ["base", "widget", "lazr.anim",
+                        "lazr.formoverlay", "lp.app.picker"]});

=== modified file 'lib/lp/code/javascript/branchmergeproposal.status.js'
--- lib/lp/code/javascript/branchmergeproposal.status.js	2010-03-11 17:07:57 +0000
+++ lib/lp/code/javascript/branchmergeproposal.status.js	2010-07-16 10:55:11 +0000
@@ -24,7 +24,7 @@
             title: 'Change status to',
             items: conf.status_widget_items});
         status_choice_edit.showError = function(err) {
-            display_error(null, err);
+            Y.lp.app.errors.display_error(null, err);
         };
         status_choice_edit.on('save', function(e) {
             config = {

=== modified file 'lib/lp/code/templates/branchmergeproposal-index.pt'
--- lib/lp/code/templates/branchmergeproposal-index.pt	2010-03-11 17:07:57 +0000
+++ lib/lp/code/templates/branchmergeproposal-index.pt	2010-07-16 10:55:11 +0000
@@ -229,13 +229,13 @@
   conf = <tal:status-config replace="view/status_config" />
   <!--
   LPS.use('io-base', 'lp.code.branchmergeproposal.reviewcomment',
-          'lp.code.branchmergeproposal.status', 'lp.comment', function(Y) {
+          'lp.code.branchmergeproposal.status', 'lp.app.comment', function(Y) {
 
     Y.on('load', function() {
         var logged_in = LP.client.links['me'] !== undefined;
 
         if (logged_in) {
-            var comment = new Y.lp.CodeReviewComment();
+            var comment = new Y.lp.app.comment.CodeReviewComment();
             comment.render();
 
             if(Y.UA.ie) {

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2010-07-14 21:49:53 +0000
+++ lib/lp/registry/browser/person.py	2010-07-16 10:55:11 +0000
@@ -3268,9 +3268,9 @@
                         'center_lng': self.context.longitude}
         return u"""
             <script type="text/javascript">
-                YUI().use('node', 'lp.mapping', function(Y) {
+                YUI().use('node', 'lp.app.mapping', function(Y) {
                     function renderMap() {
-                        Y.lp.mapping.renderPersonMapSmall(
+                        Y.lp.app.mapping.renderPersonMapSmall(
                             %(center_lat)s, %(center_lng)s);
                      }
                      Y.on("domready", renderMap);

=== modified file 'lib/lp/registry/browser/team.py'
--- lib/lp/registry/browser/team.py	2010-05-21 17:04:28 +0000
+++ lib/lp/registry/browser/team.py	2010-07-16 10:55:11 +0000
@@ -1070,9 +1070,9 @@
         """HTML which shows the map with location of the team's members."""
         return """
             <script type="text/javascript">
-                YUI().use('node', 'lp.mapping', function(Y) {
+                YUI().use('node', 'lp.app.mapping', function(Y) {
                     function renderMap() {
-                        Y.lp.mapping.renderTeamMap(
+                        Y.lp.app.mapping.renderTeamMap(
                             %(min_lat)s, %(max_lat)s, %(min_lng)s,
                             %(max_lng)s, %(center_lat)s, %(center_lng)s);
                      }
@@ -1085,9 +1085,9 @@
         """The HTML which shows a small version of the team's map."""
         return """
             <script type="text/javascript">
-                YUI().use('node', 'lp.mapping', function(Y) {
+                YUI().use('node', 'lp.app.mapping', function(Y) {
                     function renderMap() {
-                        Y.lp.mapping.renderTeamMapSmall(
+                        Y.lp.app.mapping.renderTeamMapSmall(
                             %(center_lat)s, %(center_lng)s);
                      }
                      Y.on("domready", renderMap);

=== modified file 'lib/lp/registry/browser/tests/person-views.txt'
--- lib/lp/registry/browser/tests/person-views.txt	2010-07-14 16:27:33 +0000
+++ lib/lp/registry/browser/tests/person-views.txt	2010-07-16 10:55:11 +0000
@@ -356,7 +356,7 @@
 
     >>> print person_view.map_portlet_html
     <script type="text/javascript">
-      YUI().use('node', 'lp.mapping', function(Y) { ...
+      YUI().use('node', 'lp.app.mapping', function(Y) { ...
 
 The small_maps key in the launchpad_views cookie can be set of the
 viewing user to 'false' to indicate that small maps are not wanted.
@@ -371,7 +371,7 @@
 
     >>> print person_view.map_portlet_html
     <script type="text/javascript">
-      YUI().use('node', 'lp.mapping', function(Y) { ...
+      YUI().use('node', 'lp.app.mapping', function(Y) { ...
 
 The map portlet is shown if the user has not set his location and is
 viewing his own page.

=== modified file 'lib/lp/registry/javascript/milestoneoverlay.js'
--- lib/lp/registry/javascript/milestoneoverlay.js	2010-06-16 04:57:44 +0000
+++ lib/lp/registry/javascript/milestoneoverlay.js	2010-07-16 10:55:11 +0000
@@ -67,7 +67,7 @@
         });
         milestone_form.render();
         milestone_form.loadFormContentAndRender(milestone_form_uri);
-        Y.lp.add_calendar_widgets();
+        Y.lp.app.calendar.add_calendar_widgets();
         milestone_form.show();
     };
 
@@ -118,5 +118,5 @@
     };
 
 }, "0.1", {"requires": [
-    "dom", "node", "io-base", "lazr.anim", "lazr.formoverlay", "lp.calendar"
+    "dom", "node", "io-base", "lazr.anim", "lazr.formoverlay", "lp.app.calendar"
     ]});

=== modified file 'lib/lp/registry/javascript/team.js'
--- lib/lp/registry/javascript/team.js	2010-04-29 15:21:05 +0000
+++ lib/lp/registry/javascript/team.js	2010-07-16 10:55:11 +0000
@@ -26,7 +26,7 @@
     };
 
     config.save = _add_member;
-    Y.lp.picker.create('ValidTeamMember', config);
+    Y.lp.app.picker.create('ValidTeamMember', config);
 };
 
 var _add_member = function(selected_person) {
@@ -44,7 +44,7 @@
     var error_handler = new LP.client.ErrorHandler();
     error_handler.clearProgressUI = disable_spinner;
     error_handler.showError = function(error_msg) {
-        Y.lp.display_error(addmember_link, error_msg);
+        Y.lp.app.errors.display_error(addmember_link, error_msg);
     };
 
     addmember_config = {
@@ -55,7 +55,7 @@
                 var members_section, members_ul, count_elem;
                 if (did_status_change === false) {
                     disable_spinner();
-                    Y.lp.display_info(
+                    Y.lp.app.errors.display_info(
                         selected_person.title + ' is already ' +
                         current_status.toLowerCase() +
                         ' as a member of the team.');
@@ -75,7 +75,7 @@
                     members_ul = box.query('#recently-approved-ul');
                     count_elem = box.query('#approved-member-count');
                 } else {
-                    Y.lp.display_error(
+                    Y.lp.app.errors.display_error(
                         addmember_link,
                         'Unexpected status: ' + current_status);
                     return;
@@ -134,4 +134,4 @@
 };
 
 }, '0.1', {requires: [
-    'node', 'lazr.anim', 'lp.picker', 'lp.errors', 'lp.client.plugins']});
+    'node', 'lazr.anim', 'lp.app.picker', 'lp.app.errors', 'lp.client.plugins']});

=== modified file 'lib/lp/registry/stories/location/personlocation.txt'
--- lib/lp/registry/stories/location/personlocation.txt	2009-11-16 21:56:23 +0000
+++ lib/lp/registry/stories/location/personlocation.txt	2010-07-16 10:55:11 +0000
@@ -30,8 +30,8 @@
     >>> print extract_text(find_tag_by_id(markup, 'portlet-map'), skip_tags=[])
     Location
     Time zone: Europe/London...
-    Y.lp.mapping.renderPersonMapSmall(...
+    Y.lp.app.mapping.renderPersonMapSmall(...
     >>> 'src="http://maps.google.com/maps' in markup
     True
-    >>> 'build/lp/mapping.js' in markup
+    >>> 'build/app/mapping.js' in markup
     True

=== modified file 'lib/lp/registry/stories/location/team-map.txt'
--- lib/lp/registry/stories/location/team-map.txt	2010-06-24 20:22:57 +0000
+++ lib/lp/registry/stories/location/team-map.txt	2010-07-16 10:55:11 +0000
@@ -7,12 +7,12 @@
     >>> nopriv_browser.open('http://launchpad.dev/~guadamen')
     >>> body = find_main_content(nopriv_browser.contents)
     >>> mapdiv = find_tag_by_id(str(body), 'team_map_div')
-    >>> 'lp.mapping.renderTeamMapSmall(' in str(body)
+    >>> 'lp.app.mapping.renderTeamMapSmall(' in str(body)
     True
     >>> markup = str(nopriv_browser.contents)
     >>> 'src="http://maps.google.com/maps' in markup
     True
-    >>> 'build/lp/mapping.js' in markup
+    >>> 'build/app/mapping.js' in markup
     True
 
 You should also be able to see a map of the team.

=== modified file 'lib/lp/registry/templates/object-timeline-graph.pt'
--- lib/lp/registry/templates/object-timeline-graph.pt	2010-04-29 15:21:05 +0000
+++ lib/lp/registry/templates/object-timeline-graph.pt	2010-07-16 10:55:11 +0000
@@ -34,7 +34,7 @@
           include_inactive = false;
       }
 
-      LPS.use('lp.registry.timeline', 'node', 'lp.dragscroll', function(Y) {
+      LPS.use('lp.registry.timeline', 'node', 'lp.app.dragscroll', function(Y) {
           Y.on('domready', function(e) {
               if (Y.UA.ie) {
                   return;
@@ -89,7 +89,7 @@
                   });
 
               var drag_scroll_handler =
-                  new Y.lp.dragscroll.DragScrollEventHandler();
+                  new Y.lp.app.dragscroll.DragScrollEventHandler();
               drag_scroll_handler.activate();
           });
       });

=== modified file 'lib/lp/registry/templates/teammembership-index.pt'
--- lib/lp/registry/templates/teammembership-index.pt	2010-01-15 13:36:09 +0000
+++ lib/lp/registry/templates/teammembership-index.pt	2010-07-16 10:55:11 +0000
@@ -20,7 +20,7 @@
       use-macro="context/@@launchpad_widget_macros/yui2calendar-dependencies" />
 
     <script type="text/javascript">
-      LPS.use('node', 'lp.calendar', function(Y) {
+      LPS.use('node', 'lp.app.calendar', function(Y) {
           // Ensure that when the picker is used the radio button switches
           // from 'Never' to 'On' and the expiry field is enabled.
           Y.on("available", function(e) {

=== modified file 'lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt'
--- lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt	2010-03-08 18:01:33 +0000
+++ lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt	2010-07-16 10:55:11 +0000
@@ -54,7 +54,7 @@
     >>> print extract_all_script_and_style_links(cprov_browser.contents)
     /...
     ...
-    http://launchpad.dev/+icing/.../build/lp/calendar.js
+    http://launchpad.dev/+icing/.../build/app/calendar.js
     http://launchpad.dev/+icing/.../yui_2.7.0b/build/calendar/assets/skins/sam/calendar.css
     ...
 

=== modified file 'lib/lp/translations/javascript/importqueue.js'
--- lib/lp/translations/javascript/importqueue.js	2010-05-18 18:04:00 +0000
+++ lib/lp/translations/javascript/importqueue.js	2010-07-16 10:55:11 +0000
@@ -122,7 +122,7 @@
     conf.contentBox = content_box;
     var status_choice = new Y.ChoiceSource(conf);
     status_choice.showError = function(err) {
-        display_error(null, err);
+        Y.lp.app.errors.display_error(null, err);
     };
     var entry_id = content_box.ancestor(function(node){
         return node.hasClass('import_entry_row');
@@ -187,4 +187,4 @@
     // "oop" and "event" are required to fix known bugs in YUI, which
     // are apparently fixed in a later version.
     "requires": ["oop", "event", "node", "widget", "plugin", "overlay",
-               "lazr.choiceedit", "lp.client.plugins", "lp.errors"]});
+               "lazr.choiceedit", "lp.client.plugins", "lp.app.errors"]});

=== modified file 'utilities/lp-deps.py'
--- utilities/lp-deps.py	2010-07-13 14:14:37 +0000
+++ utilities/lp-deps.py	2010-07-16 10:55:11 +0000
@@ -20,6 +20,7 @@
 # JS_DIRSET is a tuple of the dir where the code exists, and the name of the
 # symlink it should be linked as in the icing build directory.
 JS_DIRSET = [
+    (os.path.join('lib', 'lp', 'app', 'javascript'), 'app'),
     (os.path.join('lib', 'lp', 'bugs', 'javascript'), 'bugs'),
     (os.path.join('lib', 'lp', 'code', 'javascript'), 'code'),
     (os.path.join('lib', 'lp', 'registry', 'javascript'), 'registry'),