Merge lp:~thumper/launchpad/kill-bad-form-preloads into lp:launchpad

[Tim Penhey]

Only load the link bug and subscription ++form++ when the user is logged in.

Several simple changes to stop lots of 404s.

Only do the javascript binding and loading of the forms if the user is logged in.

Windmill tests should be sufficient.

[Robert Collins (lifeless)]

I think this is an improvement for now, but wouldn't it be nice to
have a login triggered if someone tries something, rather than having
the form appear less complete? (Perhaps I misunderstand what happens).

[Tim Penhey (thumper)]

We can't easily trigger the login from the ajax calls. By not hooking up the link bug, we are leaving the link there, but not connected to ajax. That way they do get sent to the login page, even though they then go to an icky non-js version for linking a bug.

The edit button just shouldn't be there if they are not able to edit.

[Jeroen T. Vermeulen (jtv)]

We discussed on IRC. It's annoying that this isn't tested, but a windmill test would be overkill. Alternatives won't help enough to carry their weight.

Rockstar came up with a good suggestion for the longer term: the login check should happen inside the widget.

review: Approve (js)

=== modified file 'lib/lp/code/templates/branch-index.pt'
--- lib/lp/code/templates/branch-index.pt	2010-05-28 16:14:15 +0000
+++ lib/lp/code/templates/branch-index.pt	2010-10-19 03:11:44 +0000
@@ -36,15 +36,18 @@
               'lp.code.branch.subscription', function(Y) {
 
         Y.on('load', function(e) {
-            var subscription_portlet = new Y.lp.code.branch.subscription.SubscriptionWidget({
-                contentBox: '#portlet-subscribers'
-            });
-            subscription_portlet.render();
-
-            Y.lp.code.branch.status.connect_status(${view/status_config});
+            var logged_in = LP.client.links['me'] !== undefined;
+
+            if (logged_in) {
+                var subscription_portlet = new Y.lp.code.branch.subscription.SubscriptionWidget({
+                    contentBox: '#portlet-subscribers'
+                });
+                subscription_portlet.render();
+
+                Y.lp.code.branch.status.connect_status(${view/status_config});
+            }
             Y.lp.code.branchmergeproposal.diff.connect_diff_links();
-            },
-            window);
+        }, window);
     });
   "/>
 </metal:block>

=== modified file 'lib/lp/code/templates/branch-information.pt'
--- lib/lp/code/templates/branch-information.pt	2009-09-28 21:46:01 +0000
+++ lib/lp/code/templates/branch-information.pt	2010-10-19 03:11:44 +0000
@@ -26,7 +26,7 @@
         <span id="branch-details-status-value">
         <span tal:attributes="class string:value branchstatus${context/lifecycle_status/name}"
               tal:content="structure context/lifecycle_status/title" />&nbsp;
-        <a href="+edit-status">
+        <a href="+edit-status" tal:condition="context/required:launchpad.Edit">
           <img class="editicon" src="/@@/edit"/>
         </a>
         </span>

=== modified file 'lib/lp/code/templates/branch-related-bugs-specs.pt'
--- lib/lp/code/templates/branch-related-bugs-specs.pt	2010-06-10 07:54:59 +0000
+++ lib/lp/code/templates/branch-related-bugs-specs.pt	2010-10-19 03:11:44 +0000
@@ -81,7 +81,11 @@
     }
 
     Y.on('domready', function() {
-        Y.lp.code.branch.bugspeclinks.connect_branchlinks();
+        var logged_in = LP.client.links['me'] !== undefined;
+
+        if (logged_in) {
+            Y.lp.code.branch.bugspeclinks.connect_branchlinks();
+        }
     });
 
     });