Merge lp:~thumper/launchpad/js-play into lp:launchpad

[Tim Penhey]

provide smooth scrolling down to the diff

[Tim Penhey (thumper)]

I think this is all untestable javascript.

[Paul Hummer (rockstar)]

Thanks for moving the brace to be the right way.

review: Approve (code ui*)

[Paul Hummer (rockstar)]

Please change:

    if (!link) return;

...to...

    if (Y.lang.isValue(link)) return;

[Michael Nelson (michael.nelson)]

Thanks for the demo Tim! It's great seeing this page just getting better and better.

review: Approve (ui)

=== modified file 'lib/canonical/launchpad/javascript/code/codereview.js'
--- lib/canonical/launchpad/javascript/code/codereview.js	2009-12-17 04:17:12 +0000
+++ lib/canonical/launchpad/javascript/code/codereview.js	2010-01-18 09:02:22 +0000
@@ -14,13 +14,19 @@
 var reviewer_picker; // The "Request a review" overlay
 var lp_client;
 
+var window_scroll_anim = new Y.Anim({
+        node: 'window',
+        duration: 1,
+        easing: Y.Easing.easeOut
+    });
+
 /*
  * Connect all the links to their given actions.
  */
 Y.codereview.connect_links = function() {
 
     var link = Y.one('#request-review');
-    if (link !== null) {
+    if (Y.Lang.isValue(link)) {
         link.addClass('js-action');
         /* XXX: salgado 2009-11-11 bug=497603
          * This will cause the picker to be recreated every time the
@@ -34,19 +40,48 @@
         link.on('click', show_request_review_form);
     }
     link = Y.one('.menu-link-set_commit_message');
-    if (link !== null) {
+        if (Y.Lang.isValue(link)) {
         link.addClass('js-action');
         link.on('click', edit_commit_message);
     }
-    var widget = Y.lp.widgets['edit-commit-message'];
-    widget.editor.on('save', function() {
-            commit_message_listener(this.get('value'), true);
-        });
-    widget.editor.on('cancel', function() {
-            commit_message_listener(this.get('value'), false);
+    if (Y.Lang.isValue(Y.lp.widgets)) {
+        var widget = Y.lp.widgets['edit-commit-message'];
+        if (Y.Lang.isValue(widget)) {
+            widget.editor.on('save', function() {
+                    commit_message_listener(this.get('value'), true);
+                });
+            widget.editor.on('cancel', function() {
+                    commit_message_listener(this.get('value'), false);
+                });
+        }
+    }
+    link_scroller('#proposal-summary a.diff-link', '#review-diff');
+    link_scroller('.menu-link-add_comment', '#add-comment', function() {
+            Y.one('#add-comment-form textarea').focus();
         });
 };
 
+
+function link_scroller(link_selector, node_selector, on_end) {
+    var link = Y.one(link_selector);
+    if (!Y.Lang.isValue(link)) return;
+
+    link.addClass('js-action');
+    link.on('click', function(e) {
+        e.halt();
+        // Stop any running scrolling.
+        window_scroll_anim.stop();
+        // Detach any on end handlers.
+        window_scroll_anim.detach('anim:end');
+        var node = Y.one(node_selector);
+        window_scroll_anim.set('to', {scroll: [0, node.getY() - 5] });
+        if (on_end) {
+            window_scroll_anim.on('end', on_end);
+        }
+        window_scroll_anim.run();
+    });
+}
+
 /*
  * Hide the commit message editor if the value is empty.
  *

=== modified file 'lib/lp/code/templates/branchmergeproposal-index.pt'
--- lib/lp/code/templates/branchmergeproposal-index.pt	2010-01-13 21:49:43 +0000
+++ lib/lp/code/templates/branchmergeproposal-index.pt	2010-01-18 09:02:22 +0000
@@ -213,9 +213,9 @@
                 return;
             }
 
-            Y.code.codereview.connect_links();
             Y.code.branchmergeproposal.connect_status(conf);
         }
+        Y.code.codereview.connect_links();
         (new Y.codereview.NumberToggle()).render();
       }, window);
   });