Merge lp:~thumper/launchpad/fix-upgrade-branch-failure into lp:launchpad
Proposed by
Tim Penhey
Status: | Merged |
---|---|
Approved by: | Robert Collins |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11251 |
Proposed branch: | lp:~thumper/launchpad/fix-upgrade-branch-failure |
Merge into: | lp:launchpad |
Diff against target: |
58 lines (+14/-2) 2 files modified
database/schema/security.cfg (+2/-2) lib/lp/code/model/tests/test_branchjob.py (+12/-0) |
To merge this branch: | bzr merge lp:~thumper/launchpad/fix-upgrade-branch-failure |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+31114@code.launchpad.net |
Commit message
Add insert permissions for the job and branch job table so upgrade jobs can create scan jobs if needed.
Description of the change
Recently the upgrade job code was updated to use the branchChanged method call rather than requestMirror.
This works in all cases, except where someone pushes a new revision to the branch while the upgrade is happening. If this happens, a scan job will be created as part of the branchChanged call. This then results in a new job and branchjob row, so we need to add insert permissions for those two tables.
To post a comment you must log in.
it looks ok except on line 45 you have 2 lines of VWS, in a class only one line between methods please