Merge lp:~thumper/launchpad/fix-unicode-path-oops into lp:launchpad
Proposed by
Tim Penhey
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12791 | ||||
Proposed branch: | lp:~thumper/launchpad/fix-unicode-path-oops | ||||
Merge into: | lp:launchpad | ||||
Prerequisite: | lp:~thumper/launchpad/fix-dud-referer | ||||
Diff against target: |
179 lines (+48/-28) 8 files modified
lib/canonical/launchpad/doc/renamed-view.txt (+1/-1) lib/canonical/launchpad/helpers.py (+0/-20) lib/canonical/launchpad/rest/configuration.py (+4/-0) lib/canonical/launchpad/webapp/publisher.py (+6/-1) lib/canonical/launchpad/webapp/tests/test_publication.py (+13/-3) lib/lp/services/encoding.py (+21/-0) lib/lp/services/mail/sendmail.py (+2/-2) lib/lp/services/mail/tests/test_sendmail.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~thumper/launchpad/fix-unicode-path-oops | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+56688@code.launchpad.net |
Commit message
[r=lifeless][bug=200572]
Description of the change
This branch catches a couple of unicode issues.
One is where we were trying to look for something in storm with a potentially bad byte ordering, and the second was when we got a NotFoundError, the rendering of the page checked for a webservice request, which tryied to UTF-8 decode the string, which again failed.
To post a comment you must log in.
We shouldn't really be raising a NotFound there *either*, but this is an improvement.