Merge lp:~thumper/launchpad/fix-recipe-build-title into lp:launchpad
Proposed by
Tim Penhey
Status: | Merged |
---|---|
Approved by: | Tim Penhey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12205 |
Proposed branch: | lp:~thumper/launchpad/fix-recipe-build-title |
Merge into: | lp:launchpad |
Prerequisite: | lp:~thumper/launchpad/fix-recipe-build-oops |
Diff against target: |
107 lines (+23/-23) 5 files modified
lib/lp/app/browser/configure.zcml (+0/-6) lib/lp/app/browser/tales.py (+0/-16) lib/lp/code/browser/configure.zcml (+6/-0) lib/lp/code/browser/sourcepackagerecipebuild.py (+12/-0) lib/lp/code/model/sourcepackagerecipebuild.py (+5/-1) |
To merge this branch: | bzr merge lp:~thumper/launchpad/fix-recipe-build-title |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Hudson-Doyle | Approve | ||
Steve Kowalik (community) | code* | Approve | |
Review via email: mp+45474@code.launchpad.net |
Commit message
[r=mwhudson,
Description of the change
The title of a source package recipe build referred to the recipe.
It is possible that the recipe has been deleted.
I noticed the commonality with the tales adapter recently changed
(the dependent branch), so I moved that logic from the tales adapter
into the object itself.
I also took the opportunity to move the tales adapter itself into
the lp.code tree from lp.app.
To post a comment you must log in.
This looks fine, too.