Merge lp:~thumper/launchpad/fix-2a-description into lp:launchpad

Proposed by Tim Penhey on 2010-02-17
Status: Merged
Approved by: Michael Hudson-Doyle on 2010-02-17
Approved revision: not available
Merged at revision: 10326
Proposed branch: lp:~thumper/launchpad/fix-2a-description
Merge into: lp:launchpad
Diff against target: 61 lines (+7/-8)
3 files modified
lib/lp/code/bzr.py (+4/-6)
lib/lp/code/stories/branches/xx-branch-index.txt (+2/-1)
lib/lp/code/templates/branch-metadata.pt (+1/-1)
To merge this branch: bzr merge lp:~thumper/launchpad/fix-2a-description
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle 2010-02-17 Approve on 2010-02-17
Review via email: mp+19455@code.launchpad.net

Commit Message

Stop showing 2a branches as a development format.

To post a comment you must log in.
Tim Penhey (thumper) wrote :

Stops 2a format branches showing the format as development.

I changed the text for the repository format to use the title rather than the description to get:
  Bazaar repository format 2a (needs bzr 1.16 or later)
instead of
  Repository format 2a - rich roots, group compression and chk inventories

Michael Hudson-Doyle (mwhudson) wrote :

Well that seems easy enough.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/bzr.py'
2--- lib/lp/code/bzr.py 2010-02-02 22:13:13 +0000
3+++ lib/lp/code/bzr.py 2010-02-17 07:47:17 +0000
4@@ -13,7 +13,8 @@
5 ]
6
7
8-# Ensure correct plugins are loaded. Do not delete this line.
9+# Ensure correct plugins are loaded. Do not delete this comment or the line
10+# below this comment.
11 import lp.codehosting
12 from bzrlib.branch import (
13 BranchReferenceFormat, BzrBranchFormat4, BzrBranchFormat5,
14@@ -30,6 +31,7 @@
15 from bzrlib.repofmt.weaverepo import (
16 RepositoryFormat4, RepositoryFormat5, RepositoryFormat6,
17 RepositoryFormat7)
18+from bzrlib.repofmt.groupcompress_repo import RepositoryFormat2a
19
20 from lazr.enum import DBEnumeratedType, DBItem
21
22@@ -189,11 +191,7 @@
23 " and chk inventories\n",
24 )
25
26- BZR_CHK_2A = DBItem(415,
27- "Bazaar repository format 2a (needs bzr 1.16 or later)\n",
28- "Development repository format - rich roots, group compression"
29- " and chk inventories\n",
30- )
31+ BZR_CHK_2A = _format_enum(415, RepositoryFormat2a)
32
33
34 class ControlFormat(DBEnumeratedType):
35
36=== modified file 'lib/lp/code/stories/branches/xx-branch-index.txt'
37--- lib/lp/code/stories/branches/xx-branch-index.txt 2009-09-30 11:07:54 +0000
38+++ lib/lp/code/stories/branches/xx-branch-index.txt 2010-02-17 07:47:17 +0000
39@@ -368,7 +368,8 @@
40 Branch format: Branch format 5
41 >>> print extract_text(find_tag_by_id(
42 ... browser.contents, 'repository-format'))
43- Repository format: Packs containing knits without subtree support
44+ Repository format:
45+ Bazaar pack repository format 1 (needs bzr 0.92)
46
47
48 === Stacking ===
49
50=== modified file 'lib/lp/code/templates/branch-metadata.pt'
51--- lib/lp/code/templates/branch-metadata.pt 2010-01-22 06:03:19 +0000
52+++ lib/lp/code/templates/branch-metadata.pt 2010-02-17 07:47:17 +0000
53@@ -12,7 +12,7 @@
54 <dl id="repository-format"
55 tal:condition="context/repository_format">
56 <dt>Repository format:</dt>
57- <dd tal:content="context/repository_format/description" />
58+ <dd tal:content="context/repository_format/title" />
59 </dl>
60 <dl id="stacked-on" tal:condition="context/stacked_on">
61 <dt>Stacked on:</dt>