lp:~thumper/juju-core/reduce-tools-dependencies

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~go-bot/juju-core/trunk

Tim Penhey (community): Disapprove on 2013-07-22

Diff: 619 lines (+127/-51)

16 files modified

agent/config/agent.go (+4/-3)
agent/config/agent_test.go (+27/-27)
agent/package_test.go (+27/-0)
cmd/jujud/agent.go (+1/-1)
cmd/jujud/agent_test.go (+7/-6)
cmd/jujud/bootstrap_test.go (+1/-1)
cmd/jujud/machine_test.go (+1/-1)
cmd/jujud/unit_test.go (+1/-1)
cmd/jujud/upgradevalidation.go (+1/-1)
cmd/jujud/upgradevalidation_test.go (+1/-1)
environs/bootstrap.go (+2/-2)
environs/cloudinit/cloudinit.go (+4/-3)
environs/local/environ.go (+2/-1)
testing/imports.go (+43/-0)
worker/deployer/simple.go (+2/-1)
worker/deployer/simple_test.go (+3/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1494. By Tim Penhey on 2013-07-19

Add a testing function to check imports.

1493. By Tim Penhey on 2013-07-18

Break apart the dependencies.

1492. By Tim Penhey on 2013-07-18

Move agent.Conf into agent/config.

1491. By Dimiter Naydenov on 2013-07-18

[r=dimitern] state/api/watcher: Client-side watchers improved

This branch fixes an issue with StringsWatcher at
client-side: it was possible to drop events if you
do not keep reading constantly. Now they get queued
up and arrive in the order delivered when reading.
Added a test as well.

Also, as a drive-by fix: there was a possibility for
deadlocking in both StringsWatcher and NotifyWatcher
when trying to close it while there is an event waiting
to be read. Added tests for these cases as well and
verified that without the fix deadlocks are indeed
triggered.

https://codereview.appspot.com/11506043/

R=fwereade, rogpeppe

1490. By Raphaël Badin on 2013-07-18

[r=rvb] Azure provider: add state file URL

1489. By Roger Peppe on 2013-07-18

[r=rogpeppe] worker/uniter/charm: fix temp dir

Fixes https://bugs.launchpad.net/juju-core/+bug/1197369 .

I'm not sure whether the time stamp is actually necessary,
so I've left it as designed. It seems that the directory is
never actually removed, so that's probably a reasonable
rationale for that.

https://codereview.appspot.com/11290043/

1488. By Martin Packman on 2013-07-18

[r=gz] Add state/address.go for machine location data

Add data structure for describing machine addresses. This is the
first step towards deprecating PublicAddress and PrivateAddress
in unitDoc and storing a list of addresses in machineDoc instead.

The structure uses a single field that may contain either a hostname
or an address. The plan is for a New constructor to correctly flag
the type of location.

https://codereview.appspot.com/11284044/

R=fwereade, jameinel

1487. By Tim Penhey on 2013-07-18

[r=thumper] Add the autostart symlink for containers.

In order for containers to autostart, there needs to be
a symlink in /etc/lxc/auto called CN.conf where CN is
the container name, which points to the config file for
the container, which is by default /var/lib/lxc/CN/config.

https://codereview.appspot.com/11491043/

1486. By Jeroen T. Vermeulen on 2013-07-18

[r=thumper] Clean up the code a bit with “make simplify”.

We should do this regularly. In this case, it only made one tiny change.

1485. By Tim Penhey on 2013-07-18

[r=thumper] Add the admin-secret to the local boilerplate.

Was missed in the first pass.

https://codereview.appspot.com/11455044/