Code review comment for lp:~thumper/golxc/mockable

Revision history for this message
Ian Booth (wallyworld) wrote :

Trivials:

English:
931 + // Clone creates a copy of the container, it gets the given name.
932 + Clone(name string) (Container, error)

Perhaps: // Clone creates a copy of the container, giving the copy the specified name.

962 + // LogLevel returns the current logging level, this is only used if the
963 + // LogFile is not "".
964 + LogLevel() LogLevel

Perhaps: // LogLevel returns the current logging level (only used if the LogFile is not "").

Also, some comments have "." at the end, others don't.

 +// ContainerFactory represents the methods used to create Containers.
971 +type ContainerFactory interface {
972 + // New returns a container instance which can then be used for operations
973 + // like Create(), Start(), Stop() or Destroy().
974 + New(string) Container
975 + List() ([]Container, error)
976 +}

Please add a comment for List(). I know there's one on the method implementation, but the interface is where you really want to see the comment.

review: Approve

« Back to merge proposal