This is because xserver creates libdmxconfig.a internally and then links with
the linker flag -ldmxconfig. However according to automake documentation the
-lfoo linker flags should only be used for external dependencies and all
internal libraries should be linked with the libtool archive file (.la) or
the static archive (.a) when the former is not available.
GNU libtool is far more permissive and happens to silently obscure this issue
while slibtool fails because it instead sees '-L./.libs -ldmxconfig'.
Signed-off-by: Matt Turner <email address hidden>
(cherry picked from commit 2531ee02450e3be3549daa09407557c3addeba02)
e49738f...
by
=?utf-8?b?Wm9sdMOhbiBCw7ZzesO2cm3DqW55aQ==?= <email address hidden>
xfree86: Fix NULL pointer dereference crash
screenp->displays[count] (passed to configDisplay() in
configScreen()) is NULL if there is no Virtual setting
in the configuration.
Fixes: f8a6be04d0c7e6a99824ff888ad6c010960c5c21 ("xfree86: Change
displays array to pointers array to fix invalid pointer issues
after table reallocation")
Signed-off-by: Zoltán Böszörményi <email address hidden>
(cherry picked from commit ef89b6648e2a806237a6d2fa598e1b9c83f128b4)
9a59631...
by
Olivier Fourdan <email address hidden>
glx: Fix use after free in MakeCurrent
The fix from commit c468d34c7 - "glx: Set ContextTag for all contexts"
is actually incomplete, it correctly sets the context tag for direct
contexts as well, but would fail to mark the context's currentClient.
As a result, when the context is destroyed, it would be freed
immediately rather than being just scheduled for deletion, even though
it is still current for some client. leading to a use-after-free.
Make sure to also set the context's currentClient for direct contexts as
well, not just indirect ones.
Signed-off-by: Olivier Fourdan <email address hidden>
Fixes: c468d34c7 - "glx: Set ContextTag for all contexts"
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1186
Reviewed-by: Adam Jackson <email address hidden>
(cherry picked from commit aad61e8e03311eb8bae4f7db59e65634733eadc2)
xfree86: Change displays array to pointers array to fix invalid pointer issues after table reallocation
There are rare cases when xf86SetDepthBpp is resizing displays array in confScreen.
As that array is shared between set of ScrnInfoRec's then realloc might invalidate chached DispPtr display values in
otheres ScrnInfoRec objects.
If we will change displays array as an array of pointers to DispRec then cached DispRec pointers in ScrnInfoRec
won't be invalid after reallocation of displays array.
22449f6...
by
Jose Maria Casanova Crespo <email address hidden>
glamor: Avoid using GL_QUADS on V3D
Like in 0e3f1252dacdc3194 ("glamor: Avoid using GL_QUADS on VC4")
this will avoid mesa to fallback doing conversion for QUADS primitives.
Signed-off-by: Jose Maria Casanova Crespo <email address hidden>
Reviewed-by: Emma Anholt <email address hidden>
(cherry picked from commit 9adb13e296baead53112a268ddfd291195742c71)
d16f640...
by
=?utf-8?b?VmlsbGUgU3lyasOkbMOk?= <email address hidden>
modesetting: Fix possible_crtcs
Populate outout possible_crtcs as the union of possible_crtcs from
the encoders rather than the intersection. Otherwise we're easily left
with possible_crtcs==0 when all the possible encoders have
non-overlapping possible_crtcs.
No idea what the magic 0x7f is about, but keep it around in case
it matters.
Signed-off-by: Ville Syrjälä <email address hidden>
(cherry picked from commit 0e4bd71d02d09c320e76280ae8f14df169387507)
f1e7673...
by
=?utf-8?b?VmlsbGUgU3lyasOkbMOk?= <email address hidden>
modesetting: Update props for dynamically added outputs
Dynamically added outputs should have their properties
properly updated as well. Otherwise we're left with an output
with many of its propeties not exposed.
Signed-off-by: Ville Syrjälä <email address hidden>
Reviewed-by: Michel Dänzer <email address hidden>
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1143
(cherry picked from commit 0c5179c280a193a1dbbe29160906087f06eae6f2)
