Mir

Merge lp:~thomir-deactivatedaccount/mir/add-docs-package into lp:~mir-team/mir/trunk

Proposed by Thomi Richards
Status: Merged
Approved by: Robert Ancell
Approved revision: no longer in the source branch.
Merged at revision: 481
Proposed branch: lp:~thomir-deactivatedaccount/mir/add-docs-package
Merge into: lp:~mir-team/mir/trunk
Diff against target: 129 lines (+22/-12)
4 files modified
cmake/Doxygen.cmake (+2/-1)
debian/control (+18/-10)
debian/mir-doc.install (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/mir/add-docs-package
Reviewer Review Type Date Requested Status
Robert Ancell Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+152597@code.launchpad.net

Commit message

Build documentation automatically as part of the build.

Description of the change

This branch modified the cmake scripts & debian/ control files to:

 * Automatically build the API documentation as part of a normal build.
 * Build a 'mir-doc' package that contains the mir API documentation.

This package is required before we can post the API documentation online as part of the autolanding process.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:469
http://jenkins.qa.ubuntu.com/job/mir-ci/33/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-quantal-amd64-ci/33//console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/mir-ci/33//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Worked for me

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'm not convinced I like running doxygen over the whole codebase on every little rebuild.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Is there a cmake method that does this like --enable-doc does on autotools?

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi Robert,

alf's fixed that already - you can run with -DBUILD_DOXYGEN if you want the docs to be built - the debian package builder does this by default now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/Doxygen.cmake'
2--- cmake/Doxygen.cmake 2013-03-04 16:02:02 +0000
3+++ cmake/Doxygen.cmake 2013-03-10 21:41:21 +0000
4@@ -5,7 +5,8 @@
5 message(STATUS "doxygen ${DOXYGEN_VERSION} (>= 1.8.0) available - enabling make target doc")
6 configure_file(doc/Doxyfile.in
7 ${PROJECT_BINARY_DIR}/Doxyfile @ONLY IMMEDIATE)
8- add_custom_target(doc
9+ add_custom_target(doc ALL
10 COMMAND ${DOXYGEN_EXECUTABLE} ${PROJECT_BINARY_DIR}/Doxyfile
11 SOURCES ${PROJECT_BINARY_DIR}/Doxyfile)
12+ install(DIRECTORY ${CMAKE_BINARY_DIR}/doc/html DESTINATION ${CMAKE_INSTALL_PATH}/share/doc/mir-doc/)
13 endif()
14
15=== modified file 'debian/control'
16--- debian/control 2013-03-04 20:11:18 +0000
17+++ debian/control 2013-03-10 21:41:21 +0000
18@@ -6,6 +6,8 @@
19 Build-Depends: cmake,
20 cmake-data,
21 debhelper (>= 9),
22+ doxygen,
23+ graphviz,
24 libboost1.48-all-dev | libboost-all-dev,
25 protobuf-compiler,
26 libdrm-dev [!armhf],
27@@ -27,7 +29,7 @@
28 Depends: ${misc:Depends},
29 ${shlibs:Depends},
30 Description: Display server for Ubuntu - protocol implementation
31- Mir is a display server running on linux systems, with a focus on efficiency,
32+ Mir is a display server running on linux systems, with a focus on efficiency,
33 robust operation and a well-defined driver model.
34 .
35 Contains the protocol's shared library.
36@@ -40,7 +42,7 @@
37 ${misc:Depends},
38 ${shlibs:Depends},
39 Description: Display server for Ubuntu - protocol definition
40- Mir is a display server running on linux systems, with a focus on efficiency,
41+ Mir is a display server running on linux systems, with a focus on efficiency,
42 robust operation and a well-defined driver model.
43 .
44 Contains the protocol's definition files.
45@@ -51,7 +53,7 @@
46 Depends: ${misc:Depends},
47 ${shlibs:Depends},
48 Description: Display server for Ubuntu - server library
49- Mir is a display server running on linux systems, with a focus on efficiency,
50+ Mir is a display server running on linux systems, with a focus on efficiency,
51 robust operation and a well-defined driver model.
52 .
53 Contains the shared library needed by server applications for Mir.
54@@ -63,7 +65,7 @@
55 libmirprotobuf-dev (= ${source:Version}),
56 ${misc:Depends},
57 Description: Display server for Ubuntu - development headers
58- Mir is a display server running on linux systems, with a focus on efficiency,
59+ Mir is a display server running on linux systems, with a focus on efficiency,
60 robust operation and a well-defined driver model.
61 .
62 Contains header files required to build Mir servers.
63@@ -74,7 +76,7 @@
64 Depends: ${misc:Depends},
65 ${shlibs:Depends},
66 Description: Display server for Ubuntu - client library
67- Mir is a display server running on linux systems, with a focus on efficiency,
68+ Mir is a display server running on linux systems, with a focus on efficiency,
69 robust operation and a well-defined driver model.
70 .
71 Contains the shared library needed by client applications for Mir.
72@@ -86,18 +88,18 @@
73 libmirprotobuf-dev (= ${source:Version}),
74 ${misc:Depends},
75 Description: Display server for Ubuntu - development headers
76- Mir is a display server running on linux systems, with a focus on efficiency,
77+ Mir is a display server running on linux systems, with a focus on efficiency,
78 robust operation and a well-defined driver model.
79 .
80 Contains header files required to develop against Mir.
81
82 Package: libmirclient-demos
83 Architecture: any
84-Depends: ${misc:Depends},
85+Depends: ${misc:Depends},
86 libmirclient-dev(= ${binary:Version}),
87 Breaks: mir (<< 0.0.2-0ubuntu1)
88-Description: Display server for Ubuntu - example client programs
89- Mir is a display server running on linux systems, with a focus on efficiency,
90+Description: Display server for Ubuntu - example client programs
91+ Mir is a display server running on linux systems, with a focus on efficiency,
92 robust operation and a well-defined driver model.
93 .
94 Contains demo applications (with source) that use the Mir display server
95@@ -108,8 +110,14 @@
96 ${shlibs:Depends},
97 libmirserver0 (= ${binary:Version}),
98 Description: Display server for Ubuntu - server executable
99- Mir is a display server running on linux systems, with a focus on efficiency,
100+ Mir is a display server running on linux systems, with a focus on efficiency,
101 robust operation and a well-defined driver model.
102 .
103 Contains the main server executable.
104
105+Package: mir-doc
106+Architecture: all
107+Depends: ${misc:Depends}
108+Description: API documentation for mir
109+ This package installs the mir API documentation.
110+
111
112=== added file 'debian/mir-doc.install'
113--- debian/mir-doc.install 1970-01-01 00:00:00 +0000
114+++ debian/mir-doc.install 2013-03-10 21:41:21 +0000
115@@ -0,0 +1,1 @@
116+share/doc/mir-doc/
117
118=== modified file 'debian/rules'
119--- debian/rules 2013-01-28 20:54:07 +0000
120+++ debian/rules 2013-03-10 21:41:21 +0000
121@@ -32,7 +32,7 @@
122 endif
123
124 override_dh_installexamples:
125- dh_installexamples -p libmirclient-demos
126+ dh_installexamples -p libmirclient-demos
127
128 override_dh_makeshlibs:
129 dh_makeshlibs -V

Subscribers

People subscribed via source and target branches