Merge ~thomir-deactivatedaccount/gpgservice-client:use-tempfile-for-process-out into gpgservice-client:master

[Thomi Richards]

Ensure we call write hooks when using the test interface.

oops - this branch has a terrible name. anyway...

Ensure we call write hooks when using the test interface. Fixes lp:1559833:

https://bugs.launchpad.net/gpgservice-client/+bug/1559833

[Kit Randel (blr)]

lgtm, one very minor observation.

review: Approve

diff --git a/gpgservice_client/client.py b/gpgservice_client/client.py
index 2a42418..efa9210 100644
--- a/gpgservice_client/client.py
+++ b/gpgservice_client/client.py
@@ -221,6 +221,8 @@ class GPGClient:
                 "gpgservice was not configured with test endpoints enabled.")
         elif resp.status_code != http_codes['OK']:
             self.raise_for_error(resp)
+        else:
+            self._notify_writes()
 
     def getKeyDetailsFromKeyServer(self, fingerprint):
         """Get the details of a key from the configured key server.
diff --git a/gpgservice_client/tests/test_gpgclient.py b/gpgservice_client/tests/test_gpgclient.py
index b65d3b6..402be41 100644
--- a/gpgservice_client/tests/test_gpgclient.py
+++ b/gpgservice_client/tests/test_gpgclient.py
@@ -352,6 +352,18 @@ class GPGClientTests(TestCase):
             ContainsDict(dict(fingerprint=Equals(gpgkey_2['fingerprint'])))
             ))
 
+    def test_addKeyForTest_notifies_writes(self):
+        write_hook = Mock()
+        client = self.gpg_client
+        client.registerWriteHook(write_hook)
+        self.addCleanup(client.unregisterWriteHook, write_hook)
+
+        gpgkey = makeGPGKey()
+        user = self.get_random_owner_id_string()
+        client.addKeyForTest(user, **gpgkey)
+
+        self.assertTrue(write_hook.called)
+
     def test_retrieve_nonexistant_key_from_keyserver_returns_None(self):
         client = self.gpg_client
         gpgkey_1 = makeGPGKey()