Merge lp:~thomir-deactivatedaccount/gallery-app/fix-ap-call-interface into lp:gallery-app

[Thomi Richards]

Make gallery_app autopilot test suite work with newer versions of autopilot.

This branch fixes the call between the gallery app autopilot tests and autopilot. Previously, the call to 'launch_click_package' worked by accident. The arguments parameter is supposed to be a list, but worked with a single string as well. The new autopilot release makes this call stricter, requiring a list, not a string.

[Thomi Richards (thomir-deactivatedaccount)]

Please don't land this - we'll land it as part of an autopilot landing, so the changes hit distro in an atomic fashion.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:928
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/719/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/144
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/145
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/145/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/144
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4096
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3680
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3576
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4149
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4149/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3682
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3682/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6002
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5014

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/719/rebuild

review: Approve (continuous-integration)

[Arthur Mello (artmello)]

Rejecting since the comments mention that this should not be landed.

Unmerged revisions

928. By Thomi Richards on 2014-03-19

Pass a list of args to AutopilotTestCase.launch_click_package, not a string.

=== modified file 'tests/autopilot/gallery_app/tests/__init__.py'
--- tests/autopilot/gallery_app/tests/__init__.py	2014-03-07 10:57:54 +0000
+++ tests/autopilot/gallery_app/tests/__init__.py	2014-03-19 20:28:25 +0000
@@ -224,7 +224,7 @@
         logger.debug("Launching gallery-app via click package.")
         self.app = self.launch_click_package(
             package_id="com.ubuntu.gallery",
-            app_uris=' '.join(self.ARGS),
+            app_uris=self.ARGS,
             emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
 
     def ui_update(self):