core-image-publisher

Merge lp:~thomir-deactivatedaccount/core-image-publisher/trunk-use-uservice-utils into lp:core-image-publisher

trunk-use-uservice-utils
Merge into trunk

Proposed by Thomi Richards on 2015-04-01

Status:	Merged
Approved by:	Thomi Richards on 2015-04-01
Approved revision:	23
Merged at revision:	22
Proposed branch:	lp:~thomir-deactivatedaccount/core-image-publisher/trunk-use-uservice-utils
Merge into:	lp:core-image-publisher
Diff against target:	81 lines (+9/-43) 2 files modified core_image_publisher/__init__.py (+8/-43) requirements.txt (+1/-0)
To merge this branch:	bzr merge lp:~thomir-deactivatedaccount/core-image-publisher/trunk-use-uservice-utils
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Joe Talbott (community)		2015-04-01	Approve on 2015-04-01
Review via email: mp+254994@code.launchpad.net

Commit message

Use the new logging functions in uservice_utils.

Description of the change

Use the new logging functions in uservice_utils.

Revision history for this message

Joe Talbott (joetalbott) wrote on 2015-04-01:

One in-line nit. Otherwise looks good.

review: Approve

Revision history for this message

Ubuntu CI Bot (uci-bot) wrote on 2015-04-01:

Download full text (23.4 KiB)

The attempt to merge lp:~thomir/core-image-publisher/trunk-use-uservice-utils into lp:core-image-publisher failed. Below is the output from the failed tests.

Downloading/unpacking pyasn1 (from -r requirements.txt (line 6))
Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/pyasn1/setup.py) egg_info for package pyasn1

Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 7))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 8))
Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/python-logstash/setup.py) egg_info for package python-logstash

Downloading/unpacking python-glanceclient==0.17.0 (from -r requirements.txt (line 9))
Downloading/unpacking uservice-utils==1.0.0 (from -r requirements.txt (line 10))
Downloading/unpacking pycparser (from cffi->-r requirements.txt (line 5))
Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/pycparser/setup.py) egg_info for package pycparser

Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 7))
Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/amqp/setup.py) egg_info for package amqp

Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 7))
Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/anyjson/setup.py) egg_info for package anyjson

Downloading/unpacking six>=1.7.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking oslo.i18n>=1.3.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking argparse (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking pyOpenSSL>=0.11 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/pyOpenSSL/setup.py) egg_info for package pyOpenSSL

    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    no previously-included directories found matching 'doc/_build'
Downloading/unpacking requests>=2.2.0,!=2.4.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking PrettyTable>=0.7,<0.8 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/PrettyTable/setup.py) egg_info for package PrettyTable

Downloading/unpacking pbr>=0.6,!=0.7,<1.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking Babel>=1.3 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Running setup.py (path:/tmp/venv-core-image-p...

The attempt to merge lp:~thomir/core-image-publisher/trunk-use-uservice-utils into lp:core-image-publisher failed. Below is the output from the failed tests.

Using base prefix '/usr'
New python executable in /tmp/venv-core-image-publisher58vqgpxc/bin/python3
Also creating executable in /tmp/venv-core-image-publisher58vqgpxc/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python3
Ignoring indexes: https://pypi.python.org/simple/
Downloading/unpacking cffi (from -r requirements.txt (line 5))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/cffi/setup.py) egg_info for package cffi
    
Downloading/unpacking pyasn1 (from -r requirements.txt (line 6))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/pyasn1/setup.py) egg_info for package pyasn1
    
Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 7))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 8))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/python-logstash/setup.py) egg_info for package python-logstash
    
Downloading/unpacking python-glanceclient==0.17.0 (from -r requirements.txt (line 9))
Downloading/unpacking uservice-utils==1.0.0 (from -r requirements.txt (line 10))
Downloading/unpacking pycparser (from cffi->-r requirements.txt (line 5))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/pycparser/setup.py) egg_info for package pycparser
    
Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 7))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/amqp/setup.py) egg_info for package amqp
    
Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 7))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/anyjson/setup.py) egg_info for package anyjson
    
Downloading/unpacking six>=1.7.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking oslo.i18n>=1.3.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking argparse (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking pyOpenSSL>=0.11 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/pyOpenSSL/setup.py) egg_info for package pyOpenSSL
    
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    no previously-included directories found matching 'doc/_build'
Downloading/unpacking requests>=2.2.0,!=2.4.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking PrettyTable>=0.7,<0.8 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/PrettyTable/setup.py) egg_info for package PrettyTable
    
Downloading/unpacking pbr>=0.6,!=0.7,<1.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking Babel>=1.3 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/Babel/setup.py) egg_info for package Babel
    
    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
Downloading/unpacking warlock>=1.0.1,<2 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/warlock/setup.py) egg_info for package warlock
    
Downloading/unpacking python-keystoneclient>=1.0.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking oslo.utils>=1.2.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking cryptography>=0.2.1 (from pyOpenSSL>=0.11->python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/cryptography/setup.py) egg_info for package cryptography
    
    no previously-included directories found matching 'docs/_build'
    warning: no previously-included files matching '*' found under directory 'vectors'
Requirement already satisfied (use --upgrade to upgrade): pip in /tmp/venv-core-image-publisher58vqgpxc/lib/python3.4/site-packages (from pbr>=0.6,!=0.7,<1.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking pytz>=0a (from Babel>=1.3->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking jsonschema>=0.7,<3 (from warlock>=1.0.1,<2->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking jsonpatch>=0.10,<2 (from warlock>=1.0.1,<2->python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/jsonpatch/setup.py) egg_info for package jsonpatch
    warning: pypandoc module not found, could not convert Markdown to RST
    
Downloading/unpacking netaddr>=0.7.12 (from python-keystoneclient>=1.0.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking stevedore>=1.1.0 (from python-keystoneclient>=1.0.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking oslo.config>=1.9.0 (from python-keystoneclient>=1.0.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking oslo.serialization>=1.2.0 (from python-keystoneclient>=1.0.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking iso8601>=0.1.9 (from python-keystoneclient>=1.0.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking netifaces>=0.10.4 (from oslo.utils>=1.2.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/netifaces/setup.py) egg_info for package netifaces
    
Requirement already satisfied (use --upgrade to upgrade): setuptools in /tmp/venv-core-image-publisher58vqgpxc/lib/python3.4/site-packages (from cryptography>=0.2.1->pyOpenSSL>=0.11->python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking jsonpointer>=1.5 (from jsonpatch>=0.10,<2->warlock>=1.0.1,<2->python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/jsonpointer/setup.py) egg_info for package jsonpointer
    warning: pypandoc module not found, could not convert Markdown to RST
    
Downloading/unpacking msgpack-python>=0.4.0 (from oslo.serialization>=1.2.0->python-keystoneclient>=1.0.0->python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/msgpack-python/setup.py) egg_info for package msgpack-python
    
Installing collected packages: cffi, pyasn1, kombu, python-logstash, python-glanceclient, uservice-utils, pycparser, amqp, anyjson, six, oslo.i18n, argparse, pyOpenSSL, requests, PrettyTable, pbr, Babel, warlock, python-keystoneclient, oslo.utils, cryptography, pytz, jsonschema, jsonpatch, netaddr, stevedore, oslo.config, oslo.serialization, iso8601, netifaces, jsonpointer, msgpack-python
  Running setup.py install for cffi
    building '_cffi_backend' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DUSE__THREAD -I/usr/include/ffi -I/usr/include/libffi -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c c/_cffi_backend.c -o build/temp.linux-x86_64-3.4/c/_cffi_backend.o
    x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/c/_cffi_backend.o -lffi -o build/lib.linux-x86_64-3.4/_cffi_backend.cpython-34m.so
    
  Running setup.py install for pyasn1
    
  Running setup.py install for python-logstash
    
  Running setup.py install for pycparser
    
  Running setup.py install for amqp
    
  Running setup.py install for anyjson
    Fixing build/lib/anyjson/__init__.py
    Skipping implicit fixer: buffer
    Skipping implicit fixer: idioms
    Skipping implicit fixer: set_literal
    Skipping implicit fixer: ws_comma
    Fixing build/lib/anyjson/__init__.py
    Skipping implicit fixer: buffer
    Skipping implicit fixer: idioms
    Skipping implicit fixer: set_literal
    Skipping implicit fixer: ws_comma
    
  Running setup.py install for pyOpenSSL
    
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    no previously-included directories found matching 'doc/_build'
  Running setup.py install for PrettyTable
    
  Running setup.py install for Babel
    
    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
    Installing pybabel script to /tmp/venv-core-image-publisher58vqgpxc/bin
  Running setup.py install for warlock
    
  Running setup.py install for cryptography
    
    no previously-included directories found matching 'docs/_build'
    warning: no previously-included files matching '*' found under directory 'vectors'
    building '_Cryptography_cffi_e9178e86x399b1113' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_e9178e86x399b1113.c -o build/temp.linux-x86_64-3.4/src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_e9178e86x399b1113.o
    x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_e9178e86x399b1113.o -lssl -lcrypto -o build/lib.linux-x86_64-3.4/cryptography/_Cryptography_cffi_e9178e86x399b1113.cpython-34m.so
    building '_Cryptography_cffi_a8febd48xffc7b1ce' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_a8febd48xffc7b1ce.c -o build/temp.linux-x86_64-3.4/src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_a8febd48xffc7b1ce.o
    x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_a8febd48xffc7b1ce.o -o build/lib.linux-x86_64-3.4/cryptography/_Cryptography_cffi_a8febd48xffc7b1ce.cpython-34m.so
    building '_Cryptography_cffi_b03f9c7x62b488b1' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_b03f9c7x62b488b1.c -o build/temp.linux-x86_64-3.4/src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_b03f9c7x62b488b1.o
    x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/src/cryptography/hazmat/bindings/__pycache__/_Cryptography_cffi_b03f9c7x62b488b1.o -o build/lib.linux-x86_64-3.4/cryptography/_Cryptography_cffi_b03f9c7x62b488b1.cpython-34m.so
  Running setup.py install for jsonpatch
    warning: pypandoc module not found, could not convert Markdown to RST
    changing mode of build/scripts-3.4/jsondiff from 664 to 775
    changing mode of build/scripts-3.4/jsonpatch from 664 to 775
    
    changing mode of /tmp/venv-core-image-publisher58vqgpxc/bin/jsondiff to 775
    changing mode of /tmp/venv-core-image-publisher58vqgpxc/bin/jsonpatch to 775
  Running setup.py install for netifaces
    checking for getifaddrs...found.
    checking for getnameinfo...found.
    checking for optional header files...netash/ash.h netatalk/at.h netax25/ax25.h neteconet/ec.h netipx/ipx.h netpacket/packet.h linux/irda.h linux/atm.h linux/llc.h linux/tipc.h linux/dn.h.
    checking whether struct sockaddr has a length field...no.
    checking which sockaddr_xxx structs are defined...at ax25 in in6 ipx un ash ec ll atmpvc atmsvc dn irda llc.
    checking for routing socket support...no.
    checking for sysctl(CTL_NET...) support...no.
    checking for netlink support...yes.
    will use netlink to read routing table
    building 'netifaces' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DNETIFACES_VERSION=0.10.4 -DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETASH_ASH_H=1 -DHAVE_NETATALK_AT_H=1 -DHAVE_NETAX25_AX25_H=1 -DHAVE_NETECONET_EC_H=1 -DHAVE_NETIPX_IPX_H=1 -DHAVE_NETPACKET_PACKET_H=1 -DHAVE_LINUX_IRDA_H=1 -DHAVE_LINUX_ATM_H=1 -DHAVE_LINUX_LLC_H=1 -DHAVE_LINUX_TIPC_H=1 -DHAVE_LINUX_DN_H=1 -DHAVE_SOCKADDR_AT=1 -DHAVE_SOCKADDR_AX25=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1 -DHAVE_SOCKADDR_IPX=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_ASH=1 -DHAVE_SOCKADDR_EC=1 -DHAVE_SOCKADDR_LL=1 -DHAVE_SOCKADDR_ATMPVC=1 -DHAVE_SOCKADDR_ATMSVC=1 -DHAVE_SOCKADDR_DN=1 -DHAVE_SOCKADDR_IRDA=1 -DHAVE_SOCKADDR_LLC=1 -DHAVE_PF_NETLINK=1 -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c netifaces.c -o build/temp.linux-x86_64-3.4/netifaces.o
    x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/netifaces.o -o build/lib.linux-x86_64-3.4/netifaces.cpython-34m.so
    
  Running setup.py install for jsonpointer
    warning: pypandoc module not found, could not convert Markdown to RST
    changing mode of build/scripts-3.4/jsonpointer from 664 to 775
    
    changing mode of /tmp/venv-core-image-publisher58vqgpxc/bin/jsonpointer to 775
  Running setup.py install for msgpack-python
    building 'msgpack._packer' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -D__LITTLE_ENDIAN__=1 -I. -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c msgpack/_packer.cpp -o build/temp.linux-x86_64-3.4/msgpack/_packer.o
    cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ [enabled by default]
    x86_64-linux-gnu-g++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/msgpack/_packer.o -o build/lib.linux-x86_64-3.4/msgpack/_packer.cpython-34m.so
    building 'msgpack._unpacker' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -D__LITTLE_ENDIAN__=1 -I. -I/usr/include/python3.4m -I/tmp/venv-core-image-publisher58vqgpxc/include/python3.4m -c msgpack/_unpacker.cpp -o build/temp.linux-x86_64-3.4/msgpack/_unpacker.o
    cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ [enabled by default]
    msgpack/_unpacker.pyx: In function ‘PyObject* __pyx_pf_7msgpack_9_unpacker_2unpackb(PyObject*, PyObject*, PyObject*, PyObject*, int, PyObject*, PyObject*, PyObject*, PyObject*, Py_ssize_t, Py_ssize_t, Py_ssize_t, Py_ssize_t, Py_ssize_t)’:
    msgpack/_unpacker.pyx:141:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             if off < buf_len:
                                     ^
    msgpack/_unpacker.pyx: In function ‘PyObject* __pyx_f_7msgpack_9_unpacker_8Unpacker_read_from_file(__pyx_obj_7msgpack_9_unpacker_Unpacker*)’:
    msgpack/_unpacker.pyx:367:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                         self.max_buffer_size - (self.buf_tail - self.buf_head)
                         ^
    msgpack/_unpacker.pyx: In function ‘PyObject* __pyx_pf_7msgpack_9_unpacker_8Unpacker_8read_bytes(__pyx_obj_7msgpack_9_unpacker_Unpacker*, Py_ssize_t)’:
    msgpack/_unpacker.pyx:412:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             nread = min(self.buf_tail - self.buf_head, nbytes)
                         ^
    In file included from msgpack/unpack.h:278:0,
                     from msgpack/_unpacker.cpp:241:
    msgpack/unpack_template.h: In function ‘int unpack_execute(unpack_context*, const char*, size_t, size_t*) [with bool construct = false; unpack_context = unpack_context; size_t = long unsigned int]’:
    msgpack/unpack_template.h:346:9: warning: ‘obj’ may be used uninitialized in this function [-Wmaybe-uninitialized]
             c->map_key = obj;
             ^
    x86_64-linux-gnu-g++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.4/msgpack/_unpacker.o -o build/lib.linux-x86_64-3.4/msgpack/_unpacker.cpython-34m.so
    
Successfully installed cffi pyasn1 kombu python-logstash python-glanceclient uservice-utils pycparser amqp anyjson six oslo.i18n argparse pyOpenSSL requests PrettyTable pbr Babel warlock python-keystoneclient oslo.utils cryptography pytz jsonschema jsonpatch netaddr stevedore oslo.config oslo.serialization iso8601 netifaces jsonpointer msgpack-python
Cleaning up...
Downloading/unpacking testtools==1.7.1 (from -r test_requirements.txt (line 1))
Downloading/unpacking flake8==2.4.0 (from -r test_requirements.txt (line 2))
  Downloading flake8-2.4.0-py2.py3-none-any.whl
Downloading/unpacking python-mimeparse (from testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading python-mimeparse-0.1.4.tar.gz
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/python-mimeparse/setup.py) egg_info for package python-mimeparse
    
Downloading/unpacking extras (from testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading extras-0.0.3.tar.gz
  Running setup.py (path:/tmp/venv-core-image-publisher58vqgpxc/build/extras/setup.py) egg_info for package extras
    
Downloading/unpacking unittest2>=1.0.0 (from testtools==1.7.1->-r test_requirements.txt (line 1))
Downloading/unpacking traceback2 (from testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading traceback2-1.4.0-py2.py3-none-any.whl
Downloading/unpacking pep8>=1.5.7,<1.6 (from flake8==2.4.0->-r test_requirements.txt (line 2))
  Downloading pep8-1.5.7-py2.py3-none-any.whl
Downloading/unpacking mccabe>=0.2.1,<0.4 (from flake8==2.4.0->-r test_requirements.txt (line 2))
  Downloading mccabe-0.3-py2.py3-none-any.whl
Downloading/unpacking pyflakes>=0.8.1,<0.9 (from flake8==2.4.0->-r test_requirements.txt (line 2))
  Downloading pyflakes-0.8.1-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): argparse in /tmp/venv-core-image-publisher58vqgpxc/lib/python3.4/site-packages (from unittest2>=1.0.0->testtools==1.7.1->-r test_requirements.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): six>=1.4 in /tmp/venv-core-image-publisher58vqgpxc/lib/python3.4/site-packages (from unittest2>=1.0.0->testtools==1.7.1->-r test_requirements.txt (line 1))
Downloading/unpacking linecache2 (from traceback2->testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading linecache2-1.0.0-py2.py3-none-any.whl
Installing collected packages: testtools, flake8, python-mimeparse, extras, unittest2, traceback2, pep8, mccabe, pyflakes, linecache2
*** Error compiling '/tmp/venv-core-image-publisher58vqgpxc/build/testtools/testtools/_compat2x.py'...
  File "/tmp/venv-core-image-publisher58vqgpxc/build/testtools/testtools/_compat2x.py", line 16
    raise exc_class, exc_obj, exc_tb
                   ^
SyntaxError: invalid syntax

Running setup.py install for python-mimeparse
    
  Running setup.py install for extras
    
Successfully installed testtools flake8 python-mimeparse extras unittest2 traceback2 pep8 mccabe pyflakes linecache2
Cleaning up...
running test
running egg_info
creating core_image_publisher.egg-info
writing dependency_links to core_image_publisher.egg-info/dependency_links.txt
writing core_image_publisher.egg-info/PKG-INFO
writing top-level names to core_image_publisher.egg-info/top_level.txt
writing manifest file 'core_image_publisher.egg-info/SOURCES.txt'
reading manifest file 'core_image_publisher.egg-info/SOURCES.txt'
writing manifest file 'core_image_publisher.egg-info/SOURCES.txt'
running build_ext
running flake8
core_image_publisher/__init__.py:21:1: F401 'logging' imported but unused
core_image_publisher/__init__.py:24:1: F401 'logstash' imported but unused
INFO: Executing: bzr branch lp:~canonical-ci-engineering/core-image-publisher/pip-cache /tmp/tmpy_bnry13pip-cache-/cache
INFO: Executing: virtualenv -p python3 /tmp/venv-core-image-publisher58vqgpxc
INFO: Executing: /tmp/venv-core-image-publisher58vqgpxc/bin/pip install --no-index --find-links=/tmp/tmpy_bnry13pip-cache-/cache -r requirements.txt
INFO: Executing: /tmp/venv-core-image-publisher58vqgpxc/bin/pip install -r test_requirements.txt
INFO: Executing: /tmp/venv-core-image-publisher58vqgpxc/bin/python3 setup.py test
INFO: Executing: /tmp/venv-core-image-publisher58vqgpxc/bin/python3 setup.py flake8
ERROR: Calling `['/tmp/venv-core-image-publisher58vqgpxc/bin/python3', 'setup.py', 'flake8']` failed (with code 1)

Branched 5 revisions.
test_can_read_message (core_image_publisher.tests.test_queue_integration.KombuQueueIntegrationTests)
core_image_publisher.tests.test_queue_integration.KombuQueueIntegrationTests.test_can_read_message ... ok
test_uncaught_exceptions_cause_message_requeue (core_image_publisher.tests.test_queue_integration.KombuQueueIntegrationTests)
core_image_publisher.tests.test_queue_integration.KombuQueueIntegrationTests.test_uncaught_exceptions_cause_message_requeue ... Caught unhandled exception while processing message: I am a bug, all up in ur bizniz!
ok

----------------------------------------------------------------------
Ran 2 tests in 0.044s

lp:~thomir-deactivatedaccount/core-image-publisher/trunk-use-uservice-utils updated on 2015-04-01

23. By Thomi Richards on 2015-04-01: Fix flake8 errors.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Canonical CI Engineering

 === modified file 'core_image_publisher/__init__.py'
 --- core_image_publisher/__init__.py	2015-03-31 16:45:10 +0000
 +++ core_image_publisher/__init__.py	2015-04-01 21:15:31 +0000
@@ -17,11 +17,9 @@
  import argparse
  import configparser
--import logging
--import logging.handlers
  import os
--import logstash
++from uservice_utils.logging import configure_service_logging
  from core_image_publisher.queue import (
      create_connection_from_config,
@@ -47,48 +45,15 @@
      return config
--def configure_logging(config):
--    root_logger = logging.getLogger()
--    root_logger.setLevel(logging.INFO)
--
--    # glanceclient & keystoneclient use requests, which logs for every
--    # new HTTP connection, so let's make it a little less chatty:
--    logging.getLogger('requests').setLevel(logging.WARNING)
--
--    # If there is no ./logs directory, fallback to stderr.
--    log_path = os.path.abspath(
--        os.path.join(__file__, '../../logs/core-image-publisher.log'))
--    log_dir = os.path.dirname(log_path)
--    if os.path.exists(log_dir):
--        handler = logging.handlers.TimedRotatingFileHandler(
--            log_path,
--            when='D',
--            interval=1
--        )
--    else:
--        print("'logs' directory '{}' does not exist, using stderr "
--              "for app log.".format(log_dir))
--        handler = logging.StreamHandler()
--
--    handler.setFormatter(
--        logging.Formatter(
--            '%(asctime)s  %(name)s %(levelname)s: %(message)s'
--        )
--    )
--    root_logger.addHandler(handler)
--    if 'logstash' in config:
--        root_logger.addHandler(
--            logstash.LogstashHandler(
--                config['logstash']['host'],
--                int(config['logstash']['port']),
--                int(config['logstash']['version'])
--            )
--        )
--
--
  def main():
      config = read_config()
--    configure_logging(config)
++    log_path = os.path.abspath(
++        os.path.join(__file__, '../../logs/core-image-publisher.log')
++    )
++    configure_service_logging(
++        log_path,
++        config['logstash'] if 'logstash' in config else None
++    )
      connection = create_connection_from_config(config)
      try:
          with connection:
 === modified file 'requirements.txt'
 --- requirements.txt	2015-03-30 22:11:38 +0000
 +++ requirements.txt	2015-04-01 21:15:31 +0000
@@ -7,3 +7,4 @@
  kombu==3.0.24
  python-logstash==0.4.2
  python-glanceclient==0.17.0
++uservice-utils==1.0.0