Merge lp:~thomir-deactivatedaccount/charms/trusty/tanuki-spec-manager/trunk-decompose-nagios into lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk

Proposed by Thomi Richards
Status: Merged
Approved by: Celso Providelo
Approved revision: 22
Merged at revision: 22
Proposed branch: lp:~thomir-deactivatedaccount/charms/trusty/tanuki-spec-manager/trunk-decompose-nagios
Merge into: lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk
Diff against target: 22 lines (+9/-4)
1 file modified
hooks/actions.py (+9/-4)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/charms/trusty/tanuki-spec-manager/trunk-decompose-nagios
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+269705@code.launchpad.net

Commit message

Decompose the /nagios check into /nagios/rabbitmq and /nagios/postgres.

Description of the change

Decompose the /nagios check into /nagios/rabbitmq and /nagios/postgres.

Must land together with https://code.launchpad.net/~thomir/tanuki-spec-manager/trunk-decompose-nagios/+merge/269704

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Looks good, thanks.

The only problem is that it has to land with https://code.launchpad.net/~thomir/tanuki-spec-manager/trunk-decompose-nagios/+merge/269704

I should have done this in stages, preserving /nagios implementation and nrpe check first, then drop the check and later drop the implementation ... however we can coordinate to avoid alerts going off this time.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/actions.py'
2--- hooks/actions.py 2015-08-14 14:25:07 +0000
3+++ hooks/actions.py 2015-09-01 03:15:52 +0000
4@@ -281,9 +281,14 @@
5 nrpe_compat = nrpe.NRPE()
6
7 nrpe_compat.add_check(
8- shortname="check_app_http",
9- description="Check app http",
10- check_cmd="/usr/lib/nagios/plugins/check_http -I 127.0.0.1 -p 8000 -e ' 200 OK' -u '/nagios'",
11- )
12+ shortname="check_app_http_rabbit",
13+ description="Application and app rabbitmq connection.",
14+ check_cmd="/usr/lib/nagios/plugins/check_http -I 127.0.0.1 -p 8000 -e ' 200 OK' -u '/nagios/rabbitmq'",
15+ )
16+ nrpe_compat.add_check(
17+ shortname="check_app_http_postgres",
18+ description="Application and app postgres connection.",
19+ check_cmd="/usr/lib/nagios/plugins/check_http -I 127.0.0.1 -p 8000 -e ' 200 OK' -u '/nagios/postgres'",
20+ )
21
22 nrpe_compat.write()

Subscribers

People subscribed via source and target branches

to all changes: