Merge lp:~thomir-deactivatedaccount/autopkgtest-result-checker/snappy-proposed-migration-change-exchange-name into lp:autopkgtest-result-checker/snappy-proposed-migration

[Thomi Richards]

Change queue names.

Change queue names

[Celso Providelo (cprov)]

Thomi,

I looks fine for now, except the partial/confusing service name that will be pushed to ELK.

I think we will have to review/cleanup the queue names when everything gets deployed, I am bothered by not having a standard as "<service>.<thing>.v1" where *thing* sometimes is plural sometimes is singular (result/results). We have deployed enough services to start make sense of their names.

{{{
stg-ue-ci-engineering@wendigo:~$ ~/adt-continuous-deployer/queue-monitor.py 162.213.32.181
+----------------------------------+----------+-------------------------+-----------+
| name | messages | messages_unacknowledged | consumers |
+----------------------------------+----------+-------------------------+-----------+
| adt.deadletters.v1 | 132 | 0 | 0 |
| adt.requests.amd64.nova.v1 | 1 | 1 | 20 |
| adt.requests.i386.nova.v1 | 0 | 0 | 20 |
| adt.results.v1 | 0 | 0 | 1 |
| core.deadletters.v1 | 0 | 0 | 0 |
| core.image.v1 | 0 | 0 | 1 |
| core.package.v1 | 0 | 0 | 1 |
| core.result.v1 | 0 | 0 | 2 |
| core.tests.v1 | 0 | 0 | 1 |
| pm.results | 1 | 0 | 0 |
| snappy-proposed-migration.result | 0 | 0 | 5 |
+----------------------------------+----------+-------------------------+-----------+
}}}

review: Needs Information

[Ubuntu CI Bot (uci-bot)]

Voting does not meet specified criteria. Required: Approve >= 1. Got: 1 Needs Information.

[Thomi Richards (thomir-deactivatedaccount)]

review: Approve

=== modified file 'core_result_checker/constants.py'
--- core_result_checker/constants.py	2015-05-25 21:23:51 +0000
+++ core_result_checker/constants.py	2015-05-26 23:43:22 +0000
@@ -20,19 +20,19 @@
 # Queue names are constant, rather than being defined in the config.
 
 # The queue we listen to for new payloads to check:
-INPUT_QUEUE = "snappy-proposed-migration.result"
+INPUT_QUEUE = "snappy-proposed.result.v1"
 
 # The queue we put fatally error'd payloads into:
-DEAD_LETTER_QUEUE = "core.deadletters.v1"
+DEAD_LETTER_QUEUE = "snappy-proposed.deadletters.v1"
 
 # The queue we put payloads on to re-run the test:
-TEST_RETRY_QUEUE = "snappy-proposed-migration.package"
+TEST_RETRY_QUEUE = "snappy-proposed.package.v1"
 
 # The exchange we put results on:
 DONE_EXCHANGE = "results.exchange"
 
 
-SOLUTION_NAME = "snappy-proposed-migration"
+SOLUTION_NAME = "snappy-proposed"
 
 SERVICE_NAME = "result-checker"