Merge lp:~thomir-deactivatedaccount/autopilot/workaround-null-signals-and-methods into lp:autopilot

[Thomi Richards]

Autopilot now handles empty replies from listMethods and listSignals methods on Qt applications.

Problem:

There's an issue in autopilot-qt that means that the signal and slot extension methods no longer function correctly. This isn't so bad, except it causes autopilot to crash inside the vis tool (not fatally however).

Solution:

This branch makes autopilot aware of the possibility that the remote app may send back an empty reply, instead of the list it was expecting.

[Christopher Lee (veebers)]

Good catch

review: Approve

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'autopilot/introspection/qt.py'
--- autopilot/introspection/qt.py	2012-12-03 01:57:49 +0000
+++ autopilot/introspection/qt.py	2013-03-14 21:40:28 +0000
@@ -154,12 +154,18 @@
     def get_signals(self):
         """Get a list of the signals available on this object."""
         dbus_signal_list = self._get_qt_iface().ListSignals(self.id)
-        return [str(sig) for sig in dbus_signal_list]
+        if dbus_signal_list is not None:
+            return [str(sig) for sig in dbus_signal_list]
+        else:
+            return []
 
     def get_slots(self):
         """Get a list of the slots available on this object."""
         dbus_slot_list = self._get_qt_iface().ListMethods(self.id)
-        return [str(sig) for sig in dbus_slot_list]
+        if dbus_slot_list is not None:
+            return [str(sig) for sig in dbus_slot_list]
+        else:
+            return []
 
 
 class QtSlotProxy(object):