Merge lp:~thomir-deactivatedaccount/autopilot/temp-dev-add-hooks into lp:~autopilot/autopilot/temp-dev
Proposed by
Thomi Richards
| Status: | Merged |
|---|---|
| Approved by: | Thomi Richards |
| Approved revision: | 511 |
| Merged at revision: | 515 |
| Proposed branch: | lp:~thomir-deactivatedaccount/autopilot/temp-dev-add-hooks |
| Merge into: | lp:~autopilot/autopilot/temp-dev |
| Diff against target: |
35 lines (+2/-1) 3 files modified
autopilot/tests/functional/test_input_stack.py (+0/-1) debian/control (+1/-0) debian/rules (+1/-0) |
| To merge this branch: | bzr merge lp:~thomir-deactivatedaccount/autopilot/temp-dev-add-hooks |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Martin Pitt (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make flake8 run as part of package build process, instead of relying on CI hooks.
Description of the change
Make flake8 run as part of package build process, instead of relying on CI hooks.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Martin Pitt (pitti) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It's ok for me, but please be aware that python3-flake8 is a scam -- it just depends on python-flake8 which provides the "flake8" binary, and flake8 isn't able to understand python 3 specific constructs. So as long as you want to keep the code python2 compatible as well, it's fine (and might be better to depend on python-flake8 explicitly).