Merge lp:~thomir-deactivatedaccount/autopilot/1.3-fix-functional-tests into lp:autopilot/1.3

[Thomi Richards]

Fix a missing test dependency, and add more logging when a process exits before we find the introspection interface.

Fix a missing test dependency, and add more logging when a process exits before we find the introspection interface.

[Christopher Lee (veebers)]

Looks good to me.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/autopilot-1.3-autolanding/18/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-amd64-autolanding/19
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-amd64-autolanding/19/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-armhf-autolanding/19/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-i386-autolanding/10
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-i386-autolanding/10/artifact/work/output/*zip*/output.zip
    None: http://s-jenkins:8080/job/generic-cleanup-mbs/2464/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:340
http://jenkins.qa.ubuntu.com/job/autopilot-1.3-ci/25/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-armhf-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-1.3-ci/25/rebuild

review: Approve (continuous-integration)

=== modified file 'autopilot/introspection/__init__.py'
--- autopilot/introspection/__init__.py	2013-09-19 19:46:31 +0000
+++ autopilot/introspection/__init__.py	2013-09-25 21:09:38 +0000
@@ -288,6 +288,10 @@
         _get_child_pids.reset_cache()
         if process is not None and not _process_is_running(process):
             return_code = process.poll()
+            stdout, stderr = process.communicate()
+            logger.error("Process exited with exit code: %d", return_code)
+            logger.error("Process stdout was: %r", stdout)
+            logger.error("Process stderr was: %r", stderr)
             raise ProcessSearchError(
                 "Process exited with exit code: %d"
                 % return_code

=== modified file 'debian/control'
--- debian/control	2013-09-15 15:37:35 +0000
+++ debian/control	2013-09-25 21:09:38 +0000
@@ -102,6 +102,7 @@
 Architecture: all
 Depends: ${misc:Depends},
          ${python:Depends},
+         dpkg-dev,
          libautopilot-gtk,
          libautopilot-qt,
          python-autopilot,