Merge lp:~thomir-deactivatedaccount/autopilot-qt/export-qobject into lp:autopilot-qt/1.4

Proposed by Christopher Lee
Status: Merged
Approved by: Christopher Lee
Approved revision: 79
Merged at revision: 77
Proposed branch: lp:~thomir-deactivatedaccount/autopilot-qt/export-qobject
Merge into: lp:autopilot-qt/1.4
Diff against target: 96 lines (+26/-8)
6 files modified
driver/qtnode.cpp (+5/-6)
tests/autopilot/libautopilot_qt/emulators/main_window_qt4.py (+3/-0)
tests/autopilot/libautopilot_qt/emulators/main_window_qt5.py (+4/-0)
tests/autopilot/libautopilot_qt/tests/test_main.py (+6/-2)
tests/autopilot/testapp/qt4.qml (+4/-0)
tests/autopilot/testapp/qt5.qml (+4/-0)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/autopilot-qt/export-qobject
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Christopher Lee (community) Approve
Review via email: mp+203456@code.launchpad.net

Commit message

Merging changes into RC branch for testing.

Description of the change

Merging changes into RC branch for testing.

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote :

LGTM - For testing

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'driver/qtnode.cpp'
2--- driver/qtnode.cpp 2013-09-03 04:45:05 +0000
3+++ driver/qtnode.cpp 2014-01-28 03:08:40 +0000
4@@ -180,12 +180,11 @@
5 children.push_back(std::make_shared<QtNode>(childItem, shared_from_this()));
6 }
7 }
8- } else {
9- foreach (QObject *child, object_->children())
10- {
11- if (child->parent() == object_)
12- children.push_back(std::make_shared<QtNode>(child, shared_from_this()));
13- }
14+ }
15+ foreach (QObject *child, object_->children())
16+ {
17+ if (child->parent() == object_)
18+ children.push_back(std::make_shared<QtNode>(child, shared_from_this()));
19 }
20
21 #else
22
23=== modified file 'tests/autopilot/libautopilot_qt/emulators/main_window_qt4.py'
24--- tests/autopilot/libautopilot_qt/emulators/main_window_qt4.py 2013-03-18 08:22:00 +0000
25+++ tests/autopilot/libautopilot_qt/emulators/main_window_qt4.py 2014-01-28 03:08:40 +0000
26@@ -55,3 +55,6 @@
27 if mousearea is None:
28 logger.error("*** select_single(\"QDeclarativeMouseArea\") failed ***")
29 return mousearea
30+
31+ def get_non_visual_component(self):
32+ return self.app.select_single(objectName="listModelTest")
33
34=== modified file 'tests/autopilot/libautopilot_qt/emulators/main_window_qt5.py'
35--- tests/autopilot/libautopilot_qt/emulators/main_window_qt5.py 2013-03-18 08:22:00 +0000
36+++ tests/autopilot/libautopilot_qt/emulators/main_window_qt5.py 2014-01-28 03:08:40 +0000
37@@ -55,3 +55,7 @@
38 if mousearea is None:
39 logger.error("*** select_single(\"QQuickMouseArea\") failed ***")
40 return mousearea
41+
42+ def get_non_visual_component(self):
43+ return self.app.select_single(objectName="listModelTest")
44+
45
46=== modified file 'tests/autopilot/libautopilot_qt/tests/test_main.py'
47--- tests/autopilot/libautopilot_qt/tests/test_main.py 2013-06-27 16:27:11 +0000
48+++ tests/autopilot/libautopilot_qt/tests/test_main.py 2014-01-28 03:08:40 +0000
49@@ -34,6 +34,10 @@
50 rectangle = self.main_window.get_test_rectangle_by_child_search()
51 self.assertThat(rectangle, NotEquals(None))
52
53+ def test_find_nonvisual_component(self):
54+ component = self.main_window.get_non_visual_component()
55+ self.assertThat(component, NotEquals(None))
56+
57
58 class TestProperties(AutopilotQtTestCase):
59
60@@ -61,8 +65,8 @@
61 self.assertThat(rectangle.color, Equals([0, 0, 255, 255]))
62
63 mousearea = self.main_window.get_test_mousearea()
64- self.pointing_device.move_to_object(mousearea)
65- self.pointing_device.click()
66+ self.mouse.move_to_object(mousearea)
67+ self.mouse.click()
68
69 self.assertThat(rectangle.color, Eventually(Equals([255, 0, 0, 255])))
70
71
72=== modified file 'tests/autopilot/testapp/qt4.qml'
73--- tests/autopilot/testapp/qt4.qml 2013-06-27 16:27:11 +0000
74+++ tests/autopilot/testapp/qt4.qml 2014-01-28 03:08:40 +0000
75@@ -56,4 +56,8 @@
76
77 onClicked: rect.color = "red"
78 }
79+
80+ ListModel {
81+ objectName: "listModelTest"
82+ }
83 }
84
85=== modified file 'tests/autopilot/testapp/qt5.qml'
86--- tests/autopilot/testapp/qt5.qml 2013-06-27 16:27:11 +0000
87+++ tests/autopilot/testapp/qt5.qml 2014-01-28 03:08:40 +0000
88@@ -56,4 +56,8 @@
89
90 onClicked: rect.color = "red"
91 }
92+
93+ ListModel {
94+ objectName: "listModelTest"
95+ }
96 }

Subscribers

People subscribed via source and target branches

to all changes: