adt-cloud-worker

Merge lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-version-result-queue into lp:adt-cloud-worker

  1. trunk-version-result-queue
  2. Merge into trunk
Proposed by Thomi Richards
Status: Merged
Approved by: Thomi Richards
Approved revision: 24
Merged at revision: 23
Proposed branch: lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-version-result-queue
Merge into: lp:adt-cloud-worker
Diff against target: 12 lines (+1/-1)
1 file modified
adt_cloud_worker/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-version-result-queue
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+253269@code.launchpad.net

Commit message

Add the version number to the result queue name.

Description of the change

This branch adds the api version ('v1') to the result queue name. This will allow us to iterate the result payload without breaking the deployed service.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Yup, good point on versioning the result queue too.

Just a minor typo that would be caught on tarmac ... pre-approving.

review: Approve
lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-version-result-queue updated
24. By Thomi Richards

Fix typo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'adt_cloud_worker/__init__.py'
2--- adt_cloud_worker/__init__.py 2015-03-17 03:05:50 +0000
3+++ adt_cloud_worker/__init__.py 2015-03-17 20:19:29 +0000
4@@ -112,7 +112,7 @@
5 finally:
6 # The post results
7 # TODO: send error logging to result-checker in the message
8- queue = self.connection.SimpleQueue('adt.results')
9+ queue = self.connection.SimpleQueue('adt.results.{}'.format(API_VERSION))
10 queue.put(body)
11 queue.close()
12 if tarball_path and os.path.exists(tarball_path):

Subscribers

People subscribed via source and target branches

to all changes: