adt-cloud-worker

Merge lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-swift-tarball-name into lp:adt-cloud-worker

  1. trunk-fix-swift-tarball-name
  2. Merge into trunk
Proposed by Thomi Richards
Status: Merged
Approved by: Thomi Richards
Approved revision: 24
Merged at revision: 24
Proposed branch: lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-swift-tarball-name
Merge into: lp:adt-cloud-worker
Diff against target: 10 lines (+1/-1)
1 file modified
adt_cloud_worker/_cloud_support.py (+1/-1)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-swift-tarball-name
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+253273@code.launchpad.net

Commit message

Dont's upload tarballs to swift with a '.tmp' suffix.

Description of the change

Don't add the .tmp' suffix to tarballs uploaded to swift. You can't easily rename objects in swift, and these files are private until the result-checker exposes them, so there's no need to use a temporary file.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Right, we found this earlier. Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'adt_cloud_worker/_cloud_support.py'
2--- adt_cloud_worker/_cloud_support.py 2015-03-08 22:30:42 +0000
3+++ adt_cloud_worker/_cloud_support.py 2015-03-17 20:29:35 +0000
4@@ -103,5 +103,5 @@
5 swift_client.put_container(container_name)
6 with open(tarball_path, 'rb') as fd:
7 swift_client.put_object(
8- container_name, obj='results.tgz.tmp', contents=fd,
9+ container_name, obj='results.tgz', contents=fd,
10 content_type='application/x-compressed')

Subscribers

People subscribed via source and target branches

to all changes: