Merge lp:~thomas-voss/unity8/add_post_inst_script_to_gain_cap_sys_resource into lp:unity8

Proposed by Thomas Voß
Status: Rejected
Rejected by: Michał Sawicz
Proposed branch: lp:~thomas-voss/unity8/add_post_inst_script_to_gain_cap_sys_resource
Merge into: lp:unity8
Diff against target: 24 lines (+19/-0)
1 file modified
debian/unity8.postinst (+19/-0)
To merge this branch: bzr merge lp:~thomas-voss/unity8/add_post_inst_script_to_gain_cap_sys_resource
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Michał Sawicz Needs Fixing
Didier Roche-Tolomelli Approve
Review via email: mp+191144@code.launchpad.net

Commit message

Add postinst script to grant CAP_SYS_RESOURCE for the unity8 executable.

Description of the change

Add postinst script to grant CAP_SYS_RESOURCE for the unity8 executable.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

LGTM

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

This is not working, 'cause we're ext2 mounted without xattr... does ext2 support xattr at all?

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/unity8-ci/1408/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/5012
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2934
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2275
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/431
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1408
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1408/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1407
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1182
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/887
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/887/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2936
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2936/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2444
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2487

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1408/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

looks good

review: Approve

Unmerged revisions

463. By Thomas Voß

Add postinst script to grant CAP_SYS_RESOURCE for the unity8 executable.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/unity8.postinst'
2--- debian/unity8.postinst 1970-01-01 00:00:00 +0000
3+++ debian/unity8.postinst 2013-10-15 10:47:14 +0000
4@@ -0,0 +1,19 @@
5+#!/bin/sh
6+
7+# As per https://bugs.launchpad.net/unity8/+bug/1238691 the unity8
8+# executable requires the capability to adjust the OOM scores of
9+# application processes and thus, CAP_SYS_RESOURCE.
10+
11+set -e
12+
13+PROGRAM=/usr/bin/unity8
14+
15+if [ "$1" = configure ]; then
16+ if which setcap > /dev/null && [ -e $PROGRAM ]; then
17+ if ! setcap CAP_SYS_RESOURCE=+ep $PROGRAM >/dev/null 2>&1; then
18+ echo "Setting capabilities for unity8 using Linux Capabilities failed."
19+ fi
20+ fi
21+fi
22+
23+#DEBHELPER#
24\ No newline at end of file

Subscribers

People subscribed via source and target branches