Merge lp:~thomas-voss/unity-mir/explicit-gcc-version into lp:unity-mir

Proposed by Thomas Voß
Status: Merged
Approved by: Gerry Boland
Approved revision: 240
Merged at revision: 246
Proposed branch: lp:~thomas-voss/unity-mir/explicit-gcc-version
Merge into: lp:unity-mir
Diff against target: 34 lines (+13/-0)
2 files modified
debian/control (+4/-0)
debian/rules (+9/-0)
To merge this branch: bzr merge lp:~thomas-voss/unity-mir/explicit-gcc-version
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Colin Watson (community) Approve
Matthias Klose Pending
Review via email: mp+224771@code.launchpad.net

Commit message

Explicitly select g++-4.9 to prevent from ABI breaks.

Description of the change

Explicitly select g++-4.9 to prevent from ABI breaks.

* Are there any related MPs required for this MP to build/function as expected? Please list. Yes, multiple of them, all ligned up together in a silo.
 * Did you perform an exploratory manual test run of your code change and any related functionality? Yes.
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP? Yes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Colin Watson (cjwatson) wrote :

I'd suggest versioning the build-dependency on libprocess-cpp-dev, but otherwise fine.

review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote :
review: Needs Fixing
239. By Thomas Voß

[ Kevin Gunn ]
* this is a fix for bug 1343639 (LP: #1343639)
[ Nick Dedekind ]
* Added mir prompt session support
[ Cemil Azizoglu ]
* Mir display server 0.5.0 release.
[ Robert Carr ]
* Mir display server 0.5.0 release.
[ Alexandros Frantzis ]
* Use surface relative coordinates when setting the input region for
  the input area Mir changed at some point to use surface relative
  coordinates for input regions. (LP: #1332624)
[ Gerry Boland ]
* Bump Mir dependencies to 0.4.0.
[ Cemil Azizoglu ]
* Bump Mir dependencies to 0.4.0.
[ Alberto Aguirre ]
* Bump Mir dependencies to 0.4.0.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
240. By Thomas Voß

Remove spurious changelog entry.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y - I tried the silo, was ok
 * Did CI run pass? If not, please explain why.
fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-07-17 07:53:54 +0000
3+++ debian/control 2014-07-18 12:05:33 +0000
4@@ -5,6 +5,10 @@
5 Build-Depends: debhelper (>= 9),
6 cmake,
7 google-mock (>= 1.6.0+svn437),
8+# We rely on C++11 features, and to prevent from ABI breaks
9+# in libstdc++ causing us issues, we explicitly select a G++
10+# version.
11+ g++-4.9,
12 pkg-config,
13 libboost-dev,
14 libboost-system-dev,
15
16=== modified file 'debian/rules'
17--- debian/rules 2014-01-09 09:04:50 +0000
18+++ debian/rules 2014-07-18 12:05:33 +0000
19@@ -3,6 +3,15 @@
20
21 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
22
23+include /usr/share/dpkg/default.mk
24+
25+# Explicitly selecting a G{CC,++}-version here to avoid accidental
26+# ABI breaks introduced by toolchain updates.
27+export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
28+export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
29+
30 %:
31 dh $@ --parallel --fail-missing
32
33+override_dh_auto_configure:
34+ dh_auto_configure -- -DCMAKE_C_COMPILER=$(CC) -DCMAKE_CXX_COMPILER=$(CXX)

Subscribers

People subscribed via source and target branches