lp:~thomas-voss/qtubuntu-media/reuse-precreated-objects

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:qtubuntu-media at revision 55

Alberto Aguirre (community): Approve on 2014-11-05

Jim Hodapp (community): Approve (code) on 2014-11-05

PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-11-05

Diff: 222 lines (+36/-42)

4 files modified

src/aal/aalmediaplayerservice.cpp (+27/-22)
src/aal/aalmediaplayerservice.h (+0/-3)
src/aal/aalmediaplayerserviceplugin.cpp (+2/-5)
unittests/tst_mediaplayerplugin.cpp (+7/-12)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1387959: [TOPBLOCKER] unity8 crash in image krillin rtm 139	Critical	Invalid
Bug #1389276: [desktop] unity8 crashes on startup at AalMediaPlayerService::setAudioRole	Undecided	Invalid

Link a bug report

Related blueprints

65. By Thomas Voß on 2014-11-05

Guard setup of audio role for probably null object.

64. By Thomas Voß on 2014-11-05

Clean up test case and make sure that the fixture is setup cleanly for every test case.

63. By Thomas Voß on 2014-11-04

Revert change to dtor.

62. By Thomas Voß on 2014-11-04

Clean up patch.

61. By Thomas Voß on 2014-11-04

initialize controls on construction.

60. By Thomas Voß on 2014-11-04

Add checks for media hub session being null.

59. By Thomas Voß on 2014-11-04

Remove initialization of removed member.

58. By Thomas Voß on 2014-11-04

Make sure that we do not recycle objects.

57. By Thomas Voß on 2014-11-04

Do not delete cached service instance.

56. By Thomas Voß on 2014-11-04

Forward declare the media service plugin.