Merge lp:~thomas-voss/process-cpp/bump-so-name-and-major-version into lp:process-cpp

Proposed by Thomas Voß
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp:~thomas-voss/process-cpp/bump-so-name-and-major-version
Merge into: lp:process-cpp
Diff against target: 84 lines (+19/-5)
4 files modified
CMakeLists.txt (+2/-2)
debian/control (+6/-2)
debian/libprocess-cpp2.symbols (+1/-1)
debian/rules (+10/-0)
To merge this branch: bzr merge lp:~thomas-voss/process-cpp/bump-so-name-and-major-version
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
PS Jenkins bot continuous-integration Approve
Colin Watson Approve
Matthias Klose Pending
Ubuntu Phablet Team Pending
Review via email: mp+223390@code.launchpad.net

Commit message

Prepare for transition to GCC 4.9.

Description of the change

Prepare for transition to GCC 4.9.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Steve Langasek (vorlon) wrote :

This branch was superseded by lp:~thomas-voss/process-cpp/explicit-gcc-version, which has in turn been superseded by lp:~vorlon/process-cpp/explicit-gcc-version.

review: Disapprove

Unmerged revisions

53. By Thomas Voß

Prepare for transition to GCC 4.9.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-05-21 16:56:20 +0000
3+++ CMakeLists.txt 2014-06-17 11:38:54 +0000
4@@ -56,9 +56,9 @@
5 SET(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -ftest-coverage -fprofile-arcs" )
6 ENDIF(cmake_build_type_lower MATCHES coverage)
7
8-set(PROCESS_CPP_VERSION_MAJOR 1)
9+set(PROCESS_CPP_VERSION_MAJOR 2)
10 set(PROCESS_CPP_VERSION_MINOR 0)
11-set(PROCESS_CPP_VERSION_PATCH 1)
12+set(PROCESS_CPP_VERSION_PATCH 0)
13
14 include(CTest)
15
16
17=== modified file 'debian/control'
18--- debian/control 2014-03-24 17:12:32 +0000
19+++ debian/control 2014-06-17 11:38:54 +0000
20@@ -1,9 +1,13 @@
21 Source: process-cpp
22 Priority: optional
23 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+# We rely on C++11 features, and to prevent from ABI breaks
25+# in libstdc++ causing us issues, we explicitly select a G++
26+# version.
27 Build-Depends: cmake,
28 debhelper (>= 9),
29 doxygen,
30+ g++-4.9,
31 google-mock,
32 graphviz,
33 libboost-dev,
34@@ -19,7 +23,7 @@
35 Vcs-Bzr: https://code.launchpad.net/~phablet-team/content-hub/trunk
36 Vcs-Browser: https://bazaar.launchpad.net/~phablet-team/process-cpp/trunk/files
37
38-Package: libprocess-cpp1
39+Package: libprocess-cpp2
40 Architecture: any
41 Multi-Arch: same
42 Pre-Depends: ${misc:Pre-Depends},
43@@ -35,7 +39,7 @@
44 Architecture: any
45 Multi-Arch: same
46 Recommends: libprocess-cpp-doc,
47-Depends: libprocess-cpp1 (= ${binary:Version}),
48+Depends: libprocess-cpp2 (= ${binary:Version}),
49 ${misc:Depends},
50 libproperties-cpp-dev,
51 Description: C++11 library for handling processes - dev headers and libraries
52
53=== renamed file 'debian/libprocess-cpp1.install' => 'debian/libprocess-cpp2.install'
54=== renamed file 'debian/libprocess-cpp1.symbols' => 'debian/libprocess-cpp2.symbols'
55--- debian/libprocess-cpp1.symbols 2014-05-22 09:49:50 +0000
56+++ debian/libprocess-cpp2.symbols 2014-06-17 11:38:54 +0000
57@@ -1,4 +1,4 @@
58-libprocess-cpp.so.1 libprocess-cpp1 #MINVER#
59+libprocess-cpp.so.2 libprocess-cpp2 #MINVER#
60 (c++)"core::posix::Signalable::send_signal(core::posix::Signal, std::error_code&)@Base" 1.0.0+14.04.20140326.2
61 (c++)"core::posix::Signalable::send_signal_or_throw(core::posix::Signal)@Base" 1.0.0+14.04.20140326.2
62 (c++)"core::posix::ChildProcess::DeathObserver::create_once_with_signal_trap(std::shared_ptr<core::posix::SignalTrap>)@Base" 1.0.0+14.04.20140326.2
63
64=== modified file 'debian/rules'
65--- debian/rules 2013-10-21 12:07:28 +0000
66+++ debian/rules 2014-06-17 11:38:54 +0000
67@@ -1,7 +1,17 @@
68 #!/usr/bin/make -f
69 # -*- makefile -*-
70
71+include /usr/share/dpkg/default.mk
72+
73+# Explicitly selecting a G{CC,++}-version here to avoid accidental
74+# ABI breaks introduced by toolchain updates.
75+export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
76+export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
77+
78 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
79
80 %:
81 dh $@ --fail-missing
82+
83+override_dh_auto_configure:
84+ dh_auto_configure -- -DCMAKE_C_COMPILER=$(CC) -DCMAKE_CXX_COMPILER=$(CXX)

Subscribers

People subscribed via source and target branches