Merge lp:~thomas-voss/music-hub/wire-up-tracklist-to-player into lp:music-hub

Proposed by Thomas Voß
Status: Merged
Merged at revision: 9
Proposed branch: lp:~thomas-voss/music-hub/wire-up-tracklist-to-player
Merge into: lp:music-hub
Diff against target: 65 lines (+12/-2)
2 files modified
include/com/ubuntu/music/player.h (+4/-1)
src/com/ubuntu/music/player.cpp (+8/-1)
To merge this branch: bzr merge lp:~thomas-voss/music-hub/wire-up-tracklist-to-player
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
David Henningsson Pending
Review via email: mp+184501@code.launchpad.net

Commit message

Wire up tracklist to the player interface.

Description of the change

Wire up tracklist to the player interface.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Henningsson (diwic) wrote :

Looks good, merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/com/ubuntu/music/player.h'
2--- include/com/ubuntu/music/player.h 2013-09-03 18:53:18 +0000
3+++ include/com/ubuntu/music/player.h 2013-09-09 03:25:52 +0000
4@@ -19,7 +19,7 @@
5 #define COM_UBUNTU_MUSIC_PLAYER_H_
6
7 #include "com/ubuntu/music/connection.h"
8-#include "com/ubuntu/music/track_list.h"
9+#include "com/ubuntu/music/track.h"
10
11 #include <chrono>
12 #include <memory>
13@@ -31,6 +31,7 @@
14 namespace music
15 {
16 class Service;
17+class TrackList;
18
19 class Player
20 {
21@@ -58,6 +59,8 @@
22 Player& operator=(const Player&) = delete;
23 bool operator==(const Player&) const = delete;
24
25+ const std::shared_ptr<TrackList>& track_list() const;
26+
27 bool can_go_next();
28 void next();
29
30
31=== modified file 'src/com/ubuntu/music/player.cpp'
32--- src/com/ubuntu/music/player.cpp 2013-09-03 18:53:18 +0000
33+++ src/com/ubuntu/music/player.cpp 2013-09-09 03:25:52 +0000
34@@ -18,6 +18,7 @@
35
36 #include "com/ubuntu/music/player.h"
37 #include "com/ubuntu/music/service.h"
38+#include "com/ubuntu/music/track_list.h"
39
40 #include <limits>
41
42@@ -26,9 +27,10 @@
43 struct music::Player::Private
44 {
45 std::shared_ptr<Service> parent;
46+ std::shared_ptr<TrackList> track_list;
47 };
48
49-music::Player::Player(const std::shared_ptr<Service>& parent) : d(new Private{parent})
50+music::Player::Player(const std::shared_ptr<Service>& parent) : d(new Private{parent, std::make_shared<TrackList>()})
51 {
52 }
53
54@@ -36,6 +38,11 @@
55 {
56 }
57
58+const std::shared_ptr<music::TrackList>& music::Player::track_list() const
59+{
60+ return d->track_list;
61+}
62+
63 bool music::Player::can_go_next()
64 {
65 return true;

Subscribers

People subscribed via source and target branches