lp:~thomas-voss/media-hub/make-video-size-a-proper-type

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:media-hub at revision 115

PS Jenkins bot: Approve (continuous-integration) on 2015-03-12

Jim Hodapp (community): Needs Fixing (code) on 2014-12-01

Diff: 611 lines (+250/-66)

13 files modified

include/core/media/player.h (+3/-6)
include/core/media/video/dimensions.h (+145/-0)
src/core/media/codec.h (+44/-1)
src/core/media/engine.h (+1/-1)
src/core/media/gstreamer/engine.cpp (+6/-7)
src/core/media/gstreamer/engine.h (+1/-1)
src/core/media/gstreamer/playbin.h (+30/-32)
src/core/media/mpris/player.h (+5/-1)
src/core/media/player_implementation.cpp (+2/-5)
src/core/media/player_skeleton.cpp (+6/-5)
src/core/media/player_skeleton.h (+2/-2)
src/core/media/player_stub.cpp (+4/-4)
src/core/media/player_stub.h (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

107. By Thomas Voß on 2015-03-12

* debian/control:
  - Removing pre-depends that are not required
  - Bumping standards-version to 3.9.6
[ Ricardo Salveti de Araujo ]
* Migrating tests to use ogg instead of mp3/avi removed:
  tests/h264.avi tests/test.mp3 added: tests/test-audio-1.ogg
  tests/test-video.ogg tests/test.mp3 renamed: tests/test.ogg =>
  tests/test-audio.ogg

106. By Thomas Voß on 2015-01-29

Merge prereq branch.

105. By Thomas Voß on 2015-01-26

Merge prereq branch.

104. By Thomas Voß on 2015-01-26

[ Jim Hodapp ]
* Error reporting all the way up to the app level from the playbin
  pipeline.
[ Ubuntu daily release ]
* New rebuild forced
[ Jim Hodapp ]
* Don't auto-resume playback of videos after a phone call ends. (LP:
  #1411273)
[ Ubuntu daily release ]
* New rebuild forced
[ Ricardo Salveti de Araujo ]
* service_implementation: adding debug for call started/ended signals.
  Make sure account and connection are available when setting up
  account manager (patch from Gustavo Boiko). call_monitor: don't
  check caps when hooking up on/off signals, until bug 1409125 is
  fixed. Enable parallel building . (LP: #1409125)
[ Jim Hodapp ]
* Pause playback when recording begins. (LP: #1398047)
[ Ricardo Salveti de Araujo ]
* call_monitor.cpp: waiting for bridge to be up, and also protecting
  the on_change call (LP: #1408137)

103. By Thomas Voß on 2014-12-09

Address reviewer comments.

102. By Thomas Voß on 2014-12-09

[ Jim Hodapp ]
* Resubmitting with prerequisite branch (LP: #1331041)
[ Justin McPherson ]
* Resubmitting with prerequisite branch (LP: #1331041)

101. By Thomas Voß on 2014-11-26

Remerge prereq branch.

100. By Thomas Voß on 2014-11-26

Replace home-grown mask type for the video size with a std::tuple, i.e., media::video::Dimensions.
Introduce a simple TaggedInteger class to distinguish between Width, Height and other dimensions.
Adjust interfaces of media::Player to rely on the new type.
Adjust implementation classes to account for interface changes.
Adjust Codec implementation for sending the tagged integer via the bus.
Adjust gstreamer::Engine and gstreamer::Playbin to hand out the correct types.

99. By Thomas Voß on 2014-11-26

Refactor client-facing interfaces to pull out explicit dependency on hybris-based media layer.
Introduce interface media::video::Sink, and expose it in interfaces
Adjust implementation to account for interface changes.
Introduce an implementation of media::video::Sink relying on Hybris.

98. By PS Jenkins bot on 2014-11-20

Releasing 2.0.0+15.04.20141120.1-0ubuntu1