Merge lp:~thomas-voss/media-hub/explicit-gcc-version into lp:media-hub

Proposed by Thomas Voß
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp:~thomas-voss/media-hub/explicit-gcc-version
Merge into: lp:media-hub
Diff against target: 115 lines (+28/-8)
5 files modified
CMakeLists.txt (+2/-2)
debian/changelog (+6/-0)
debian/control (+9/-5)
debian/libmedia-hub-common1.symbols (+1/-1)
debian/rules (+10/-0)
To merge this branch: bzr merge lp:~thomas-voss/media-hub/explicit-gcc-version
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Colin Watson Approve
PS Jenkins bot continuous-integration Needs Fixing
Matthias Klose Pending
Review via email: mp+224758@code.launchpad.net

Commit message

Bump major revision and so name to account for toolchain update.

Description of the change

Bump major revision and so name to account for toolchain update.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Steve Langasek (vorlon) wrote :
review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-04-04 14:31:43 +0000
3+++ CMakeLists.txt 2014-06-27 08:08:27 +0000
4@@ -2,9 +2,9 @@
5
6 project(ubuntu-media-hub)
7
8-set(UBUNTU_MEDIA_HUB_VERSION_MAJOR 0)
9+set(UBUNTU_MEDIA_HUB_VERSION_MAJOR 1)
10 set(UBUNTU_MEDIA_HUB_VERSION_MINOR 0)
11-set(UBUNTU_MEDIA_HUB_VERSION_PATCH 1)
12+set(UBUNTU_MEDIA_HUB_VERSION_PATCH 0)
13
14 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wall -pedantic -Wextra -fPIC -pthread")
15 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Werror -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC -pthread")
16
17=== modified file 'debian/changelog'
18--- debian/changelog 2014-06-24 22:34:29 +0000
19+++ debian/changelog 2014-06-27 08:08:27 +0000
20@@ -1,3 +1,9 @@
21+media-hub (1.0.0) UNRELEASED; urgency=medium
22+
23+ * Bump major revision and so name to account for toolchain update.
24+
25+ -- Thomas Voß <thomas.voss@canonical.com> Fri, 27 Jun 2014 10:02:53 +0200
26+
27 media-hub (0.0.2+14.10.20140624.4-0ubuntu1) utopic; urgency=low
28
29 [ Alberto Aguirre ]
30
31=== modified file 'debian/control'
32--- debian/control 2014-05-06 18:48:44 +0000
33+++ debian/control 2014-06-27 08:08:27 +0000
34@@ -11,12 +11,16 @@
35 graphviz,
36 gstreamer1.0-plugins-good,
37 gstreamer1.0-fluendo-mp3,
38+# We rely on C++11 features, and to prevent from ABI breaks
39+# in libstdc++ causing us issues, we explicitly select a G++
40+# version.
41+ g++-4.9,
42 libboost-dev (>=1.53),
43 libboost-filesystem-dev (>=1.53),
44 libboost-program-options-dev (>=1.53),
45 libboost-system-dev (>=1.53),
46 libdbus-1-dev,
47- libdbus-cpp-dev (>= 3.0.0),
48+ libdbus-cpp-dev (>= 4.0.0),
49 libgoogle-glog-dev,
50 libhybris-dev (>=0.1.0+git20131207+e452e83-0ubuntu13),
51 libprocess-cpp-dev,
52@@ -35,8 +39,8 @@
53 Architecture: any
54 Multi-Arch: same
55 Pre-Depends: dpkg (>= 1.15.6~)
56-Depends: libmedia-hub-common0 (= ${binary:Version}),
57- libmedia-hub-client0 (= ${binary:Version}),
58+Depends: libmedia-hub-common1 (= ${binary:Version}),
59+ libmedia-hub-client1 (= ${binary:Version}),
60 ${misc:Depends},
61 libproperties-cpp-dev,
62 Suggests: libmedia-hub-doc
63@@ -58,7 +62,7 @@
64 .
65 This package contains the runtime.
66
67-Package: libmedia-hub-common0
68+Package: libmedia-hub-common1
69 Architecture: any
70 Multi-Arch: same
71 Pre-Depends: dpkg (>= 1.15.6~)
72@@ -70,7 +74,7 @@
73 .
74 This package contains the common libraries.
75
76-Package: libmedia-hub-client0
77+Package: libmedia-hub-client1
78 Architecture: any
79 Multi-Arch: same
80 Pre-Depends: dpkg (>= 1.15.6~)
81
82=== renamed file 'debian/libmedia-hub-client0.install' => 'debian/libmedia-hub-client1.install'
83=== renamed file 'debian/libmedia-hub-common0.install' => 'debian/libmedia-hub-common1.install'
84=== renamed file 'debian/libmedia-hub-common0.symbols' => 'debian/libmedia-hub-common1.symbols'
85--- debian/libmedia-hub-common0.symbols 2014-03-26 16:13:02 +0000
86+++ debian/libmedia-hub-common1.symbols 2014-06-27 08:08:27 +0000
87@@ -1,4 +1,4 @@
88-libmedia-hub-common.so.0 libmedia-hub-common0 #MINVER#
89+libmedia-hub-common.so.1 libmedia-hub-common1 #MINVER#
90 (c++)"the_session_bus()@Base" 0.0.1
91 (c++)"std::shared_ptr<core::dbus::Bus>::~shared_ptr()@Base" 0.0.1
92 (c++)"std::shared_ptr<core::dbus::Bus>::~shared_ptr()@Base" 0.0.1
93
94=== modified file 'debian/rules'
95--- debian/rules 2014-05-06 09:13:43 +0000
96+++ debian/rules 2014-06-27 08:08:27 +0000
97@@ -6,9 +6,19 @@
98
99 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
100
101+include /usr/share/dpkg/default.mk
102+
103+# Explicitly selecting a G{CC,++}-version here to avoid accidental
104+# ABI breaks introduced by toolchain updates.
105+export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
106+export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
107+
108 %:
109 dh $@ --fail-missing -- -B build
110
111+override_dh_auto_configure:
112+ dh_auto_configure -- -DCMAKE_C_COMPILER=$(CC) -DCMAKE_CXX_COMPILER=$(CXX)
113+
114 override_dh_auto_test:
115 env -u LD_PRELOAD dh_auto_test
116

Subscribers

People subscribed via source and target branches