Merge lp:~thomas-voss/location-service/remove-cell-aging-heuristics into lp:location-service/trunk

Proposed by Thomas Voß on 2016-05-25
Status: Needs review
Proposed branch: lp:~thomas-voss/location-service/remove-cell-aging-heuristics
Merge into: lp:location-service/trunk
Diff against target: 13 lines (+3/-1)
1 file modified
src/location_service/com/ubuntu/location/connectivity/cached_radio_cell.cpp (+3/-1)
To merge this branch: bzr merge lp:~thomas-voss/location-service/remove-cell-aging-heuristics
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team 2016-05-25 Pending
Review via email:

This proposal supersedes a proposal from 2016-03-02.

Commit message

Remove heuristic for aging out cell measurements.

Description of the change

Remove heuristic for aging out cell measurements.

To post a comment you must log in.

Unmerged revisions

216. By Thomas Voß on 2016-03-02

Remove heuristic for aging out cell measurements.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/location_service/com/ubuntu/location/connectivity/cached_radio_cell.cpp'
2--- src/location_service/com/ubuntu/location/connectivity/cached_radio_cell.cpp 2014-11-10 12:31:47 +0000
3+++ src/location_service/com/ubuntu/location/connectivity/cached_radio_cell.cpp 2016-05-25 14:35:11 +0000
4@@ -44,7 +44,9 @@
5 // maintain a database of problematic modem firmware in the
6 // future.
7 auto path = modem.object->path().as_string();
8- return path.find("ril") != std::string::npos;
9+ // We never age out cells, assuming that the modem does the right thing,
10+ // optimizing for situations in which only cell information is available.
11+ return false;
12 }
13 }


People subscribed via source and target branches