Merge lp:~thomas-voss/location-service/fix-test-for-ubx-provider into lp:location-service

Proposed by Thomas Voß
Status: Merged
Merged at revision: 306
Proposed branch: lp:~thomas-voss/location-service/fix-test-for-ubx-provider
Merge into: lp:location-service
Diff against target: 12 lines (+1/-1)
1 file modified
src/location/runtime_tests.cpp (+1/-1)
To merge this branch: bzr merge lp:~thomas-voss/location-service/fix-test-for-ubx-provider
Reviewer Review Type Date Requested Status
Simon Fels (community) Approve
Thomas Voß Pending
Review via email: mp+323738@code.launchpad.net

Commit message

Make sure that glib::Runtime is initialized with its own main loop for testing purposes.

Description of the change

Make sure that glib::Runtime is initialized with its own main loop for testing purposes.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/location/runtime_tests.cpp'
2--- src/location/runtime_tests.cpp 2017-05-04 19:16:26 +0000
3+++ src/location/runtime_tests.cpp 2017-05-08 08:51:06 +0000
4@@ -214,7 +214,7 @@
5 fix_received = false;
6 }
7
8- location::glib::Runtime runtime;
9+ location::glib::Runtime runtime{location::glib::Runtime::WithOwnMainLoop{}};
10 std::thread worker;
11 std::mutex guard;
12 std::condition_variable wait_condition;

Subscribers

People subscribed via source and target branches

to all changes: