Merge lp:~thomas-voss/location-service/fix-prompt-string into lp:location-service/trunk

[Thomas Voß]

Account for changes in trust-store w.r.t. assembling the description of a trust prompt.

Account for changes in trust-store w.r.t. assembling the description of a trust prompt.

Unmerged revisions

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-09-18 23:06:08 +0000
+++ CMakeLists.txt	2015-11-27 13:12:27 +0000
@@ -54,6 +54,20 @@
     SET (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=unused-local-typedefs")
 endif (DISABLE_ERROR_ON_LOCAL_TYPEDEFS_WARNINGS)
 
+#
+# Code style fixer. We rely on clang-format to adjust the formatting of source code.
+#
+find_program(CLANG_FORMAT_COMMAND NAMES clang-format-3.6 clang-format-3.5)
+if (NOT CLANG_FORMAT_COMMAND)
+  message(WARNING "Cannot find clang-format >= clang-format-3.5: formatcode target will not be available")
+endif()
+
+if (CLANG_FORMAT_COMMAND)
+  file(GLOB_RECURSE UBUNTU_LOCATION_SERVICE_INTERFACE_HEADER_FILES ${CMAKE_SOURCE_DIR}/include/*.h)
+  file(GLOB_RECURSE UBUNTU_LOCATION_SERVICE_IMPLEMENTATION_FILES ${CMAKE_SOURCE_DIR}/src/*.h ${CMAKE_SOURCE_DIR}/src/*.cpp)
+  add_custom_target(formatcode ${CLANG_FORMAT_COMMAND} -i ${UBUNTU_LOCATION_SERVICE_INTERFACE_HEADER_FILES} ${UBUNTU_LOCATION_SERVICE_IMPLEMENTATION_FILES} SOURCES _clang-format)
+endif()
+
 include_directories(
   ${Boost_INCLUDE_DIRS}
   ${DBUS_INCLUDE_DIRS}

=== added file '_clang-format'
--- _clang-format	1970-01-01 00:00:00 +0000
+++ _clang-format	2015-11-27 13:12:27 +0000
@@ -0,0 +1,56 @@
+---
+Language:        Cpp
+AccessModifierOffset: -4
+ConstructorInitializerIndentWidth: 4
+AlignEscapedNewlinesLeft: false
+AlignTrailingComments: true
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortBlocksOnASingleLine: false
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: All
+AlwaysBreakTemplateDeclarations: false
+AlwaysBreakBeforeMultilineStrings: false
+BreakBeforeBinaryOperators: false
+BreakBeforeTernaryOperators: true
+BreakConstructorInitializersBeforeComma: false
+BinPackParameters: true
+ColumnLimit: 0
+ConstructorInitializerAllOnOneLineOrOnePerLine: false
+DerivePointerAlignment: false
+ExperimentalAutoDetectBinPacking: false
+IndentCaseLabels: false
+IndentWrappedFunctionNames: false
+IndentFunctionDeclarationAfterType: false
+MaxEmptyLinesToKeep: 1
+KeepEmptyLinesAtTheStartOfBlocks: true
+NamespaceIndentation: None
+ObjCSpaceAfterProperty: false
+ObjCSpaceBeforeProtocolList: true
+PenaltyBreakBeforeFirstCallParameter: 19
+PenaltyBreakComment: 300
+PenaltyBreakString: 1000
+PenaltyBreakFirstLessLess: 120
+PenaltyExcessCharacter: 1000000
+PenaltyReturnTypeOnItsOwnLine: 60
+PointerAlignment: Left
+SpacesBeforeTrailingComments: 1
+Cpp11BracedListStyle: true
+Standard:        Cpp11
+IndentWidth:     4
+TabWidth:        8
+UseTab:          Never
+BreakBeforeBraces: Allman
+SpacesInParentheses: false
+SpacesInAngles:  false
+SpaceInEmptyParentheses: false
+SpacesInCStyleCastParentheses: false
+SpacesInContainerLiterals: true
+SpaceBeforeAssignmentOperators: true
+ContinuationIndentWidth: 4
+CommentPragmas:  '^ IWYU pragma:'
+ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH ]
+SpaceBeforeParens: ControlStatements
+DisableFormat:   false
+...
+

=== added file 'astyle-config'
--- astyle-config	1970-01-01 00:00:00 +0000
+++ astyle-config	2015-11-27 13:12:27 +0000
@@ -0,0 +1,43 @@
+# Options for formatting code with astyle.
+#
+# This helps to make code match the style guide.
+# 
+# Use like this:
+# 
+#     astyle --options=astyle-config mfile.h myfile.cpp
+# 
+# Occasionally, astyle does something silly (particularly with lambdas), so it's
+# still necessary to scan the changes for things that are wrong.
+# But, for most files, it does a good job.
+# 
+# Please consider using this before checking code in for review. Code reviews shouldn't
+# have to deal with layout issues, they are just a distraction. It's better to be able
+# to focus on semantics in a code review, with style issues out of the way.
+
+--formatted
+--style=allman
+--min-conditional-indent=2
+--indent-switches
+--max-instatement-indent=120
+--pad-header
+--align-pointer=type
+--align-reference=type
+--convert-tabs
+--close-templates
+--max-code-length=120
+
+# --pad-oper
+#
+# Commented out for now. It changes
+#
+#     for (int i=0; i<10; ++i)
+# to
+#     for (int i = 0; i < 10; ++i)
+#
+# Unfortunately, it also messes with rvalue references:
+#
+#     ResourcePtr& operator=(ResourcePtr&& r);
+#
+# becomes:
+#
+#     ResourcePtr& operator=(ResourcePtr && r);

=== modified file 'debian/changelog'
--- debian/changelog	2015-07-27 18:07:37 +0000
+++ debian/changelog	2015-11-27 13:12:27 +0000
@@ -1,3 +1,4 @@
+<<<<<<< TREE
 location-service (2.1+15.10.20150727-0ubuntu1) wily; urgency=medium
 
   [ CI Train Bot ]
@@ -36,6 +37,43 @@
 
  -- CI Train Bot <[e-mail]>  Thu, 28 May 2015 11:40:58 +0000
 
+=======
+location-service (2.1+15.04.20151113-0ubuntu1) vivid; urgency=medium
+
+  * Adjust default timeout for downloading GPS XTRA data.
+
+ -- Thomas Voß <[e-mail]>  Fri, 13 Nov 2015 10:33:56 +0000
+
+location-service (2.1+15.04.20151109.2-0ubuntu1) vivid; urgency=medium
+
+  [ Alberto Mardegan ]
+  * Make sure that injected time is given in milliseconds
+
+  [ Thomas Voß ]
+  * Cherry-pick rev. 196 and 199 from lp:location-service. The changes
+    got accidentally removed by merging the outstanding documentation
+    branch.
+  * Handle responses of clients to updates asynchronously. Rely on
+    dummy::ConnectivityManager as harvesting is disabled anyway. (LP:
+    #1462664, #1387643)
+
+ -- David Barth <[e-mail]>  Mon, 09 Nov 2015 20:48:48 +0000
+
+location-service (2.1+15.04.20151022-0ubuntu1) vivid; urgency=medium
+
+  [ Thomas Voß ]
+  * Add documentation for debugging, hacking and debugging the location
+    service. Pull manual testing instructions over from the wiki. Add
+    tools for formatting the source.
+
+  [ thomas-voss ]
+  * Add documentation for debugging, hacking and debugging the location
+    service. Pull manual testing instructions over from the wiki. Add
+    tools for formatting the source.
+
+ -- Thomas Voß <[e-mail]>  Thu, 22 Oct 2015 07:16:50 +0000
+
+>>>>>>> MERGE-SOURCE
 location-service (2.1+15.04.20150427.1-0ubuntu1) vivid; urgency=medium
 
   [ CI Train Bot ]

=== modified file 'doc/Doxyfile.in'
--- doc/Doxyfile.in	2014-05-19 09:55:25 +0000
+++ doc/Doxyfile.in	2015-11-27 13:12:27 +0000
@@ -748,7 +748,7 @@
 # directories that contain image that are included in the documentation (see
 # the \image command).
 
-IMAGE_PATH             =
+IMAGE_PATH             = @CMAKE_CURRENT_SOURCE_DIR@/images
 
 # The INPUT_FILTER tag can be used to specify a program that doxygen should
 # invoke to filter for each input file. Doxygen will invoke the filter program
@@ -1463,7 +1463,7 @@
 # generate an XML file that captures the structure of
 # the code including all documentation.
 
-GENERATE_XML           = NO
+GENERATE_XML           = YES
 
 # The XML_OUTPUT tag is used to specify where the XML pages will be put.
 # If a relative path is entered the value of OUTPUT_DIRECTORY will be

=== added file 'doc/daemon_and_cli.md'
--- doc/daemon_and_cli.md	1970-01-01 00:00:00 +0000
+++ doc/daemon_and_cli.md	2015-11-27 13:12:27 +0000
@@ -0,0 +1,55 @@
+# Service Daemon and CLI
+
+The location service offers a daemon executable and a corresponding
+command-line interface for interacting with it. The daemon does not
+necessarily require root privileges, but might so depending on your
+configuration.
+
+Run the following command to receive an overview of the arguments to
+the daemon:
+
+    ubuntu-location-serviced --help
+
+An example invocation of the daemon, configuring a GPS provider that
+relies on the Android HAL to talk to the chipset, exposing the service
+on the system DBus instance:
+
+    ubuntu-location-serviced --bus system --provider gps::Provider
+
+The cli allows for querying properties of a running service instance, e.g.:
+
+    ubuntu-location-serviced-cli --bus system --get --property is_online
+
+## Configuring an Out-Of-Process Provider
+
+If you want to run a provider out of process, the daemon executable
+allows you to do so by instantiating a so-called remote provider. The
+following invocation of the service tries to connect to the provider
+instance described by the given unique DBus name and path.
+
+    ubuntu-location-serviced \
+	  --bus system \
+	  --provider remote::Provider \
+          --remote::Provider::bus=system \
+	  --remote::Provider::name=com.ubuntu.location.provider.Gps \
+	  --remote::Provider::path=/
+
+Please note that the service allows for decorating provider names to
+uniquely identify per provider configuration options and to allow for
+loading more than one provider of a certain kind. The following
+configuration configures two remote providers, one relying on GPS
+(decorated with @gps) and another one relying on network-based
+positioning (decorated with @network):
+
+    ubuntu-location-serviced \
+	  --bus system \
+	  --provider remote::Provider@gps \
+          --remote::Provider@gps::bus=system \
+	  --remote::Provider@gps::name=com.ubuntu.location.provider.Gps \
+	  --remote::Provider@gps::path=/ \
+	  --provider remote::Provider@network \
+          --remote::Provider@network::bus=system \
+	  --remote::Provider@network::name=com.ubuntu.location.provider.Network \
+	  --remote::Provider@network::path=/
+
+    

=== added file 'doc/debugging.md'
--- doc/debugging.md	1970-01-01 00:00:00 +0000
+++ doc/debugging.md	2015-11-27 13:12:27 +0000
@@ -0,0 +1,92 @@
+# Debugging
+
+Location not working? Here's how to debug.
+
+## Layers
+
+Test in OSMTouch (QML app using Qt API) before testing in webapps or
+webbrowser app. Different results? File a bug where it doesn't
+work. Same result of no location? Next step.
+
+## Check that stack works with dummy provider
+
+Edit /etc/init/ubuntu-location-provider.override to start
+location-serviced with just the dummy provider; this should
+work. Doesn't work? File a bug against location-service. Works? Reset
+config to defaults and try the next thing.
+
+## Hardware GPS breaking all of location-service
+
+GPS provider is built-in into location-service and might break all of
+it if it goes south (working on splitting it out); try enabling only
+the HERE provider on the location-serviced command-line and see if
+that works. Works? File a bug against location-service. Doesn't work?
+Move on.
+
+## HERE test
+
+To test whether the low-level HERE stack gets a location, put
+http://people.canonical.com/~lool/espoo-cli on your phone (will be
+included along HERE bits in the future) and run with:
+
+    chmod a+x espoo-cli
+    GLOG_logtostderr=1 GLOG_v=100 LD_LIBRARY_PATH=/custom/vendor/here/location-provider/lib/arm-linux-gnueabihf ./espoo-cli 5
+
+NB: 5 is the number of location updates after which the tool exits;
+updates should come in at approx 15s interval. Output looks like:
+
+    I1101 21:30:01.285964 4403 cli.cpp:117] Requested number of updates is 2
+    I1101 21:30:01.299002 4403 cli.cpp:133] Starting location updates
+    I1101 21:30:01.301888 4403 cli.cpp:141] Starting GLib main loop
+    I1101 21:30:11.304612 4403 cli.cpp:158] Location: tstamp=1414891811 lat=xyz long=foo hor. acc.=2569 alt=nan vert. acc.=nan tech=cell
+    I1101 21:30:11.306061 4403 cli.cpp:170] Remaining updates: 1
+    I1101 21:30:26.736821 4403 cli.cpp:158] Location: tstamp=1414891826 lat=xyz long=foo hor. acc.=2824 alt=nan vert. acc.=nan tech=cell
+    I1101 21:30:26.738348 4403 cli.cpp:148] Stopping location updates
+
+Low-level HERE stack works but location-serviced with just HERE
+provider doesn't work? File a bug against espoo projet (HERE) and/or
+location-service. Low-level HERE stack doesn't work? Move on
+
+## location-service and espoo-service debug
+
+Collect some debug data by editing /etc/init/ubuntu-espoo-service.conf
+and /etc/init/ubuntu-location-service.override and changing the start
+sequence to add some env vars:
+
+    export GLOG_v=200
+    export GLOG_logtostderr=1
+
+before the exec. Reboot, and start some app. You should have some log
+files under /var/log/upstart/ubuntu-espoo-service.log and
+/var/log/upstart/ubuntu-location-service.log to attach to a bug
+report; e.g. a working espoo log looks like this:
+
+    WARNING: Logging before InitGoogleLogging() is written to STDERR
+    I1105 16:30:10.221474  1620 provider.cpp:568] StartPositionUpdates
+    I1105 16:30:10.224901  1620 provider.cpp:122] Successfully started position updates.
+    I1105 16:30:10.228739  1620 provider.cpp:596] StartVelocityUpdates
+    I1105 16:30:13.046851  1621 provider.cpp:83] Received location: Position(lat: Coordinate(12.34 deg), lon: Coordinate(12.34 deg), alt: Coordinate(nan m), hor.acc.: 1430 m, ver.acc.: nan m)
+
+No position there? check connectivity API works by running:
+
+    cd /tmp
+    wget http://people.ubuntu.com/~lool/connectivity
+    GLOG_v=200 GLOG_logtostderr=1 ./connectivity
+
+you should see something like:
+
+    I1105 16:47:26.431466 11140 cached_radio_cell.cpp:160] (mcc: 123, mnc: 2, lac: 1234, id: 123456, asu: 1)
+    I1105 16:47:26.533818 11140 connectivity.cpp:47] Is wifi enabled: true
+    I1105 16:47:26.533963 11140 connectivity.cpp:48] Is wifi hw enabled: true
+    I1105 16:47:26.534010 11140 connectivity.cpp:49] Is wwan enabled: true
+    I1105 16:47:26.534050 11140 connectivity.cpp:50] Is wwan hw enabled: true
+    I1105 16:47:26.534442 11140 connectivity.cpp:122] umts(mcc: 123, mnc: 2, lac: 1234, id: 123456, asu: 1)
+    I1105 16:47:26.534633 11140 connectivity.cpp:155] (bssid: 12:12:12:12:12:12, ssid: xyz, last seen: 1415224046, mode: Mode::infrastructure, frequency: 2442, strength: 63)
+    I1105 16:47:26.534828 11140 connectivity.cpp:155] (bssid: 12:12:12:12:12:12, ssid: boing, last seen: 1415224046, mode: Mode::infrastructure, frequency: 2467, strength: 57)
+
+Also, please attach output of /usr/share/ofono/scripts/list-modems > list-modems-output.txt
+Please note that the command might take ~1 minute to complete.
+
+TODO: document dbus-monitor / d-feet capturing of client / system traffic with snooping config.
+
+

=== added file 'doc/hacking.md'
--- doc/hacking.md	1970-01-01 00:00:00 +0000
+++ doc/hacking.md	2015-11-27 13:12:27 +0000
@@ -0,0 +1,146 @@
+# Hacking
+
+
+## Building the code
+
+By default, the code is built in release mode. To build a debug version, use
+
+    $ mkdir builddebug
+    $ cd builddebug
+    $ cmake -DCMAKE_BUILD_TYPE=debug ..
+    $ make
+
+For a release version, use -DCMAKE_BUILD_TYPE=release
+
+## Running the tests
+
+    $ make
+    $ make test
+
+Note that "make test" alone is dangerous because it does not rebuild
+any tests if either the library or the test files themselves need
+rebuilding. It's not possible to fix this with cmake because cmake cannot
+add build dependencies to built-in targets. To make sure that everything
+is up-to-date, run "make" before running "make test"!
+
+## Coverage
+
+To build with the flags for coverage testing enabled and get coverage:
+
+    $ mkdir buildcoverage
+    $ cd buildcoverage
+    $ cmake -DCMAKE_BUILD_TYPE=coverage
+    $ make
+    $ make test
+    $ make coverage
+
+Unfortunately, it is not possible to get 100% coverage for some files,
+mainly due to gcc's generation of two destructors for dynamic and non-
+dynamic instances. For abstract base classes and for classes that
+prevent stack and static allocation, this causes one of the destructors
+to be reported as uncovered.
+
+There are also issues with some functions in header files that are
+incorrectly reported as uncovered due to inlining, as well as
+the impossibility of covering defensive assert(false) statements,
+such as an assert in the default branch of a switch, where the
+switch is meant to handle all possible cases explicitly.
+
+If you run a binary and get lots of warnings about a "merge mismatch for summaries",
+this is caused by having made changes to the source that add or remove code
+that was previously run, so the new coverage output cannot sensibly be merged
+into the old coverage output. You can get rid of this problem by running
+
+    $ make clean-coverage
+
+This deletes all the .gcda files, allowing the merge to (sometimes) succeed again.
+If this doesn't work either, the only remedy is to do a clean build.
+
+If lcov complains about unrecognized lines involving '=====',
+you can patch geninfo and gcovr as explained here:
+
+https://bugs.launchpad.net/gcovr/+bug/1086695/comments/2
+
+## Code style
+
+We use a format tool that fixes a whole lot of issues
+regarding code style. The formatting changes made by
+the tool are generally sensible (even though they may not be your
+personal preference in all cases). If there is a case where the formatting
+really messes things up, consider re-arranging the code to avoid the problem.
+The convenience of running the entire code base through the pretty-printer
+far outweighs any minor glitches with pretty printing, and it means that
+we get consistent code style for free, rather than endlessly having to
+watch out for formatting issues during code reviews.
+
+As of clang-format-3.7, you can use
+
+    // clang-format off
+    void    unformatted_code  ;
+    // clang-format on
+
+to suppress formatting for a section of code.
+
+To format specific files:
+
+    ${CMAKE_BINARY_DIR}/tools/formatcode x.cpp x.h
+
+If no arguments are provided, formatcode reads stdin and writes
+stdout, so you can easily pipe code into the tool from within an
+editor. For example, to reformat the entire file in vi (assuming
+${CMAKE_BINARY_DIR}/tools is in your PATH):
+
+    1G!Gformatcode
+
+To re-format all source and header files in the tree:
+
+    $ make formatcode
+
+## Thread and address sanitizer
+
+Set SANITIZER to "thread" or "address" to build with the
+corresponding sanitizer enabled.
+
+## Updating symbols file
+
+To easily spot new/removed/changed symbols in the library, the debian
+package maintains a .symbols file that lists all exported symbols
+present in the library .so. If you add new public symbols to the library,
+it's necessary to refresh the symbols file, otherwise the package will
+fail to build. The easiest way to do that is using bzr-builddeb:
+
+    $ bzr bd -- -us -uc -j8  # Don't sign source package or changes file, 8 compiles in parallel
+    $ # this will exit with an error if symbols file isn't up-to-date
+    $ cd ../build-area/location-service-[version]
+    $ ./obj-[arch]/tools/symbol_diff
+
+This creates a diff of the symbols in /tmp/symbols.diff.
+(The demangled symbols from the debian build are in ./new_symbols.)
+
+Review any changes in /tmp/symbols.diff. If they are OK:
+
+    $ cd -
+    $ patch -p0 < /tmp/symbols.diff
+
+## ABI compliance test
+
+To use this, install abi-compliance-checker package from the archives.
+
+You can use abi-compliance-checker to test whether a particular build
+is ABI compatible with another build. The tool does some source-level
+analysis in addition to checking library symbols, so it catches things
+that are potentially dangerous, but won't be picked up by just looking
+at the symbol table.
+
+Assume you have built devel in src/devel, and you have a later build
+in src/mybranch and want to check that mybranch is still compatible.
+To run the compliance test:
+
+    $ cd src
+    $ abi-compliance-checker -lib libunity-scopes.so -old devel/build/test/abi-compliance/abi.xml -new mybranch/build/test/abi-compliance/abi.xml
+
+The script will take about two minutes to run. Now point your browser at 
+
+    src/compat_reports/libunity-scopes.so/[version]_to_[version]/compat_report.html
+
+The report provides a nicely layed-out page with all the details.

=== added directory 'doc/images'
=== added file 'doc/images/LocationServiceHighLevel.png'
Binary files doc/images/LocationServiceHighLevel.png	1970-01-01 00:00:00 +0000 and doc/images/LocationServiceHighLevel.png	2015-11-27 13:12:27 +0000 differ
=== added file 'doc/intro.md'
--- doc/intro.md	1970-01-01 00:00:00 +0000
+++ doc/intro.md	2015-11-27 13:12:27 +0000
@@ -0,0 +1,67 @@
+# Introduction               {#mainpage}
+
+Ubuntu's location service is a central hub for multiplexing access to
+positioning subsystems available via hard- and software. It provides a
+client API offering positioning capabilities to applications and other
+system components, abstracting away the details of individual
+positioning solutions.
+
+## Vocabulary
+
+To make the remainder of this documentation as easily understandable
+as possible, we start over with introducing some vocabulary:
+
+- Engine: 
+    Responsible for handling input from multiple positioning
+    subsystems and maintaining the state of the overall system. Think
+    about it like the heart of the system.
+
+- Provider: 
+    A positioning subsystem that feeds into the positioning
+    engine. Common examples are a GPS provider or a network-based
+    positioning provider.
+
+- Service:
+    The point of entry for applications and services that would
+    like to receive position data.
+
+- Session:
+    In order to receive position information, every application
+    or service has to create a session with the location Service.
+
+- Update: An update is a timestamped entity to a certain type of data.
+
+- [WGS84, http://en.wikipedia.org/wiki/World_Geodetic_System]: The coordinate system that is used throughout the entire location subsystem.
+
+## Architectural Overview
+
+The high-level architecture of the service is shown in the following diagram:
+
+![High-level architectural overview](images/LocationServiceHighLevel.png)
+
+In this diagram, the configuration of the engine refers to:
+
+  * The current state of any satellite-based positioning subsystems. Can either be off or on.
+  * The current state of reporting facilities responsible for harvesting wifi and cell id measurements together with location information and sending them off to remote services. Can either be off or on.
+  * The overall state of the engine. Can either be off, on or active.
+
+The Service takes this configuration and exposes it to client
+applications. In addition, mainly for debugging purposes, the set of
+currently visible satellites (if any) is maintained and exposed to
+privileged client applications.
+
+## Privacy & Access Control
+
+Location information is highly privacy relevant. For this reason, the
+location service is deeply integrated with AppArmor and Ubuntu's
+overall trust infrastructure. Every incoming session request is
+validated and if in doubt, the user is asked to explicitly grant trust
+to the application requesting access to positioning
+information. Please see [@ref com::ubuntu::location::service::PermissionManager]
+for further details.
+
+In addition, the location service allows for selectively adjusting the
+accuracy and reporting setup of the location Engine to provide further
+fine-grained control over the exposed data to user. Within this setup,
+a user is able to entirely disable all positioning.
+

=== added file 'doc/manual_testing.md'
--- doc/manual_testing.md	1970-01-01 00:00:00 +0000
+++ doc/manual_testing.md	2015-11-27 13:12:27 +0000
@@ -0,0 +1,174 @@
+# Manual Testplan
+
+[TOC]
+
+While the automatic test suite of the location service is
+comprehensive and covers large parts of the functionality of the
+service itself, we still provide an additional level of acceptance
+testing covering the entire location stack/experience as a part of
+this document.
+
+## Dependents/Clients
+
+ - qtubuntu-sensors
+ - Qt/QML applications:
+   - Browser
+   - osmTouch
+
+## Test Plan
+
+This test plan is not supposed to be complete; use it to guide your
+manual testing so you don't miss big functional areas that are part of
+the component; also this should be used as guideline to inspire the
+exploratory testing which should be adapted smartly based on the real
+content of a MP.
+
+Please note that if you're testing the GPS provider, the location
+service relies on GPS hardware to obtain a location fix. For that, it
+might be required that you execute the manual steps listed before
+close to a window or ideally outside, with good satellite visibility
+conditions.
+
+__Note: It can take up to 15 minutes for the GPS device to get a lock, due to lack of assisted GPS__
+
+ - Install latest image on phone
+ - Install freshly built MPs that are needed for landing
+
+Depending on the default configuration of location-service on the
+image, you may skip parts of this test plan. E.g. if GPS hardware is
+disabled, skip this part. You can see which providers are enabled by
+looking at the list of providers on the location-serviced command-line
+(`ps fauxw | grep location-service`, then look at the `--provider`
+flags).
+
+### Dummy provider
+
+This tests forces location-service to use only the dummy provider;
+this providers a baseline test for the app to trust-store to
+location-service path.
+
+ - phablet-shell into the phone:
+   - `sudo service ubuntu-location-service stop && sudo /usr/bin/ubuntu-location-serviced --bus system --provider dummy::Provider --dummy::Provider::ReferenceLocationLat=48.857503 --dummy::Provider::ReferenceLocationLon=2.295072`
+ - As phablet, start the trust store again (it stops when location-service is stopped) with: `start ubuntu-location-service-trust-stored`
+ - Ensure that all AP tests for the webbrowser pass as expected
+ - Point the browser to maps.google.com (alternatively: here.com, maps.bing.fr).
+ - Request centering the map on current position and observe if it works correctly (should show the Eiffel tower)
+ - Install osmTouch from the app store
+ - Launch osmTouch and check if it centers on the Eiffel tower.
+ - Install a maps webapp such as HERE or Google Maps webapp from the app store
+ - Launch maps webapp and check if it centers on the Eiffel tower.
+
+### GPS Test Plan
+
+This applies only if GPS provider is enabled.
+
+ - (If applicable: Remember to add the silo you are testing)
+ - `sudo apt-get install ubuntu-location-service-tests`
+ - If you want to send off crowdsourced information, i.e., information about visible wifis and visible radio cells for the obtained location fixes to Mozilla's location service and our own instance: 
+   - `sudo GLOG_v=40 GLOG_logtostderr=1 GPS_TEST_ENABLE_HARVESTING_DURING_TESTS=1  /usr/bin/uls-tests/gps_provider_test --gtest_filter=*.time_to_first_fix_cold_start_without_supl_benchmark_requires_hardware`
+ - If you '''don't''' want to send off crowdsourced information:
+   - `sudo GLOG_v=40 GLOG_logtostderr=1 /usr/bin/uls-tests/gps_provider_test --gtest_filter=*.time_to_first_fix_cold_start_without_supl_benchmark_requires_hardware`
+
+ - The test will output a lot of diagnostic information to the
+   terminal and will take ~30 minutes. If satellite visibility is
+   limited, it can take even longer. The test will automatically
+   report success or failure.
+
+### Preliminary AGPS Test Plan
+
+**Does not apply to Krillin**
+
+Please note that the Krillin GPS chipset driver and its integration
+within Ubuntu does not support vanilla AGPS (i.e., SUPL) right
+now. For that, this test case is irrelevant for Krillin and is likely
+to fail.
+
+This applied only if GPS provider and some other provider (giving
+_A_ssistance) are enabled.
+
+ - Add the silo.
+ - `sudo apt-get install ubuntu-location-service-tests`
+ - Obtain a (rough) location estimate for your current location on Google maps.
+ - Make sure to replace INSERT_ESTIMATE_HERE with the respective
+   values obtained from Google maps.
+ - If you want to send off crowdsourced information, i.e., information
+   about visible wifis and visible radio cells for the obtained
+   location fixes to Mozilla's location service and our own instance:
+   - `sudo GLOG_v=40 GLOG_logtostderr=1 GPS_TEST_ENABLE_HARVESTING_DURING_TESTS=1  GPS_TEST_REF_LAT=INSERT_ESTIMATE_HERE GPS_TEST_REF_LON=INSERT_ESTIMATE_HERE /usr/bin/uls-tests/gps_provider_test --gtest_filter=*.time_to_first_fix_cold_start_with_supl_benchmark_requires_hardware`
+ - If you '''don't''' want to send off crowdsourced information:
+   - `sudo GLOG_v=40 GLOG_logtostderr=1 GPS_TEST_REF_LAT=INSERT_ESTIMATE_HERE GPS_TEST_REF_LON=INSERT_ESTIMATE_HERE /usr/bin/uls-tests/gps_provider_test --gtest_filter=*.time_to_first_fix_cold_start_with_supl_benchmark_requires_hardware`
+
+ - The test will output a lot of diagnostic information to the
+   terminal and will take ~10 minutes or less. The test will
+   automatically report success or failure.
+
+### Espoo / HERE provider
+
+This applies only if the Espoo / HERE remote provider is enabled. This
+provider should be enabled by default and may either work standalone
+as the only provider or as an assistance for the GPS hardware to lock.
+
+ - Add the silo; special exception for lxc-android-config: see https://wiki.ubuntu.com/Touch/Testing/lxc-android-config
+ - If noted, deploy an updated custom tarball:
+   - Download the tarball under /tmp ('''NOT''' under /)
+   - Unpack there: `cd /tmp; sudo tar xvf custom-vendor-here-*.tar.xz`
+   - Remove older bits: `sudo rm -rf /custom/vendor/here/`
+   - Update custom bits: `sudo mv /tmp/system/custom/vendor/here /custom/vendor`
+ - Reboot
+ - After boot, check you have these three processes running on top of location-service:
+   - slpgwd
+   - posclientd
+   - ubuntu-espoo-service
+ - Make sure SIM is unlocked and attached to the network (has some reliable signal) and that WiFi is turned on.
+ - Install OSMTouch app
+ - Run OSMTouch app, hit the position button every other second until you get a blue circle showing your current location; 
+
+# Connectivity API
+
+For integration of network-based positioning providers, the location
+service offers a connectivity API that provides access to wifi and
+cell measurements as well as information on the current overall
+connectivity status of the device. Please execute the following
+commands on a newly flashed device with a writable image:
+
+  - `sudo apt-get update && sudo apt-get build-dep location-service && sudo apt-get install libubuntu-location-service-dev ubuntu-location-service-examples`
+  - `mkdir /tmp/build && cd /tmp/build && cmake /usr/share/ubuntu-location-service/examples/standalone/connectivity/ && make`
+  - `GLOG_logtostderr=1 ./connectivity`
+
+Verify that the output looks similar to:
+
+    phablet@ubuntu-phablet:/tmp/build$ ./connectivity 
+    Is wifi enabled: true
+    Is wifi hw enabled: true
+    Is wwan enabled: false
+    Is wwan hw enabled: true
+    umts(mcc: 262, mnc: 2, lac: 5313, id: 131948771, asu: 7)
+    (bssid: BC:F2:AF:AF:19:A2, ssid: devolo-bcf2afaf19a2, last seen: 1408955086, mode: Mode::infrastructure, frequency: 2462, strength: 72)
+    (bssid: 00:22:3F:35:43:58, ssid: JustAnotherWLAN, last seen: 1408955086, mode: Mode::infrastructure, frequency: 2412, strength: 24)
+    (bssid: 82:C7:A6:40:8C:4E, ssid: EasyBox-44D054, last seen: 1408955206, mode: Mode::infrastructure, frequency: 2417, strength: 17)
+    (bssid: 00:24:01:B8:32:8D, ssid: gra, last seen: 1408955086, mode: Mode::infrastructure, frequency: 2412, strength: 12)
+    (bssid: C0:25:06:3C:28:22, ssid: FRITZ!Box 6360 Cable, last seen: 1408954966, mode: Mode::infrastructure, frequency: 2412, strength: 17)
+    (bssid: 00:1C:4A:A5:B7:59, ssid: FRITZ!Box Fon WLAN 7170, last seen: 1408954966, mode: Mode::infrastructure, frequency: 2437, strength: 10)
+    Last seen changed for wifi (bssid: BC:F2:AF:AF:19:A2, ssid: devolo-bcf2afaf19a2, last seen: 1408955257, mode: Mode::infrastructure, frequency: 2462, strength: 72)
+    Last seen changed for wifi (bssid: 00:22:3F:35:43:58, ssid: JustAnotherWLAN, last seen: 1408955257, mode: Mode::infrastructure, frequency: 2412, strength: 24)
+    Signal strength changed for wifi: (bssid: BC:F2:AF:AF:19:A2, ssid: devolo-bcf2afaf19a2, last seen: 1408955257, mode: Mode::infrastructure, frequency: 2462, strength: 73)
+
+# Trust Store Integration
+
+Please note that we are assuming a freshly wiped system for testing
+here. If you cannot fulfill that pre-condition, please run `rm -rf
+/home/phablet/.local/share/UbuntuLocationService && sudo shutdown -r` prior to running the
+tests:
+
+## Unconfined
+
+ - Open the browser, go to maps.google.com
+ - Observe the in-browser dialog asking for granting access to location.
+
+## Confined Web-App
+ 
+ - Open the Nokia Here web app, observe the trust dialog appearing.
+
+## Confined Application
+
+ - Open osmtouch and observe the osmtouch surface sliding up, presenting you with a trust dialog.

=== added file 'doc/tips_n_tricks.md'
--- doc/tips_n_tricks.md	1970-01-01 00:00:00 +0000
+++ doc/tips_n_tricks.md	2015-11-27 13:12:27 +0000
@@ -0,0 +1,21 @@
+# Tips'n'Tricks
+
+## Mark HERE license as accepted from cmdline
+
+    sudo LC_ALL=C gdbus call --system --dest org.freedesktop.Accounts --object-path /org/freedesktop/Accounts/User32011 --method org.freedesktop.DBus.Properties.Set com.ubuntu.location.providers.here.AccountsService LicenseAccepted '<true>'
+
+## Force startup after ofono and NM are started
+
+This is a *workaround* to get connectivity API to collect; mount your
+system read-write and edit
+/etc/init/ubuntu-location-provider-here-slpgwd.conf:
+
+    sudo mount -o remount,rw /
+    sudo vi /etc/init/ubuntu-location-provider-here-slpgwd.conf
+
+change: `start on started dbus and (started ofono or started network-manager)`
+to: `start on started dbus and started ofono and started network-manager`
+
+    sudo mount -o remount,ro /
+    sync
+    sudo reboot

=== modified file 'po/ubuntu-location-service.pot'
--- po/ubuntu-location-service.pot	2014-09-19 09:06:30 +0000
+++ po/ubuntu-location-service.pot	2015-11-27 13:12:27 +0000
@@ -1,13 +1,14 @@
-# Copyright (C) 2014 Canonical Ltd.
-# This file is distributed under the same license as the ubuntu-location-service package.
-# Thomas Voß <[e-mail]>, 2014.
+# SOME DESCRIPTIVE TITLE.
+# Copyright (C) YEAR Canonical Ltd.
+# This file is distributed under the same license as the PACKAGE package.
+# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
 #
 #, fuzzy
 msgid ""
 msgstr ""
 "Project-Id-Version: ubuntu-location-service\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2014-09-19 01:04+0200\n"
+"POT-Creation-Date: 2015-11-27 14:07+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -16,11 +17,6 @@
 "Content-Type: text/plain; charset=CHARSET\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-#: /tmp/i18n/src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp:170
-msgid "An unconfined application wants to access your current location."
-msgstr ""
-
-#: /tmp/i18n/src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp:173
-#, boost-format
-msgid "%1% wants to access your current location."
+#: /home/tvoss/ubuntu/scratch/fix-prompt-string/src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp:149
+msgid "wants to access your current location."
 msgstr ""

=== modified file 'src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp'
--- src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp	2014-10-27 21:58:16 +0000
+++ src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp	2015-11-27 13:12:27 +0000
@@ -66,8 +66,6 @@
     if (config.count("XTRA_SERVER_3") > 0)
         result.xtra_hosts.push_back(config.get<std::string>("XTRA_SERVER_3"));
 
-    result.timeout = std::chrono::milliseconds{1500};
-
     return result;
 }
 
@@ -333,14 +331,14 @@
     } else
     {
         auto now = location::Clock::now().time_since_epoch();
-        auto thiz = static_cast<android::HardwareAbstractionLayer*>(context);
+        auto ms_since_epoch = std::chrono::duration_cast<std::chrono::milliseconds>(now);
 
         static const int zero_uncertainty = 0;
 
         u_hardware_gps_inject_time(
                     thiz->impl.gps_handle,
-                    now.count(),
-                    now.count(),
+                    ms_since_epoch.count(),
+                    ms_since_epoch.count(),
                     zero_uncertainty);
     }
 }

=== modified file 'src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h'
--- src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h	2015-04-22 13:30:04 +0000
+++ src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h	2015-11-27 13:12:27 +0000
@@ -49,7 +49,7 @@
         /** @brief Timeout on gps xtra download operations. */
         std::chrono::milliseconds timeout
         {
-            5000
+            30000
         };
 
         /** Set of hosts serving GPS xtra data. */

=== modified file 'src/location_service/com/ubuntu/location/service/daemon.cpp'
--- src/location_service/com/ubuntu/location/service/daemon.cpp	2015-04-16 10:03:29 +0000
+++ src/location_service/com/ubuntu/location/service/daemon.cpp	2015-11-27 13:12:27 +0000
@@ -20,6 +20,8 @@
 #include <com/ubuntu/location/boost_ptree_settings.h>
 #include <com/ubuntu/location/provider_factory.h>
 
+#include <com/ubuntu/location/connectivity/dummy_connectivity_manager.h>
+
 #include <com/ubuntu/location/service/default_configuration.h>
 #include <com/ubuntu/location/service/demultiplexing_reporter.h>
 #include <com/ubuntu/location/service/ichnaea_reporter.h>
@@ -214,29 +216,8 @@
         dc.the_permission_manager(config.outgoing),
         location::service::Harvester::Configuration
         {
-            location::connectivity::platform_default_manager(),
-            // We submit location/wifi/cell measurements to both
-            // Mozilla's location service and to Ubuntu's own instance.
-            std::make_shared<service::DemultiplexingReporter>(
-            std::initializer_list<service::Harvester::Reporter::Ptr>
-            {
-                std::make_shared<service::ichnaea::Reporter>(
-                     service::ichnaea::Reporter::Configuration
-                     {
-                         "https://location.services.mozilla.com",
-                         "UbuntuLocationService",
-                         "UbuntuLocationService"
-                     }
-                ),
-                std::make_shared<service::ichnaea::Reporter>(
-                     service::ichnaea::Reporter::Configuration
-                     {
-                         "https://162.213.35.107",
-                         "UbuntuLocationService",
-                         "UbuntuLocationService"
-                     }
-                )
-            })
+            std::make_shared<dummy::ConnectivityManager>(),
+            std::make_shared<NullReporter>()
         }
     };
 

=== modified file 'src/location_service/com/ubuntu/location/service/session/skeleton.cpp'
--- src/location_service/com/ubuntu/location/service/session/skeleton.cpp	2014-08-14 20:31:09 +0000
+++ src/location_service/com/ubuntu/location/service/session/skeleton.cpp	2015-11-27 13:12:27 +0000
@@ -283,7 +283,13 @@
     VLOG(10) << __PRETTY_FUNCTION__;
     try
     {
-        configuration.remote.object->invoke_method_asynchronously<culs::session::Interface::UpdatePosition, void>(position);
+        configuration.remote.object->invoke_method_asynchronously_with_callback<culs::session::Interface::UpdatePosition, void>([](const core::dbus::Result<void>& result)
+        {
+            if (result.is_error())
+            {
+                LOG(INFO) << "Failed to communicate position update to client: " << result.error().print();    
+            }
+        }, position);
     } catch(const std::exception&)
     {
         // We consider the session to be dead once we hit an exception here.
@@ -300,7 +306,13 @@
     VLOG(10) << __PRETTY_FUNCTION__;
     try
     {
-        configuration.remote.object->invoke_method_asynchronously<culs::session::Interface::UpdateHeading, void>(heading);
+        configuration.remote.object->invoke_method_asynchronously_with_callback<culs::session::Interface::UpdateHeading, void>([](const core::dbus::Result<void>& result)
+        {
+            if (result.is_error())
+            {
+                LOG(INFO) << "Failed to communicate position update to client: " << result.error().print();    
+            }
+        }, heading);
     } catch(const std::exception&)
     {
         // We consider the session to be dead once we hit an exception here.
@@ -317,7 +329,13 @@
     VLOG(10) << __PRETTY_FUNCTION__;
     try
     {
-        configuration.remote.object->invoke_method_asynchronously<culs::session::Interface::UpdateVelocity, void>(velocity);
+        configuration.remote.object->invoke_method_asynchronously_with_callback<culs::session::Interface::UpdateVelocity, void>([](const core::dbus::Result<void>& result)
+        {
+            if (result.is_error())
+            {
+                LOG(INFO) << "Failed to communicate position update to client: " << result.error().print();    
+            }
+        }, velocity);
     } catch(const std::exception&)
     {
         // We consider the session to be dead once we hit an exception here.

=== modified file 'src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp'
--- src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp	2014-09-19 14:36:51 +0000
+++ src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp	2015-11-27 13:12:27 +0000
@@ -146,7 +146,7 @@
         return service::PermissionManager::Result::rejected;
     }
 
-    std::string description = i18n::tr("%1% wants to access your current location.");
+    std::string description = i18n::tr("wants to access your current location.");
 
     core::trust::Agent::RequestParameters params
     {

=== modified file 'tests/gps_provider_test.cpp'
--- tests/gps_provider_test.cpp	2015-01-12 08:41:14 +0000
+++ tests/gps_provider_test.cpp	2015-11-27 13:12:27 +0000
@@ -48,6 +48,31 @@
 
 namespace
 {
+
+struct MockHardwareGps
+{
+    MockHardwareGps()
+    {
+        instance_ = this;
+    }
+    ~MockHardwareGps()
+    {
+        instance_ = nullptr;
+    }
+
+    MOCK_METHOD5(set_position_mode, bool(uint32_t, uint32_t, uint32_t, uint32_t, uint32_t));
+    MOCK_METHOD3(inject_time, void(int64_t, int64_t, int));
+
+    static MockHardwareGps *mocked(UHardwareGps self) {
+        return reinterpret_cast<MockHardwareGps*>(self);
+    }
+    static MockHardwareGps *instance() { return instance_; }
+
+    static MockHardwareGps *instance_;
+};
+
+MockHardwareGps *MockHardwareGps::instance_ = nullptr;
+
 struct UpdateTrap
 {
     MOCK_METHOD1(on_position_updated, void(const location::Position&));
@@ -211,6 +236,42 @@
 
 }
 
+/* Mock the hardware GPS platform API: the methods defined here will be invoked
+ * instead of those exported by the system library.
+ * We redefine these methods using the MockHardwareGps class above, which is
+ * implemented using google-mock. This effectively allows us to test that the
+ * right calls to the platform API are made.
+ */
+UHardwareGps
+u_hardware_gps_new(UHardwareGpsParams *)
+{
+    using namespace ::testing;
+
+    return reinterpret_cast<UHardwareGps>(MockHardwareGps::instance());
+}
+
+void
+u_hardware_gps_delete(UHardwareGps)
+{
+}
+
+bool
+u_hardware_gps_set_position_mode(UHardwareGps self, uint32_t mode, uint32_t recurrence,
+                                 uint32_t min_interval, uint32_t preferred_accuracy,
+                                 uint32_t preferred_time)
+{
+    MockHardwareGps *thiz = MockHardwareGps::mocked(self);
+    return thiz->set_position_mode(mode, recurrence, min_interval,
+                                   preferred_accuracy, preferred_time);
+}
+
+void
+u_hardware_gps_inject_time(UHardwareGps self, int64_t time, int64_t time_reference, int uncertainty)
+{
+    MockHardwareGps* thiz = MockHardwareGps::mocked(self);
+    return thiz->inject_time(time, time_reference, uncertainty);
+}
+
 TEST(AndroidGpsXtraDownloader, reading_configuration_from_valid_conf_file_works)
 {
     std::stringstream ss{gps_conf};
@@ -261,6 +322,28 @@
     provider.on_reference_location_updated(pos);
 }
 
+TEST(GpsProvider, time_requests_inject_current_time_into_the_hal)
+{
+    using namespace ::testing;
+
+    NiceMock<MockHardwareGps> hardwareGps;
+
+    gps::android::HardwareAbstractionLayer::Configuration configuration;
+    gps::android::HardwareAbstractionLayer hal(configuration);
+    std::shared_ptr<gps::HardwareAbstractionLayer> hal_ptr(&hal, [](gps::HardwareAbstractionLayer*){});
+
+    gps::Provider provider(hal_ptr);
+    int64_t time = 0;
+    EXPECT_CALL(hardwareGps, inject_time(_, _, 0)).Times(1).WillOnce(SaveArg<0>(&time));
+
+    auto t0 = std::chrono::duration_cast<std::chrono::milliseconds>(location::Clock::now().time_since_epoch());
+
+    gps::android::HardwareAbstractionLayer::on_request_utc_time(&hal);
+
+    auto t1 = std::chrono::duration_cast<std::chrono::milliseconds>(location::Clock::now().time_since_epoch());
+    EXPECT_THAT(time, AllOf(Ge(t0.count()), Le(t1.count())));
+}
+
 TEST(GpsProvider, updates_from_hal_are_passed_on_by_the_provider)
 {
     using namespace ::testing;

=== added directory 'tools'
=== added file 'tools/CMakeLists.txt'
--- tools/CMakeLists.txt	1970-01-01 00:00:00 +0000
+++ tools/CMakeLists.txt	2015-11-27 13:12:27 +0000
@@ -0,0 +1,1 @@
+configure_file(symbol_diff.in symbol_diff)

=== added file 'tools/symbol_diff.in'
--- tools/symbol_diff.in	1970-01-01 00:00:00 +0000
+++ tools/symbol_diff.in	2015-11-27 13:12:27 +0000
@@ -0,0 +1,70 @@
+#! /usr/bin/env python3
+
+#
+# Copyright (C) 2014 Canonical Ltd
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# Authored by: Michi Henning <[e-mail]>
+#
+
+import re
+import subprocess
+
+OLD_FILE = './debian/libubuntu-location-service@UBUNTU_LOCATION_SERVICE_VERSION_MAJOR@.symbols'
+NEW_FILE = './debian/libubuntu-location-service@UBUNTU_LOCATION_SERVICE_VERSION_MAJOR@/DEBIAN/symbols'
+
+def run():
+    old_regex = re.compile(r'^ (\(.*\))"(.*)" (.*)$')
+
+    old_syms = {}                                   # Dictionary containing symbol -> ( tag, version )
+    with open(OLD_FILE, encoding='utf=8') as file:
+        file.readline()                             # Skip first line, which is the library name and version
+        for line in file:
+            mo = old_regex.match(line)
+            if mo:
+                old_syms[mo.group(2)] = ( mo.group(1), mo.group(3) )
+            else:
+                raise Exception('Invalid input line in ' + OLD_FILE + ': ' + line)
+
+    new_regex = re.compile(r'^ (.*) .+$')
+
+    # Run the new symbols file through "c++filt | sort | uniq". We need
+    # the sort | uniq because, otherwise, we end up with duplicate demangled symbols.
+    with open(NEW_FILE) as infile, open('new_symbols', 'w') as outfile:
+        p = subprocess.Popen(['c++filt | sort | uniq'], shell=True, stdin=infile, stdout=subprocess.PIPE)
+
+        # For each symbol, if it is in the old dictionary, output the tags from the original
+        # symbol file, followed by the symbol and version. Otherwise, use "(c++)" as the tag
+        # and add " 0replaceme", so the new symbol will be accepted.
+        line = p.stdout.readline().decode('utf-8')
+        outfile.write(line)                         # Write library name and version
+        for line in p.stdout:
+            mo = new_regex.match(line.decode('utf-8'))
+            if (mo):
+                sym = mo.group(1)
+                try:
+                    tag, version = old_syms[sym]
+                except KeyError:
+                    tag = '(c++)'
+                    version = '0replaceme'
+                outfile.write(' {}"{}" {}\n'.format(tag, sym, version))
+            else:
+                raise Exception('Cannot parse demangled line: ' + line)
+
+    # Write the diff into /tmp/symbols.diff
+    with open('/tmp/symbols.diff', 'w') as outfile:
+        subprocess.call(['diff', '-u', OLD_FILE, 'new_symbols'], stdout=outfile)
+
+if __name__ == '__main__':
+    run()