Merge lp:~thomas-voss/location-service/adjust-default-timeout-for-gps-xtra-download into lp:location-service/15.04

Proposed by Thomas Voß on 2015-11-13
Status: Merged
Approved by: Alberto Mardegan on 2015-11-13
Approved revision: 202
Merged at revision: 202
Proposed branch: lp:~thomas-voss/location-service/adjust-default-timeout-for-gps-xtra-download
Merge into: lp:location-service/15.04
Diff against target: 25 lines (+1/-3)
2 files modified
src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp (+0/-2)
src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h (+1/-1)
To merge this branch: bzr merge lp:~thomas-voss/location-service/adjust-default-timeout-for-gps-xtra-download
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2015-11-13 Approve on 2015-11-13
Review via email: mp+277426@code.launchpad.net

This proposal supersedes a proposal from 2015-11-13.

Commit Message

Adjust default timeout for downloading GPS XTRA data.

30 seconds are perfectly fine, as operation without the xtra data
will take significantly longer.

Description of the Change

Adjust default timeout for downloading GPS XTRA data.

30 seconds are perfectly fine, as operation without the xtra data
will take significantly longer.

To post a comment you must log in.
Alberto Mardegan (mardy) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp'
2--- src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp 2015-10-19 13:04:06 +0000
3+++ src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.cpp 2015-11-13 10:22:34 +0000
4@@ -66,8 +66,6 @@
5 if (config.count("XTRA_SERVER_3") > 0)
6 result.xtra_hosts.push_back(config.get<std::string>("XTRA_SERVER_3"));
7
8- result.timeout = std::chrono::milliseconds{1500};
9-
10 return result;
11 }
12
13
14=== modified file 'src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h'
15--- src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h 2015-04-22 13:30:04 +0000
16+++ src/location_service/com/ubuntu/location/providers/gps/android_hardware_abstraction_layer.h 2015-11-13 10:22:34 +0000
17@@ -49,7 +49,7 @@
18 /** @brief Timeout on gps xtra download operations. */
19 std::chrono::milliseconds timeout
20 {
21- 5000
22+ 30000
23 };
24
25 /** Set of hosts serving GPS xtra data. */

Subscribers

People subscribed via source and target branches