Merge lp:~thomas-voss/evemu/fix-failing-construction-tests into lp:evemu

Proposed by Thomas Voß
Status: Merged
Merged at revision: 52
Proposed branch: lp:~thomas-voss/evemu/fix-failing-construction-tests
Merge into: lp:evemu
Diff against target: 20 lines (+2/-2)
1 file modified
python/evemu/tests/test_device.py (+2/-2)
To merge this branch: bzr merge lp:~thomas-voss/evemu/fix-failing-construction-tests
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Review via email: mp+99754@code.launchpad.net

Description of the change

Fixed failing construction tests for devices. Switched to /dev/input/event0 for construction tests.

Testing done:
=============

Tested on both i386 and amd64, see results below:

evemu.tests.test_device
    DeviceActionTestCase
        test_construct_from_dev_node_file................. ok
        test_construct_from_dev_node_name................. ok
        test_construct_from_prop_file_file................ ok
        test_construct_from_prop_file_name................ ok
        test_describe..................................... ok
        test_play_and_record.............................. ok
    DevicePropertiesTestCase
        test_get_abs_flat................................. ok
        test_get_abs_fuzz................................. ok
        test_get_abs_maximum.............................. ok
        test_get_abs_minimum.............................. ok
        test_get_abs_resolution........................... ok
        test_has_event_ev_abs............................. ok
        test_has_event_ev_key............................. ok
        test_has_prop..................................... ok
        test_id_bustype................................... ok
        test_id_product................................... ok
        test_id_vendor.................................... ok
        test_id_version................................... ok
        test_name......................................... ok
        test_version...................................... ok

evemu.tests.test_base
    EvEmuBaseTestCase
        test_c_symbols_found.............................. ok
        test_so_library_found............................. ok

----------------------------------------------------------------------
Ran 22 tests in 1.653s

OK
PASS: evemu-test-runner

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

I'm OK with this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'python/evemu/tests/test_device.py'
2--- python/evemu/tests/test_device.py 2011-11-30 20:12:07 +0000
3+++ python/evemu/tests/test_device.py 2012-03-28 15:14:19 +0000
4@@ -34,14 +34,14 @@
5 Verifies a Device can be constructed from an existing input device node
6 name.
7 """
8- d = evemu.Device("/dev/input/event10")
9+ d = evemu.Device("/dev/input/event0")
10
11 def test_construct_from_dev_node_file(self):
12 """
13 Verifies a Device can be constructed from an existing input device node
14 file object.
15 """
16- d = evemu.Device(open("/dev/input/event10"))
17+ d = evemu.Device(open("/dev/input/event0"))
18
19 def test_construct_from_prop_file_name(self):
20 """

Subscribers

People subscribed via source and target branches