Merge lp:~thomas-moenicke/ubuntu-keyboard/ubuntu-keyboard-language-menu-3 into lp:~thomas-moenicke/ubuntu-keyboard/ubuntu-keyboard-language-menu-2

Proposed by Thomas Moenicke
Status: Needs review
Proposed branch: lp:~thomas-moenicke/ubuntu-keyboard/ubuntu-keyboard-language-menu-3
Merge into: lp:~thomas-moenicke/ubuntu-keyboard/ubuntu-keyboard-language-menu-2
Diff against target: 45 lines (+6/-5)
3 files modified
qml/KeyboardContainer.qml (+1/-1)
src/plugin/inputmethod.cpp (+5/-0)
src/plugin/inputmethod_p.h (+0/-4)
To merge this branch: bzr merge lp:~thomas-moenicke/ubuntu-keyboard/ubuntu-keyboard-language-menu-3
Reviewer Review Type Date Requested Status
Thomas Moenicke Pending
Review via email: mp+192697@code.launchpad.net

Commit message

lm3

Description of the change

lm3

To post a comment you must log in.

Unmerged revisions

98. By Thomas Moenicke

legacy code gets original id from maliit-server, so it loads xml files that exist (fails to start osk otherwise)
fixed typo in English that prevented loading of regular layout after url layout

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/KeyboardContainer.qml'
2--- qml/KeyboardContainer.qml 2013-10-23 14:40:05 +0000
3+++ qml/KeyboardContainer.qml 2013-10-25 13:02:13 +0000
4@@ -54,7 +54,7 @@
5 if (layoutId === "url")
6 if (localeIsSupported(locale))
7 characterKeypadSource = "languages/"+locale+"/Keyboard_"+locale+"_url_search.qml";
8- if (layoutId === "en_us")
9+ if (layoutId === "en")
10 characterKeypadSource = "languages/en/Keyboard_en.qml";
11 if (layoutId === "es")
12 characterKeypadSource = "languages/es/Keyboard_es.qml";
13
14=== modified file 'src/plugin/inputmethod.cpp'
15--- src/plugin/inputmethod.cpp 2013-10-24 13:10:38 +0000
16+++ src/plugin/inputmethod.cpp 2013-10-25 13:02:13 +0000
17@@ -192,9 +192,14 @@
18 Q_UNUSED(id);
19 Q_D(InputMethod);
20
21+ // FIXME: Perhaps better to let both LayoutUpdater share the same KeyboardLoader instance?
22+ d->layout.updater.setActiveKeyboardId(id);
23+ d->layout.model.setActiveView(id);
24+
25 QString locale = QString(getenv("LANGUAGE"));
26 locale.truncate(2);
27 d->activeLanguage = locale;
28+ Q_EMIT activeLanguageChanged(d->activeLanguage);
29 d->setActiveKeyboardId(locale);
30 }
31
32
33=== modified file 'src/plugin/inputmethod_p.h'
34--- src/plugin/inputmethod_p.h 2013-10-24 12:55:54 +0000
35+++ src/plugin/inputmethod_p.h 2013-10-25 13:02:13 +0000
36@@ -257,10 +257,6 @@
37
38 void setActiveKeyboardId(const QString& id)
39 {
40- // FIXME: Perhaps better to let both LayoutUpdater share the same KeyboardLoader instance?
41- layout.updater.setActiveKeyboardId(id);
42- layout.model.setActiveView(id);
43-
44 qmlRootItem->setProperty("layoutId", id);
45 }
46

Subscribers

People subscribed via source and target branches

to all changes: