Merge lp:~thomas-moenicke/phablet-extras/maliit-plugins_fix_focus_out into lp:phablet-extras/maliit-plugins

[Thomas Moenicke]

fixed focusOut behavior: osk should hide when focus goes away from a focusObject that accepts input method. This needs a second patch in Qt to work

fixed focusOut behavior: osk should hide when focus goes away from a focusObject that accepts input method. This needs a second patch in Qt to work

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2111
http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-ci/16/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-quantal-armhf-ci/16
        deb: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-quantal-armhf-ci/16/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-quantal-i386-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-raring-armhf-ci/16
        deb: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-raring-armhf-ci/16/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-raring-i386-ci/16

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-extras-maliit-plugins-ci/16/rebuild

review: Approve (continuous-integration)

[Bill Filler (bfiller)]

what Qt change does it need?

[Bill Filler (bfiller)]

Also, the deb provided by jenkins doesn't have the maliit-keyboard package, just the nemo-keyboard. Please fix it so both packages get built so I can test it.

[Thomas Moenicke (thomas-moenicke)]

It needs a patch which is on its way to gerrit/Qt, so lets keep this on hold until we have a qtbase containing the patch. It will only work with the patch.

review: Abstain

[Thomas Moenicke (thomas-moenicke)]

https://codereview.qt-project.org/#change,54752

[lp:~thomas-moenicke/phablet-extras/maliit-plugins_fix_focus_out]

2111. By Thomas Moenicke on 2013-04-25

branch to get the new maliit-keyboard.

Approved by Bill Filler, PS Jenkins bot.

2112. By Thomas Moenicke on 2013-04-25

fixed focusOut behavior: osk should hide when focus goes away from a focusObject that accepts input method. This needs a second patch in Qt to work

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2112
http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-ci/19/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-quantal-armhf-ci/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-quantal-i386-ci/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-raring-armhf-ci/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-extras-maliit-plugins-raring-i386-ci/19/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-extras-maliit-plugins-ci/19/rebuild

review: Needs Fixing (continuous-integration)

[Thomas Moenicke (thomas-moenicke)]

it already went in with the other MR
https://code.launchpad.net/~thomas-moenicke/phablet-extras/maliit-plugins_stretched-sizes/+merge/160295

so i will reject this one

Unmerged revisions

2112. By Thomas Moenicke on 2013-04-25

fixed focusOut behavior: osk should hide when focus goes away from a focusObject that accepts input method. This needs a second patch in Qt to work

=== modified file 'maliit-keyboard/plugin/inputmethod.cpp'
--- maliit-keyboard/plugin/inputmethod.cpp	2013-04-11 11:47:44 +0000
+++ maliit-keyboard/plugin/inputmethod.cpp	2013-04-25 19:20:30 +0000
@@ -448,6 +448,11 @@
     return d->layout.updater.activeKeyboardId();
 }
 
+void InputMethod::handleFocusChange(bool focusIn) {
+    if (not focusIn)
+        hide();
+}
+
 void InputMethod::handleAppOrientationChanged(int angle)
 {
     Q_D(InputMethod);

=== modified file 'maliit-keyboard/plugin/inputmethod.h'
--- maliit-keyboard/plugin/inputmethod.h	2013-03-22 16:40:29 +0000
+++ maliit-keyboard/plugin/inputmethod.h	2013-04-25 19:20:30 +0000
@@ -64,6 +64,7 @@
     virtual void setActiveSubView(const QString &id,
                                   Maliit::HandlerState state = Maliit::OnScreen);
     virtual QString activeSubView(Maliit::HandlerState state = Maliit::OnScreen) const;
+    virtual void handleFocusChange(bool focusIn);
     virtual void handleAppOrientationChanged(int angle);
     virtual bool imExtensionEvent(MImExtensionEvent *event);
     virtual void setKeyOverrides(const QMap<QString, QSharedPointer<MKeyOverride> > &overrides);